| Message ID | 577d5da1.howAJT6W/zY/7Gi8%james.smart@broadcom.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On 07/06/2016 09:36 PM, James Smart wrote: > > Fix SLI mode 2 config failure > > Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com> > Signed-off-by: James Smart <james.smart@broadcom.com> > --- > drivers/scsi/lpfc/lpfc_sli.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c > index 6eef972..b1ddbaa 100644 > --- a/drivers/scsi/lpfc/lpfc_sli.c > +++ b/drivers/scsi/lpfc/lpfc_sli.c > @@ -4696,6 +4696,8 @@ lpfc_sli_hba_setup(struct lpfc_hba *phba) > "Not supported by adapter.\n"); > if (rc && mode != 2) > rc = lpfc_sli_config_port(phba, 2); > + else if (rc && mode == 2) > + rc = lpfc_sli_config_port(phba, 3); > if (rc) > goto lpfc_sli_hba_setup_error; > > Hmm. Maybe a code reorg here if (rc) { if (mode == 2) .. else .. goto ... } would make things easier to read. But it's not that important. Reviewed-by: Hannes Reinecke <hare@suse.com> Cheers, Hannes
diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index 6eef972..b1ddbaa 100644 --- a/drivers/scsi/lpfc/lpfc_sli.c +++ b/drivers/scsi/lpfc/lpfc_sli.c @@ -4696,6 +4696,8 @@ lpfc_sli_hba_setup(struct lpfc_hba *phba) "Not supported by adapter.\n"); if (rc && mode != 2) rc = lpfc_sli_config_port(phba, 2); + else if (rc && mode == 2) + rc = lpfc_sli_config_port(phba, 3); if (rc) goto lpfc_sli_hba_setup_error;