| Message ID | 577d5da6.Csc9NMYwiS/8EdfU%james.smart@broadcom.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On 07/06/2016 09:36 PM, James Smart wrote: > > Correct Port reset resulting in FC port going offline > > Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com> > Signed-off-by: James Smart <james.smart@broadcom.com> > --- > drivers/scsi/lpfc/lpfc_init.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c > index 6e11574..f4b3548 100644 > --- a/drivers/scsi/lpfc/lpfc_init.c > +++ b/drivers/scsi/lpfc/lpfc_init.c > @@ -1595,9 +1595,10 @@ lpfc_sli4_port_sta_fn_reset(struct lpfc_hba *phba, int mbx_action, > * ready before performing reset. > */ > rc = lpfc_sli4_pdev_status_reg_wait(phba); > - if (!rc) > + if (rc) > return rc; > } > + > /* need reset: attempt for port recovery */ > if (en_rn_msg) > lpfc_printf_log(phba, KERN_ERR, LOG_INIT, > Reviewed-by: Hannes Reinecke <hare@suse.com> Cheers, Hannes
diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index 6e11574..f4b3548 100644 --- a/drivers/scsi/lpfc/lpfc_init.c +++ b/drivers/scsi/lpfc/lpfc_init.c @@ -1595,9 +1595,10 @@ lpfc_sli4_port_sta_fn_reset(struct lpfc_hba *phba, int mbx_action, * ready before performing reset. */ rc = lpfc_sli4_pdev_status_reg_wait(phba); - if (!rc) + if (rc) return rc; } + /* need reset: attempt for port recovery */ if (en_rn_msg) lpfc_printf_log(phba, KERN_ERR, LOG_INIT,