diff mbox series

scsi: qlogic_cs: fix irqf_shared, share same irq with pcmcia controller

Message ID 57837fce.3209.188665c4d0d.Coremail.yxj790222@163.com (mailing list archive)
State Changes Requested
Headers show
Series scsi: qlogic_cs: fix irqf_shared, share same irq with pcmcia controller | expand

Commit Message

尤晓杰 May 29, 2023, 7:15 a.m. UTC
From 82c1d0f88243f8ed1ffaeea98d775abd58866b1b Mon Sep 17 00:00:00 2001
From: You Xiaojie <yxj790222@163.com>
Date: Fri, 21 Apr 2023 19:02:15 +0800
Subject: [PATCH] qlogic_cs: fix IRQF_SHARED

Signed-off-by: You Xiaojie <yxj790222@163.com>
---
 drivers/scsi/pcmcia/qlogic_stub.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--

Comments

Bart Van Assche June 7, 2023, 5:22 p.m. UTC | #1
On 5/29/23 00:15, 尤晓杰 wrote:
>  From 82c1d0f88243f8ed1ffaeea98d775abd58866b1b Mon Sep 17 00:00:00 2001
> From: You Xiaojie <yxj790222@163.com>
> Date: Fri, 21 Apr 2023 19:02:15 +0800
> Subject: [PATCH] qlogic_cs: fix IRQF_SHARED
> 
> Signed-off-by: You Xiaojie <yxj790222@163.com>
> ---
>   drivers/scsi/pcmcia/qlogic_stub.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/pcmcia/qlogic_stub.c b/drivers/scsi/pcmcia/qlogic_stub.c
> index 310d0b6586a6..4dbb938790c2 100644
> --- a/drivers/scsi/pcmcia/qlogic_stub.c
> +++ b/drivers/scsi/pcmcia/qlogic_stub.c
> @@ -122,7 +122,7 @@ static struct Scsi_Host *qlogic_detect(struct scsi_host_template *host,
>   	priv->shost = shost;
>   	priv->int_type = INT_TYPE;					
>   
> -	if (request_irq(qlirq, qlogicfas408_ihandl, 0, qlogic_name, shost))
> +	if (request_irq(qlirq, qlogicfas408_ihandl, IRQF_SHARED, qlogic_name, shost))
>   		goto free_scsi_host;
>   
>   	sprintf(priv->qinfo,

A patch description is missing. Please explain whether this patch is
the result of reviewing source code and also whether or not this patch
has been tested on a system that has the hardware supported by the
modified driver.

Thanks,

Bart.
diff mbox series

Patch

diff --git a/drivers/scsi/pcmcia/qlogic_stub.c b/drivers/scsi/pcmcia/qlogic_stub.c
index 310d0b6586a6..4dbb938790c2 100644
--- a/drivers/scsi/pcmcia/qlogic_stub.c
+++ b/drivers/scsi/pcmcia/qlogic_stub.c
@@ -122,7 +122,7 @@  static struct Scsi_Host *qlogic_detect(struct scsi_host_template *host,
 	priv->shost = shost;
 	priv->int_type = INT_TYPE;					
 
-	if (request_irq(qlirq, qlogicfas408_ihandl, 0, qlogic_name, shost))
+	if (request_irq(qlirq, qlogicfas408_ihandl, IRQF_SHARED, qlogic_name, shost))
 		goto free_scsi_host;
 
 	sprintf(priv->qinfo,