diff mbox

[01/14] lpfc: Double WQ element count to keep iops up

Message ID 57acc584.71VgLPvkdT6sQCgh%james.smart@broadcom.com (mailing list archive)
State Changes Requested, archived
Headers show

Commit Message

James Smart Aug. 11, 2016, 6:35 p.m. UTC 
Double WQ element count to keep iops up

On embedded io queues, use the default element count, which is twice the
size of the default large WQE element count.

Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <james.smart@broadcom.com>
---
 drivers/scsi/lpfc/lpfc_init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Johannes Thumshirn Aug. 12, 2016, 8:21 a.m. UTC | #1 
On Thu, Aug 11, 2016 at 11:35:48AM -0700, James Smart wrote:
> 
> Double WQ element count to keep iops up
> 
> On embedded io queues, use the default element count, which is twice the
> size of the default large WQE element count.
> 
> Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
> Signed-off-by: James Smart <james.smart@broadcom.com>
> ---
>  drivers/scsi/lpfc/lpfc_init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
> index adf61b43..64b6313 100644
> --- a/drivers/scsi/lpfc/lpfc_init.c
> +++ b/drivers/scsi/lpfc/lpfc_init.c
> @@ -7349,7 +7349,7 @@ lpfc_sli4_queue_create(struct lpfc_hba *phba)
>  		if (phba->fcp_embed_io) {
>  			qdesc = lpfc_sli4_queue_alloc(phba,
>  						      LPFC_WQE128_SIZE,
> -						      LPFC_WQE128_DEF_COUNT);
> +						      phba->sli4_hba.wq_ecount);
>  		} else {
>  			qdesc = lpfc_sli4_queue_alloc(phba,
>  						      phba->sli4_hba.wq_esize,


Hmm what about:

u32 entry_size;

[...]

if (phba->fc_embed_io)
	entry_size = LPFC_WQE128_DEF_SIZE;
else
	entry_size = phba->sli4_hba.wq_esize;

qdesc = lpfc_sli4_queue_alloc(phba,
			      entry_size,
			      phba->sli4_hba.wq_ecount);


Johannes
diff mbox

Patch

diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index adf61b43..64b6313 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -7349,7 +7349,7 @@  lpfc_sli4_queue_create(struct lpfc_hba *phba)
 		if (phba->fcp_embed_io) {
 			qdesc = lpfc_sli4_queue_alloc(phba,
 						      LPFC_WQE128_SIZE,
-						      LPFC_WQE128_DEF_COUNT);
+						      phba->sli4_hba.wq_ecount);
 		} else {
 			qdesc = lpfc_sli4_queue_alloc(phba,
 						      phba->sli4_hba.wq_esize,