From patchwork Fri Aug 4 16:40:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hannes Reinecke X-Patchwork-Id: 9881715 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E0BC860360 for ; Fri, 4 Aug 2017 16:40:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BAEF32893B for ; Fri, 4 Aug 2017 16:40:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AFB0F28996; Fri, 4 Aug 2017 16:40:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2E112288BA for ; Fri, 4 Aug 2017 16:40:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752814AbdHDQkH (ORCPT ); Fri, 4 Aug 2017 12:40:07 -0400 Received: from mx2.suse.de ([195.135.220.15]:34421 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752433AbdHDQkG (ORCPT ); Fri, 4 Aug 2017 12:40:06 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id AA2A3AEDF; Fri, 4 Aug 2017 16:40:04 +0000 (UTC) Subject: Re: [PATCH] hpsa: disable volume status check for older controller From: Hannes Reinecke To: Meelis Roos Cc: Don Brace , "Martin K. Petersen" , Christoph Hellwig , linux-scsi@vger.kernel.org, Hannes Reinecke References: <1501686356-56888-1-git-send-email-hare@suse.de> <5be60e11-a3e7-14d1-0a67-db4fe909f004@suse.de> Organization: SUSE Linux GmbH Message-ID: <823f4619-2596-8720-a10e-ecb056eaaf32@suse.de> Date: Fri, 4 Aug 2017 18:40:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <5be60e11-a3e7-14d1-0a67-db4fe909f004@suse.de> Content-Language: en-US Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 08/04/2017 06:36 PM, Hannes Reinecke wrote: > On 08/04/2017 06:26 PM, Meelis Roos wrote: >>> Older Controller might not support volume status, so disable >>> it if 'hpsa_allow_any' is present. >> >> It makes my DL380G4 boot with hpsa.hpsa_allow_any=1 and it seems to >> work. Howevere, there are multiole verbose dmesg entries about failing >> things: >> > Hehe. How cool is that? > >> 0.267224] HP HPSA Driver (v 3.4.18-0) >> [ 0.267351] hpsa 0000:04:03.0: unsupported board ID: 0x40910e11 >> [ 0.267494] hpsa 0000:04:03.0: unsupported board ID: 0x40910e11 >> [ 0.267695] hpsa 0000:04:03.0: PCI IRQ 51 -> rerouted to legacy IRQ 19 >> [ 0.267889] hpsa 0000:04:03.0: Physical aborts not supported >> [ 0.268036] hpsa 0000:04:03.0: Logical aborts not supported >> [ 0.268163] hpsa 0000:04:03.0: HP SSD Smart Path aborts not supported >> [ 0.448240] scsi host0: hpsa >> [ 0.452228] hpsa 0000:04:03.0: report luns requested format 2, got 0 >> [ 0.453950] hpsa 0000:04:03.0: hpsa0: hpsa_update_device_info: can't get device id for host 0:C0:T0:L0 Direct-Access MAN3735MC >> [ 0.454312] hpsa 0000:04:03.0: SCSI status: LUN:0000000000000000 CDB:26000000000015000801000000000000 >> [ 0.454525] hpsa 0000:04:03.0: SCSI Status = 02, Sense key = 0x05, ASC = 0x3a, ASCQ = 0x00 > Curious. CDB 26 is a vendor specific command, and the controller > responds with 'Medium not present'. > Will be checking what's happening here. > >> Among these, the following show up red in dmesg: >> >> report luns requested format 2, got 0 >> hpsa0: hpsa_update_device_info: can't get device id for host 0:C0:T0:L0 Direct-Access MAN3735MC >> hpsa0: hpsa_update_device_info: can't get device id for host 0:C0:T-1:L-1 Direct-Access MAP3735NC >> report luns requested format 2, got 0 >> > Hmm. Looking into it. > > But thanks for testing! > You should be able to suppress the "can't get device id' messages with: %d:C0:T%d:L%d\t%s\t%.16s\n", h->ctlr, __func__, Cheers, Hannes diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 2cf6cccf067f..56fd654c1ecd 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -3813,7 +3813,7 @@ static int hpsa_update_device_info(struct ctlr_info *h, memset(this_device->device_id, 0, sizeof(this_device->device_id)); if (hpsa_get_device_id(h, scsi3addr, this_device->device_id, 8, - sizeof(this_device->device_id))) + sizeof(this_device->device_id)) < 0) dev_err(&h->pdev->dev, "hpsa%d: %s: can't get device id for host