From patchwork Thu Oct 13 21:05:49 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sathya Prakash Veerichetty X-Patchwork-Id: 9375763 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E0CAB60487 for ; Thu, 13 Oct 2016 21:06:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CDB632A198 for ; Thu, 13 Oct 2016 21:06:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C0ABC2A1E2; Thu, 13 Oct 2016 21:06:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 40EB42A198 for ; Thu, 13 Oct 2016 21:06:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756239AbcJMVFx (ORCPT ); Thu, 13 Oct 2016 17:05:53 -0400 Received: from mail-io0-f175.google.com ([209.85.223.175]:34010 "EHLO mail-io0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752978AbcJMVFw (ORCPT ); Thu, 13 Oct 2016 17:05:52 -0400 Received: by mail-io0-f175.google.com with SMTP id r30so99879790ioi.1 for ; Thu, 13 Oct 2016 14:05:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:references:in-reply-to:mime-version:thread-index:date :message-id:subject:to:cc; bh=YKZetBgae14r/cpv+MzWzjI68a6EduS3KOhJULPGivU=; b=X8zuTInJJ7yhPHwRSv7DeBsKsSV5dYtjfAQO6na8pa8I5BvnRz8S8DSTlrSHKrM1uu qBQouPZtGW/huY0JwLiL4do8B56YfniI3HdCVILsetasZABS0EpDCGrgEVxvSjfLFiCa UVVkDPXDMG4e2DVRKL72FCrclYsUsakm9oXrE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:references:in-reply-to:mime-version :thread-index:date:message-id:subject:to:cc; bh=YKZetBgae14r/cpv+MzWzjI68a6EduS3KOhJULPGivU=; b=nHsNLz2GeVeuf8PsztGFlNIEEltMtgKN0xWqMg0hefg9dy0+NykwcqjSUqEdngN9FQ wT3GY1bM5sBNV7sgDRdOc7N7Uwkus9yx/ARPRq4H6duDowDxJRbGguZB9n2Mn1j76d+D FBNqlv0pdHnAIB4xScl3IPHpneCo8f9CrR81HK5mpHdleoIKEbj8hgsPXLBBdvu5CQ3P hKb4xjYeL/sQ6jh/cw+zQG2dar/ws1K6Z7V9XeH4Qtm2NNLJLFgDv5d+JevF3Zgcjh0M Syn3EtVyvRjETqqbTTTg7lW+cgSXDIfAuZ0Q7CELbfWEn9CU6Mjub/rv+ONv9FUZd4zU 0ILA== X-Gm-Message-State: AA6/9Rnjw0NhlOq3zw2du05haQ9BJ4SGcO7vLwqN4zeLavkEhRFi6IPjyR+F+tvn3hxG//utN5Yj3X5gpNUNgyIS X-Received: by 10.107.138.65 with SMTP id m62mr10413409iod.213.1476392750950; Thu, 13 Oct 2016 14:05:50 -0700 (PDT) From: Sathya Prakash Veerichetty References: <1476388433-2539-1-git-send-email-adam.manzanares@hgst.com> <1476388433-2539-3-git-send-email-adam.manzanares@hgst.com> In-Reply-To: <1476388433-2539-3-git-send-email-adam.manzanares@hgst.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQJqo2fd4WfmfSGKw2JuJJmyaDtAEwJB+yONn2PSxVA= Date: Thu, 13 Oct 2016 15:05:49 -0600 Message-ID: <8338586db99fd444337d27f9abc3a777@mail.gmail.com> Subject: RE: [PATCH v4 2/4] fusion: remove iopriority handling To: Adam Manzanares , axboe@kernel.dk, tj@kernel.org, dan.j.williams@intel.com, hare@suse.de, martin.petersen@oracle.com, mchristi@redhat.com, toshi.kani@hpe.com, ming.lei@canonical.com, Chaitra Basappa , Suganath Prabu Subramani Cc: linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, PDL-MPT-FUSIONLINUX , linux-scsi@vger.kernel.org, Adam Manzanares Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP By removing the code below, we put all the commands for all the types of devices (SAS/SATA) as simple-Q (requeue as the device require) and I am not sure whether it is the intention of this change. -----Original Message----- From: Adam Manzanares [mailto:adam.manzanares@hgst.com] Sent: Thursday, October 13, 2016 1:54 PM To: axboe@kernel.dk; tj@kernel.org; dan.j.williams@intel.com; hare@suse.de; martin.petersen@oracle.com; mchristi@redhat.com; toshi.kani@hpe.com; ming.lei@canonical.com; sathya.prakash@broadcom.com; chaitra.basappa@broadcom.com; suganath-prabu.subramani@broadcom.com Cc: linux-block@vger.kernel.org; linux-ide@vger.kernel.org; linux-kernel@vger.kernel.org; MPT-FusionLinux.pdl@broadcom.com; linux-scsi@vger.kernel.org; Adam Manzanares; Adam Manzanares Subject: [PATCH v4 2/4] fusion: remove iopriority handling The request priority is now by default coming from the ioc. It was not clear what this code was trying to do based upon the iopriority class or data. The driver should check that a device supports priorities and use them according to the specificiations of ioprio. Signed-off-by: Adam Manzanares --- drivers/message/fusion/mptscsih.c | 5 ----- 1 file changed, 5 deletions(-) -- 2.1.4 Western Digital Corporation (and its subsidiaries) E-mail Confidentiality Notice & Disclaimer: This e-mail and any files transmitted with it may contain confidential or legally privileged information of WDC and/or its affiliates, and are intended solely for the use of the individual or entity to which they are addressed. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited. If you have received this e-mail in error, please notify the sender immediately and delete the e-mail in its entirety from your system. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/message/fusion/mptscsih.c b/drivers/message/fusion/mptscsih.c index 6c9fc11..4740bb6 100644 --- a/drivers/message/fusion/mptscsih.c +++ b/drivers/message/fusion/mptscsih.c @@ -1369,11 +1369,6 @@ mptscsih_qcmd(struct scsi_cmnd *SCpnt) if ((vdevice->vtarget->tflags & MPT_TARGET_FLAGS_Q_YES) && (SCpnt->device->tagged_supported)) { scsictl = scsidir | MPI_SCSIIO_CONTROL_SIMPLEQ; - if (SCpnt->request && SCpnt->request->ioprio) { - if (((SCpnt->request->ioprio & 0x7) == 1) || - !(SCpnt->request->ioprio & 0x7)) - scsictl |= MPI_SCSIIO_CONTROL_HEADOFQ; - } } else scsictl = scsidir | MPI_SCSIIO_CONTROL_UNTAGGED;