From patchwork Tue Sep 1 15:43:50 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vitaly Kuznetsov X-Patchwork-Id: 7106201 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 223129F1CD for ; Tue, 1 Sep 2015 15:44:13 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 50366205E9 for ; Tue, 1 Sep 2015 15:44:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6733D205C2 for ; Tue, 1 Sep 2015 15:44:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752280AbbIAPny (ORCPT ); Tue, 1 Sep 2015 11:43:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44553 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751901AbbIAPnx (ORCPT ); Tue, 1 Sep 2015 11:43:53 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id A09C6A4544; Tue, 1 Sep 2015 15:43:53 +0000 (UTC) Received: from vitty.brq.redhat.com.smtpmail-local-domain (vitty.brq.redhat.com [10.34.26.3]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t81FhoSl013485 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Tue, 1 Sep 2015 11:43:51 -0400 From: Vitaly Kuznetsov To: James Bottomley Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "K. Y. Srinivasan" , Long Li , Dexuan Cui Subject: Re: [PATCH] scsi_scan: move 'INQUIRY result too short' message to debug level References: <1441025401-30044-1-git-send-email-vkuznets@redhat.com> <1441115361.2682.2.camel@HansenPartnership.com> Date: Tue, 01 Sep 2015 17:43:50 +0200 In-Reply-To: <1441115361.2682.2.camel@HansenPartnership.com> (James Bottomley's message of "Tue, 01 Sep 2015 07:49:21 -0600") Message-ID: <87io7udu15.fsf@vitty.brq.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP James Bottomley writes: > On Mon, 2015-08-31 at 14:50 +0200, Vitaly Kuznetsov wrote: >> Some Hyper-V hosts are known for ignoring SPC-2/3/4 requirement >> for 'INQUIRY data (see table ...) shall contain at least 36 bytes'. As a >> result we get tons on 'scsi 0:7:1:1: scsi scan: INQUIRY result too short >> (5), using 36' messages on console. As Hyper-V is also known for its >> serial port being extremely slow multi-VCPU guests we get CPU blocked >> putting these (useless) messages on console (e.g. happens when we add >> multiple disks). Move them to debug level. > > This isn't an ignorable debug message. It means the inquiry information > the system relies on will be false, so it's fairly essential for bug > reports. It could be made a once per device print, but I don't think we > can eliminate it. I see. What if we introduce a special flag to mark such known-as-broken hosts? E.g.: diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index f9f3f82..c6ffb5c 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c @@ -701,9 +701,10 @@ static int scsi_probe_lun(struct scsi_device *sdev, unsigned char *inq_result, * strings. */ if (sdev->inquiry_len < 36) { - sdev_printk(KERN_INFO, sdev, - "scsi scan: INQUIRY result too short (%d)," - " using 36\n", sdev->inquiry_len); + if (!sdev->host->hostt->short_inquiry) + sdev_printk(KERN_INFO, sdev, + "scsi scan: INQUIRY result too short (%d)," + " using 36\n", sdev->inquiry_len); sdev->inquiry_len = 36; } diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index 3c6584f..f3b4d0f 100644 --- a/drivers/scsi/storvsc_drv.c +++ b/drivers/scsi/storvsc_drv.c @@ -1711,6 +1711,7 @@ static struct scsi_host_template scsi_driver = { /* Make sure we dont get a sg segment crosses a page boundary */ .dma_boundary = PAGE_SIZE-1, .no_write_same = 1, + .short_inquiry = 1, }; enum { diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h index e113c75..04aefad 100644 --- a/include/scsi/scsi_host.h +++ b/include/scsi/scsi_host.h @@ -454,6 +454,12 @@ struct scsi_host_template { unsigned no_async_abort:1; /* + * True if this host adapter returns short (<36 bytes) resposes to + * INQUIRY requests. + */ + unsigned short_inquiry:1; + + /* * Countdown for host blocking with no commands outstanding. */ unsigned int max_host_blocked;