From patchwork Sat Sep 26 22:04:06 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 7272281 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 38231BEEC1 for ; Sat, 26 Sep 2015 22:06:03 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 415B4206B1 for ; Sat, 26 Sep 2015 22:06:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 45A4320641 for ; Sat, 26 Sep 2015 22:06:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932630AbbIZWF7 (ORCPT ); Sat, 26 Sep 2015 18:05:59 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:34078 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932351AbbIZWEm (ORCPT ); Sat, 26 Sep 2015 18:04:42 -0400 Received: by padhy16 with SMTP id hy16so137817336pad.1 for ; Sat, 26 Sep 2015 15:04:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=/sTlcjx3ySMkTaTD76qmlRxei1MjlYLKzO3orLUeRVI=; b=ToPp3XhFNOPYuHJbim34VsgUrFMW7+OsNZtm2JvcNM/lDB/ry09PeRfzE0dcsFi9ED ILpmTPI+H3EJJkMMCKaeTsCQKUv+4CHbETwJzNYPFoZGXbwPHA/CErkRKwFPiB61r7do p8MrG5UoFzlDayLXsbAFy6WUtiaiwhbnzI3JhnoKWNaEj+f3cpAr23jsuftLnFHDRxP7 Z955AiEHyGI8KkJD99xQatNLozwEXg3u9smssCJAVARv1aDViHL/fuXSCBDtLUXQ39Vr fo2zRkrEWTvdaYhRvq0j0BIIJBKsCl5vR15TtVLKs45YbIV6Y93YACx2+UeLfywzOlEL fdlQ== X-Gm-Message-State: ALoCoQlqec3yE18JdnBzWpgprAb9EV9iMeD/iqutkxGal72esjMcK+w2Kkp7YRPI8jVdQdizUV7a X-Received: by 10.68.191.200 with SMTP id ha8mr16768041pbc.72.1443305081197; Sat, 26 Sep 2015 15:04:41 -0700 (PDT) Received: from localhost (c-67-169-81-235.hsd1.ca.comcast.net. [67.169.81.235]) by smtp.gmail.com with ESMTPSA id qy5sm10933604pbb.16.2015.09.26.15.04.40 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 26 Sep 2015 15:04:40 -0700 (PDT) From: Viresh Kumar To: Greg Kroah-Hartman Cc: linaro-kernel@lists.linaro.org, QCA ath9k Development , Intel Linux Wireless , Viresh Kumar , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux-bluetooth@vger.kernel.org, iommu@lists.linux-foundation.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, linux-edac@vger.kernel.org, linux-mm@kvack.org, alsa-devel@alsa-project.org Subject: [PATCH V5 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' Date: Sat, 26 Sep 2015 15:04:06 -0700 Message-Id: <8d3d3428c3a36f821e4c3d8563d094ca4b4763fd.1443304934.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.4.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP global_lock is defined as an unsigned long and accessing only its lower 32 bits from sysfs is incorrect, as we need to consider other 32 bits for big endian 64-bit systems. There are no such platforms yet, but the code needs to be robust for such a case. Fix that by changing type of 'global_lock' to u32. Signed-off-by: Viresh Kumar Acked-by: Rafael J. Wysocki --- BCC'd a lot of people (rather than cc'ing them) to make sure - the series reaches them - mailing lists do not block the patchset due to long cc list - and we don't spam the BCC'd people for every reply V4->V5: - Switch back to the original solution of making global_lock u32. --- drivers/acpi/ec_sys.c | 2 +- drivers/acpi/internal.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/ec_sys.c b/drivers/acpi/ec_sys.c index b4c216bab22b..bea8e425a8de 100644 --- a/drivers/acpi/ec_sys.c +++ b/drivers/acpi/ec_sys.c @@ -128,7 +128,7 @@ static int acpi_ec_add_debugfs(struct acpi_ec *ec, unsigned int ec_device_count) if (!debugfs_create_x32("gpe", 0444, dev_dir, (u32 *)&first_ec->gpe)) goto error; if (!debugfs_create_bool("use_global_lock", 0444, dev_dir, - (u32 *)&first_ec->global_lock)) + &first_ec->global_lock)) goto error; if (write_support) diff --git a/drivers/acpi/internal.h b/drivers/acpi/internal.h index 9e426210c2a8..9db196de003c 100644 --- a/drivers/acpi/internal.h +++ b/drivers/acpi/internal.h @@ -138,7 +138,7 @@ struct acpi_ec { unsigned long gpe; unsigned long command_addr; unsigned long data_addr; - unsigned long global_lock; + u32 global_lock; unsigned long flags; unsigned long reference_count; struct mutex mutex;