From patchwork Mon Nov 27 05:36:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gurumurthy, Anil" X-Patchwork-Id: 10075771 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 01F8E602BD for ; Mon, 27 Nov 2017 05:36:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EABA528ADF for ; Mon, 27 Nov 2017 05:36:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DFC1528B35; Mon, 27 Nov 2017 05:36:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI,RCVD_IN_SORBS_WEB autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9A27728ADF for ; Mon, 27 Nov 2017 05:36:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751197AbdK0FgT (ORCPT ); Mon, 27 Nov 2017 00:36:19 -0500 Received: from mail-dm3nam03on0040.outbound.protection.outlook.com ([104.47.41.40]:31552 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750787AbdK0FgR (ORCPT ); Mon, 27 Nov 2017 00:36:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=yKf/8cBRO4RF+45DrFV7GqStyml7g/+h3cj6CMgJoEs=; b=C51FnOCMEGg0vNqeH4HWIXFwZr+1laXAzjs3gsFmqOlCke8tEATBs7GwmbehfTIY7ivZtWqJC9opTiFGcidv5DAa2mwWFbdnOBUgGXUxmEobcMAW0LZLDjl6S7GZH7WAx/HnWROO8KdV/QLxrdpNXeDuMiI+/b6h5SR0d6CEQd0= Received: from BY2PR0701MB2023.namprd07.prod.outlook.com (10.163.156.13) by MWHPR07MB3053.namprd07.prod.outlook.com (10.172.97.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.260.4; Mon, 27 Nov 2017 05:36:14 +0000 Received: from BY2PR0701MB2023.namprd07.prod.outlook.com ([10.163.156.13]) by BY2PR0701MB2023.namprd07.prod.outlook.com ([10.163.156.13]) with mapi id 15.20.0260.006; Mon, 27 Nov 2017 05:36:13 +0000 From: "Gurumurthy, Anil" To: Colin King , "Kalluru, Sudarsana" , "James E . J . Bottomley" , "Martin K . Petersen" , "linux-scsi@vger.kernel.org" CC: "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] scsi: bfa: use setup_timer instead of init_timer Thread-Topic: [PATCH] scsi: bfa: use setup_timer instead of init_timer Thread-Index: AQHTZSpL13AB0FxiZUGgwgES0vxyzKMnt6CA Date: Mon, 27 Nov 2017 05:36:13 +0000 Message-ID: References: <20171124134402.32739-1-colin.king@canonical.com> In-Reply-To: <20171124134402.32739-1-colin.king@canonical.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Anil.Gurumurthy@cavium.com; x-originating-ip: [111.93.218.67] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; MWHPR07MB3053; 6:W7Ttdg8hU/aloH7EHhfdkR5L182+u85tKzlrQmTKMowseg+dmdLQVnLffyrreDLo8d7MAg25zt9EGj0fCxcN56XnTrY34W/q1Kpzrlla8pE88BBSmXsVTZeaXd4HzDO4b+4mBBk5p0Rdkl1EsQTWn4UdychQMO0sG1qM8NiYQtMX3Z/jVa9sh0mKDmwTZLD2oEeBreeGnkWlTHvvYTJCUAPEzxk611DEO0sTK41AT8KI8qrF+zk1TMKMStfAsDLvpKFF3Xr6Ha8StT8XC2MiEVMmheKOzjYmCKPe0sjAvD8KCSL3zmkOfaQZ3t4Mc01VsLZLfIpgHw8oevsK0MQ/DDo0WFjUGE2DyInk7vdInDo=; 5:Mm3rZIIVlekrjaClJEm2WdUXPGtd3Nz1klfiZ/+2yncMi4gQ/1FI9SUtXfUyoAtplOi4ZhvocPq4JziLwaV8FlEzlob0JJDuWuLjHjWqLoq2vi9VUhNvVg3UyfKE0ygo5of40LJbE7OrQEbL0Hk8ywmt4ZTPGYpwFVbVAId+Oio=; 24:UqtqJUxj+XnFELLq4junddcPssWbnXfiS6ANjrF7MJIESHR/aka9QlX7pm14AGel+UYQXZzJesXC8MX96JNkOsVo8rCgtHdNbImmMLWN758=; 7:RCbyIjWqvL5rfOlXjpaie5MgNhv2+5kyYzYYM7QqkC61GeL+5fe60kDo6Pmr4VCcxKdrRql9+pqCZqlOZjGVt9VpMe7wNy0K56QMXKGogXJxKbTBcdzGEak0V/IQ7tF88HchpbOS7WyPXsypMal5EypyEicSisjI/ppxL7nQevrjYxRSISGwm2zUAjokIoaqP4fAegv15olSeQfY2f0mBkuQrKjuzWysz+VaCzt8UpVDjdsXo06ehGsgPDUO8krI x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(6009001)(366004)(346002)(376002)(189002)(199003)(13464003)(25786009)(76176999)(316002)(54356999)(97736004)(53936002)(2950100002)(9686003)(72206003)(53546010)(110136005)(101416001)(74316002)(54906003)(2900100001)(189998001)(305945005)(7736002)(2906002)(77096006)(6436002)(99286004)(6116002)(66066001)(102836003)(81156014)(81166006)(68736007)(478600001)(6246003)(105586002)(106356001)(33656002)(3280700002)(3660700001)(50986999)(3846002)(86362001)(14454004)(8936002)(2501003)(229853002)(8676002)(4326008)(55016002)(6506006)(7696005)(5660300001); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR07MB3053; H:BY2PR0701MB2023.namprd07.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; x-ms-office365-filtering-correlation-id: 1b369129-60a3-48eb-e631-08d53558c610 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603258); SRVR:MWHPR07MB3053; x-ms-traffictypediagnostic: MWHPR07MB3053: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(104084551191319)(146099531331640)(198206253151910); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(3231022)(10201501046)(3002001)(93006095)(93001095)(6041248)(20161123555025)(20161123562025)(20161123560025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(201708071742011); SRVR:MWHPR07MB3053; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:MWHPR07MB3053; x-forefront-prvs: 0504F29D72 received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b369129-60a3-48eb-e631-08d53558c610 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Nov 2017 05:36:13.8558 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3053 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP -----Original Message----- From: Colin King [mailto:colin.king@canonical.com] Sent: 24 November 2017 19:14 To: Gurumurthy, Anil ; Kalluru, Sudarsana ; James E . J . Bottomley ; Martin K . Petersen ; linux-scsi@vger.kernel.org Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org Subject: [PATCH] scsi: bfa: use setup_timer instead of init_timer From: Colin Ian King Use setup_timer function instead of initializing timer with the function and data fields. Signed-off-by: Colin Ian King --- drivers/scsi/bfa/bfad.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/scsi/bfa/bfad.c b/drivers/scsi/bfa/bfad.c index 5caf5f3ff642..c910b238bc9e 100644 --- a/drivers/scsi/bfa/bfad.c +++ b/drivers/scsi/bfa/bfad.c @@ -719,10 +719,7 @@ bfad_bfa_tmo(unsigned long data) void bfad_init_timer(struct bfad_s *bfad) { - init_timer(&bfad->hal_tmo); - bfad->hal_tmo.function = bfad_bfa_tmo; - bfad->hal_tmo.data = (unsigned long)bfad; - + setup_timer(&bfad->hal_tmo, bfad_bfa_tmo, (unsigned long)bfad); mod_timer(&bfad->hal_tmo, jiffies + msecs_to_jiffies(BFA_TIMER_FREQ)); } -- 2.14.1 Acked-by: Anil Gurumurthy