From patchwork Fri Jun 23 16:50:30 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Minwoo Im X-Patchwork-Id: 9806987 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 51D49600C5 for ; Fri, 23 Jun 2017 16:51:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 415AC28740 for ; Fri, 23 Jun 2017 16:51:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 362EA28797; Fri, 23 Jun 2017 16:51:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7EDFB28740 for ; Fri, 23 Jun 2017 16:51:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754019AbdFWQvN (ORCPT ); Fri, 23 Jun 2017 12:51:13 -0400 Received: from mail-yb0-f195.google.com ([209.85.213.195]:35557 "EHLO mail-yb0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753893AbdFWQvM (ORCPT ); Fri, 23 Jun 2017 12:51:12 -0400 Received: by mail-yb0-f195.google.com with SMTP id g206so2359621yba.2; Fri, 23 Jun 2017 09:51:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Lr+qjVkYian9oq24Z9zbPXhU05M1XZcMWs3boR8u7a8=; b=PtYSyBfN9hwfYEQp499lFsa83xLyHFA3yFByTK2Nfp+H4n8bvmyOEee1ByR9KjATPX aO9K5Vi0XHpBfFjGnuywzVQfPQMJhNdpytleBcFFChZJDiIeVAl510oKqVVFpLhldcaJ WC3XNXyGj14k9iAlgg/iDNEXaWnLfrpovznIe7V04h0Qap987kuyvOsQhEAkRXRVbdLQ f7RzdhxlwBSRJfIdGinEvH/5Eqr8wADN5p+EaOuyzYoC43hdpjhtVaCj/wz/CxxpTu0z +8FEtvI8UattVeqrS0H0wWsE+OTje14OATgS1mWk6l7QkKhPjsWcY575+tbv3LATdJdi XOXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Lr+qjVkYian9oq24Z9zbPXhU05M1XZcMWs3boR8u7a8=; b=ROA55HX0Qj21gvd9uP9wqzOWyzG8BY0fCSl6FNKSC5PxuJYbO5GJILH5oae0D2UKRA 0OT4v7vqGVWbhf5EkWwPjFboek2AFreF2/K3UGOXlxkmE8G26SoQqy9sCXJeLxqKwQkl 4pHD9luFQv3wGB7MMfMtVDUawXrPnM6k1VcMPzBB5GPdYqlzyvfOmrrATFgY1gpSF8xJ uVDuzm5sf0aX8iuvZdm7NC9l+lfeuGPJqdWThfEJjdTQIH9hA37IGnwWnph/YXgsG/Dj qrk8YWzV2YmRgUrbZ/lATn7F38SCe7tmtJgIFzXi/r4I31rPBGSi3Gec2O/HhmoVlBC2 tY7g== X-Gm-Message-State: AKS2vOxK8/FwGmqt/CN9n+IT81o/zjHsGOMpfn5JhRAtt0SaLHATEM3t 6O7SDjTiwyo/WDeQ8INw4VLvxLHrUw== X-Received: by 10.37.42.22 with SMTP id q22mr6361147ybq.20.1498236671126; Fri, 23 Jun 2017 09:51:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.129.89.67 with HTTP; Fri, 23 Jun 2017 09:50:30 -0700 (PDT) In-Reply-To: <1498071149.2746.26.camel@wdc.com> References: <1497697243-3724-1-git-send-email-dn3108@gmail.com> <1498071149.2746.26.camel@wdc.com> From: Minwoo Im Date: Sat, 24 Jun 2017 01:50:30 +0900 Message-ID: Subject: Re: [PATCH] scsi/libata: Support variable-length cdb of ata pass-thru(32). To: Bart Van Assche , "jejb@linux.vnet.ibm.com" , "tj@kernel.org" , "martin.petersen@oracle.com" Cc: "linux-scsi@vger.kernel.org" , "linux-ide@vger.kernel.org" Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Jun 22, 2017 at 3:52 AM, Bart Van Assche wrote: > On Sat, 2017-06-17 at 20:00 +0900, Minwoo Im wrote: >> - if ((tf->protocol = ata_scsi_map_proto(cdb[1])) == ATA_PROT_UNKNOWN) { >> + /* >> + * if SCSI operation code in cdb[0] is ATA_12 or ATA_16, >> + * then cdb[1] will contain protocol of ATA PASS-THROUGH. >> + * otherwise, Its operation code shall be ATA_32(7Fh). >> + * in this case, cdb[10] will contain protocol of it. >> + * we call this command as a variable-length cdb. >> + */ >> + if (cdb[0] == ATA_12 || cdb[0] == ATA_16) >> + tf->protocol = ata_scsi_map_proto(cdb[1]); >> + else >> + tf->protocol = ata_scsi_map_proto(cdb[10]); >> + >> + if (tf->protocol == ATA_PROT_UNKNOWN) { >> fp = 1; >> goto invalid_fld; >> } > > Hello Minwoo, > > Please consider introducing a variable (e.g. called "cdb_offset") in which the > value 9 is stored for 32-byte CDBs and 0 for 12-byte and 16-byte CDBs. That > will allow to rewrite the above code as follows: > > tf->protocol = ata_scsi_map_proto(cdb[1 + cdb_offset]) > > I think that will allow to remove most "if (cdb[0] == ATA_12 || cdb[0] == ATA_16)" > statements introduced by this patch. Hello Bart, I really appreciate that you gave me a simple way to handle 12, 16 and 32 bytes commands in a function above. I have applied those things to my patch. > >> + tf->auxiliary = (cdb[28] << 24) | (cdb[29] << 16) >> + | (cdb[30] << 8) | cdb[31]; > > Please use get_unaligned_be32() instead of open-coding it. > >> + const u16 sa = (cdb[8] >> 8) | cdb[9]; /* service action */ > > Please use get_unaligned_be16() instead of open-coding it. I have applied "get_unaligned_be16 and 32" function to those parts. Please refer a new patch below. Thanks, again. > >> @@ -4385,7 +4463,12 @@ int ata_scsi_add_hosts(struct ata_host *host, struct scsi_host_template *sht) >> shost->max_id = 16; >> shost->max_lun = 1; >> shost->max_channel = 1; >> - shost->max_cmd_len = 16; >> + /* >> + * SPC-3, SPC-4: Definition of CDB >> + * A CDB may have a fixed length of up to 16 bytes or >> + * variable length of between 12 and 260 bytes. >> + */ >> + shost->max_cmd_len = 260; > > Does ATA pass-through really support 260-byte CDBs or is the maximum CDB length > that is supported by ATA_32 perhaps 32 bytes? Here's my opinion about your question. In perspective of SCSI host, I guess the max cmd len should be 260 bytes. Because SPC says that, in case of variable-length command, it could be from 12 to 260 bytes. That's why I have applied 260 value to max_cmd_len of scsi host. Please feel free to give any opinions about it. > > Thanks, > > Bart. Thanks, Minwoo. Signed-off-by: Minwoo Im --- drivers/ata/libata-core.c | 2 +- drivers/ata/libata-scsi.c | 76 ++++++++++++++++++++++++++++++ ++++++++++++--- include/scsi/scsi_proto.h | 1 + 3 files changed, 73 insertions(+), 6 deletions(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 2d83b8c..4777e76 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -2587,7 +2587,7 @@ int ata_dev_configure(struct ata_device *dev) } ata_dev_config_sense_reporting(dev); ata_dev_config_zac(dev); - dev->cdb_len = 16; + dev->cdb_len = 32; } /* ATAPI-specific feature tests */ diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index 49ba983..d99c4e8 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -3127,7 +3127,7 @@ static struct ata_device *__ata_scsi_find_dev(struct ata_port *ap, * ata_scsi_pass_thru - convert ATA pass-thru CDB to taskfile * @qc: command structure to be initialized * - * Handles either 12 or 16-byte versions of the CDB. + * Handles either 12 16, or 32-byte versions of the CDB. * * RETURNS: * Zero on success, non-zero on failure. @@ -3139,13 +3139,19 @@ static unsigned int ata_scsi_pass_thru(struct ata_queued_cmd *qc) struct ata_device *dev = qc->dev; const u8 *cdb = scmd->cmnd; u16 fp; + u16 cdb_offset = 0; - if ((tf->protocol = ata_scsi_map_proto(cdb[1])) == ATA_PROT_UNKNOWN) { + /* 7Fh variable length cmd means a ata pass-thru(32) */ + if (cdb[0] == VARIABLE_LENGTH_CMD) + cdb_offset = 9; + + if ((tf->protocol = ata_scsi_map_proto(cdb[1 + cdb_offset])) + == ATA_PROT_UNKNOWN) { fp = 1; goto invalid_fld; } - if (ata_is_ncq(tf->protocol) && (cdb[2] & 0x3) == 0) + if (ata_is_ncq(tf->protocol) && (cdb[2 + cdb_offset] & 0x3) == 0) tf->protocol = ATA_PROT_NCQ_NODATA; /* enable LBA */ @@ -3181,7 +3187,7 @@ static unsigned int ata_scsi_pass_thru(struct ata_queued_cmd *qc) tf->lbah = cdb[12]; tf->device = cdb[13]; tf->command = cdb[14]; - } else { + } else if (cdb[0] == ATA_12) { /* * 12-byte CDB - incapable of extended commands. */ @@ -3194,6 +3200,30 @@ static unsigned int ata_scsi_pass_thru(struct ata_queued_cmd *qc) tf->lbah = cdb[7]; tf->device = cdb[8]; tf->command = cdb[9]; + } else { + /* + * 32-byte CDB - may contain extended command fields. + * + * If that is the case, copy the upper byte register values. + */ + if (cdb[10] & 0x01) { + tf->hob_feature = cdb[20]; + tf->hob_nsect = cdb[22]; + tf->hob_lbal = cdb[16]; + tf->hob_lbam = cdb[15]; + tf->hob_lbah = cdb[14]; + tf->flags |= ATA_TFLAG_LBA48; + } else + tf->flags &= ~ATA_TFLAG_LBA48; + + tf->feature = cdb[21]; + tf->nsect = cdb[23]; + tf->lbal = cdb[19]; + tf->lbam = cdb[18]; + tf->lbah = cdb[17]; + tf->device = cdb[24]; + tf->command = cdb[25]; + tf->auxiliary = get_unaligned_be32(&cdb[28]); } /* For NCQ commands copy the tag value */ @@ -4068,6 +4098,35 @@ static unsigned int ata_scsi_mode_select_xlat(struct ata_queued_cmd *qc) } /** + * ata_scsi_var_len_cdb_xlat - SATL variable length CDB to Handler + * @qc: Command to be translated + * + * Translate a SCSI variable length CDB to specified commands. + * It checks a service action value in CDB to call corresponding handler. + * + * RETURNS: + * Zero on success, non-zero on failure + * + */ +static unsigned int ata_scsi_var_len_cdb_xlat(struct ata_queued_cmd *qc) +{ + struct scsi_cmnd *scmd = qc->scsicmd; + const u8 *cdb = scmd->cmnd; + const u16 sa = get_unaligned_be16(&cdb[8]); + + /* + * if service action represents a ata pass-thru(32) command, + * then pass it to ata_scsi_pass_thru handler. + */ + if (sa == ATA_32) + return ata_scsi_pass_thru(qc); + +unspprt_sa: + /* unsupported service action */ + return 1; +} + +/** * ata_get_xlat_func - check if SCSI to ATA translation is possible * @dev: ATA device * @cmd: SCSI command opcode to consider @@ -4107,6 +4166,9 @@ static inline ata_xlat_func_t ata_get_xlat_func(struct ata_device *dev, u8 cmd) case ATA_16: return ata_scsi_pass_thru; + case VARIABLE_LENGTH_CMD: + return ata_scsi_var_len_cdb_xlat; + case MODE_SELECT: case MODE_SELECT_10: return ata_scsi_mode_select_xlat; @@ -4385,7 +4447,11 @@ int ata_scsi_add_hosts(struct ata_host *host, struct scsi_host_template *sht) shost->max_id = 16; shost->max_lun = 1; shost->max_channel = 1; - shost->max_cmd_len = 16; + /* + * SPC says that CDB may have a fixed length of up to 16 bytes + * or variable length of between 12 and 260 bytes. + */ + shost->max_cmd_len = 260; /* Schedule policy is determined by ->qc_defer() * callback and it needs to see every deferred qc. diff --git a/include/scsi/scsi_proto.h b/include/scsi/scsi_proto.h index ce78ec8..8545e34 100644 --- a/include/scsi/scsi_proto.h +++ b/include/scsi/scsi_proto.h @@ -164,6 +164,7 @@ #define WRITE_SAME_32 0x0d /* Values for T10/04-262r7 */ +#define ATA_32 0x1ff0 /* 32-byte pass-thru, service action */ #define ATA_16 0x85 /* 16-byte pass-thru */ #define ATA_12 0xa1 /* 12-byte pass-thru */