scsi:remove unreachable code on scsi_decide_disposition func

Commit Message

Wu Bo Dec. 17, 2019, 11:53 a.m. UTC

From: Wu Bo <[e-mail]>

Remove unreachable code on scsi_decide_disposition func.

Signed-off-by: Wu Bo <[e-mail]>
---
 drivers/scsi/scsi_error.c | 1 -
 1 file changed, 1 deletion(-)

--
1.8.3.1

Comments

Bart Van Assche Dec. 17, 2019, 3:05 p.m. UTC | #1

On 2019-12-17 03:53, wubo (T) wrote:
> From: Wu Bo <[e-mail]>
> 
> Remove unreachable code on scsi_decide_disposition func.
> 
> Signed-off-by: Wu Bo <[e-mail]>
> ---
>  drivers/scsi/scsi_error.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
> index ae2fa17..c5e05c4 100644
> --- a/drivers/scsi/scsi_error.c
> +++ b/drivers/scsi/scsi_error.c
> @@ -1934,7 +1934,6 @@ int scsi_decide_disposition(struct scsi_cmnd *scmd)
>         default:
>                 return FAILED;
>         }
> -       return FAILED;
> 
>  maybe_retry:

I'm not sure it's worth to address this issue. If
scsi_decide_disposition() is changed I prefer to remove the "default:
return FAILED;" code because compilers can provide more useful
diagnostics about switch/case statements that do not have a default
statement, especially if the "switch" applies to a value with
enumeration type.

Bart.

Patch

diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
index ae2fa17..c5e05c4 100644
--- a/drivers/scsi/scsi_error.c
+++ b/drivers/scsi/scsi_error.c
@@ -1934,7 +1934,6 @@  int scsi_decide_disposition(struct scsi_cmnd *scmd)
        default:
                return FAILED;
        }
-       return FAILED;

 maybe_retry: