| Message ID | SEYPR03MB6507111C9AF0BBE744EA7841A2B2A@SEYPR03MB6507.apcprd03.prod.outlook.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
| Series | drivers: fix typo in drivers/scsi/st.c | expand |
On 11/13/23 15:33, zilong zhang wrote: > Replace invisible character with a space. > The diff looks like this on my terminal: > > -^L Could those have been intentional form feeds for some code formatting or printing or editing tools? https://en.wikipedia.org/wiki/Page_break#Form_feed > + > > Signed-off-by: zilong zhang <NeoPerceval@outlook.com> > --- > drivers/scsi/st.c | 30 +++++++++++++++--------------- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c > index 338aa8c42968..19d86257036d 100644 > --- a/drivers/scsi/st.c > +++ b/drivers/scsi/st.c > @@ -230,7 +230,7 @@ static DEFINE_SPINLOCK(st_use_lock); > static DEFINE_IDR(st_index_idr); > > > - > + > #ifndef SIGS_FROM_OSST > #define SIGS_FROM_OSST \ > {"OnStream", "SC-", "", "osst"}, \ > @@ -308,7 +308,7 @@ static char * st_incompatible(struct scsi_device* SDp) > } > return NULL; > } > - > + > > #define st_printk(prefix, t, fmt, a...) \ > sdev_prefix_printk(prefix, (t)->device, (t)->name, fmt, ##a) > @@ -880,7 +880,7 @@ static int flush_buffer(struct scsi_tape *STp, int seek_next) > return result; > > } > - > + > /* Set the mode parameters */ > static int set_mode_densblk(struct scsi_tape * STp, struct st_modedef * STm) > { > @@ -955,7 +955,7 @@ static void reset_state(struct scsi_tape *STp) > STp->new_partition = STp->partition; > } > } > - > + > /* Test if the drive is ready. Returns either one of the codes below or a negative system > error code. */ > #define CHKRES_READY 0 > @@ -1244,7 +1244,7 @@ static int check_tape(struct scsi_tape *STp, struct file *filp) > } > > > - /* Open the device. Needs to take the BKL only because of incrementing the SCSI host > +/* Open the device. Needs to take the BKL only because of incrementing the SCSI host > module count. */ > static int st_open(struct inode *inode, struct file *filp) > { > @@ -1337,7 +1337,7 @@ static int st_open(struct inode *inode, struct file *filp) > return retval; > > } > - > + > > /* Flush the tape buffer before close */ > static int st_flush(struct file *filp, fl_owner_t id) > @@ -1891,7 +1891,7 @@ st_write(struct file *filp, const char __user *buf, size_t count, loff_t * ppos) > > return retval; > } > - > + > /* Read data from the tape. Returns zero in the normal case, one if the > eof status has changed, and the negative error code in case of a > fatal error. Otherwise updates the buffer and the eof state. > @@ -2090,7 +2090,7 @@ static long read_tape(struct scsi_tape *STp, long count, > } > return retval; > } > - > + > > /* Read command */ > static ssize_t > @@ -2238,7 +2238,7 @@ st_read(struct file *filp, char __user *buf, size_t count, loff_t * ppos) > > return retval; > } > - > + > > > DEB( > @@ -2452,7 +2452,7 @@ static int st_set_options(struct scsi_tape *STp, long options) > > return 0; > } > - > + > #define MODE_HEADER_LENGTH 4 > > /* Mode header and page byte offsets */ > @@ -2670,7 +2670,7 @@ static int do_load_unload(struct scsi_tape *STp, struct file *filp, int load_cod > > return retval; > } > - > + > #if DEBUG > #define ST_DEB_FORWARD 0 > #define ST_DEB_BACKWARD 1 > @@ -3096,7 +3096,7 @@ static int st_int_ioctl(struct scsi_tape *STp, unsigned int cmd_in, unsigned lon > > return ioctl_result; > } > - > + > > /* Get the tape position. If bt == 2, arg points into a kernel space mt_loc > structure. */ > @@ -3288,7 +3288,7 @@ static int switch_partition(struct scsi_tape *STp) > STps->last_block_visited = 0; > return set_location(STp, STps->last_block_visited, STp->new_partition, 1); > } > - > + > /* Functions for reading and writing the medium partition mode page. */ > > #define PART_PAGE 0x11 > @@ -3496,7 +3496,7 @@ static int partition_tape(struct scsi_tape *STp, int size) > out: > return result; > } > - > + > > > /* The ioctl command */ > @@ -3864,7 +3864,7 @@ static long st_compat_ioctl(struct file *file, unsigned int cmd_in, unsigned lon > } > #endif > > - > + > > /* Try to allocate a new tape buffer. Calling function must not hold > dev_arr_lock. */
On 11/13/23 06:33, zilong zhang wrote: > Replace invisible character with a space. > The diff looks like this on my terminal: > > -^L > + > > Signed-off-by: zilong zhang <NeoPerceval@outlook.com> > --- > drivers/scsi/st.c | 30 +++++++++++++++--------------- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c > index 338aa8c42968..19d86257036d 100644 > --- a/drivers/scsi/st.c > +++ b/drivers/scsi/st.c > @@ -230,7 +230,7 @@ static DEFINE_SPINLOCK(st_use_lock); > static DEFINE_IDR(st_index_idr); > > > - > + The patch subject is wrong. As Steffen pointed out, the form feeds are intentional. Additionally, the above changes do not follow the Linux kernel coding style. One blank line is sufficient to separate function definitions. Thanks, Bart.
diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c index 338aa8c42968..19d86257036d 100644 --- a/drivers/scsi/st.c +++ b/drivers/scsi/st.c @@ -230,7 +230,7 @@ static DEFINE_SPINLOCK(st_use_lock); static DEFINE_IDR(st_index_idr); - + #ifndef SIGS_FROM_OSST #define SIGS_FROM_OSST \ {"OnStream", "SC-", "", "osst"}, \ @@ -308,7 +308,7 @@ static char * st_incompatible(struct scsi_device* SDp) } return NULL; } - + #define st_printk(prefix, t, fmt, a...) \ sdev_prefix_printk(prefix, (t)->device, (t)->name, fmt, ##a) @@ -880,7 +880,7 @@ static int flush_buffer(struct scsi_tape *STp, int seek_next) return result; } - + /* Set the mode parameters */ static int set_mode_densblk(struct scsi_tape * STp, struct st_modedef * STm) { @@ -955,7 +955,7 @@ static void reset_state(struct scsi_tape *STp) STp->new_partition = STp->partition; } } - + /* Test if the drive is ready. Returns either one of the codes below or a negative system error code. */ #define CHKRES_READY 0 @@ -1244,7 +1244,7 @@ static int check_tape(struct scsi_tape *STp, struct file *filp) } - /* Open the device. Needs to take the BKL only because of incrementing the SCSI host +/* Open the device. Needs to take the BKL only because of incrementing the SCSI host module count. */ static int st_open(struct inode *inode, struct file *filp) { @@ -1337,7 +1337,7 @@ static int st_open(struct inode *inode, struct file *filp) return retval; } - + /* Flush the tape buffer before close */ static int st_flush(struct file *filp, fl_owner_t id) @@ -1891,7 +1891,7 @@ st_write(struct file *filp, const char __user *buf, size_t count, loff_t * ppos) return retval; } - + /* Read data from the tape. Returns zero in the normal case, one if the eof status has changed, and the negative error code in case of a fatal error. Otherwise updates the buffer and the eof state. @@ -2090,7 +2090,7 @@ static long read_tape(struct scsi_tape *STp, long count, } return retval; } - + /* Read command */ static ssize_t @@ -2238,7 +2238,7 @@ st_read(struct file *filp, char __user *buf, size_t count, loff_t * ppos) return retval; } - + DEB( @@ -2452,7 +2452,7 @@ static int st_set_options(struct scsi_tape *STp, long options) return 0; } - + #define MODE_HEADER_LENGTH 4 /* Mode header and page byte offsets */ @@ -2670,7 +2670,7 @@ static int do_load_unload(struct scsi_tape *STp, struct file *filp, int load_cod return retval; } - + #if DEBUG #define ST_DEB_FORWARD 0 #define ST_DEB_BACKWARD 1 @@ -3096,7 +3096,7 @@ static int st_int_ioctl(struct scsi_tape *STp, unsigned int cmd_in, unsigned lon return ioctl_result; } - + /* Get the tape position. If bt == 2, arg points into a kernel space mt_loc structure. */ @@ -3288,7 +3288,7 @@ static int switch_partition(struct scsi_tape *STp) STps->last_block_visited = 0; return set_location(STp, STps->last_block_visited, STp->new_partition, 1); } - + /* Functions for reading and writing the medium partition mode page. */ #define PART_PAGE 0x11 @@ -3496,7 +3496,7 @@ static int partition_tape(struct scsi_tape *STp, int size) out: return result; } - + /* The ioctl command */ @@ -3864,7 +3864,7 @@ static long st_compat_ioctl(struct file *file, unsigned int cmd_in, unsigned lon } #endif - + /* Try to allocate a new tape buffer. Calling function must not hold dev_arr_lock. */
Replace invisible character with a space. The diff looks like this on my terminal: -^L + Signed-off-by: zilong zhang <NeoPerceval@outlook.com> --- drivers/scsi/st.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-)