| Message ID | YKUeq6gwfGcvvhty@mwanda (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | scsi: libsas: use _safe() loop in sas_resume_port() | expand |
On 19/05/2021 15:20, Dan Carpenter wrote: > If sas_notify_lldd_dev_found() fails then this code calls: > > sas_unregister_dev(port, dev); > > which removes "dev", our list iterator, from the list. This could > lead to an endless loop. We need to use list_for_each_entry_safe(). > > Fixes: 303694eeee5e ("[SCSI] libsas: suspend / resume support") > Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com> Reviewed-by: John Garry <john.garry@huawei.com>
On Wed, 19 May 2021 17:20:27 +0300, Dan Carpenter wrote: > If sas_notify_lldd_dev_found() fails then this code calls: > > sas_unregister_dev(port, dev); > > which removes "dev", our list iterator, from the list. This could > lead to an endless loop. We need to use list_for_each_entry_safe(). Applied to 5.13/scsi-fixes, thanks! [1/1] scsi: libsas: use _safe() loop in sas_resume_port() https://git.kernel.org/mkp/scsi/c/8c7e7b8486cd
diff --git a/drivers/scsi/libsas/sas_port.c b/drivers/scsi/libsas/sas_port.c index 19cf418928fa..e3d03d744713 100644 --- a/drivers/scsi/libsas/sas_port.c +++ b/drivers/scsi/libsas/sas_port.c @@ -25,7 +25,7 @@ static bool phy_is_wideport_member(struct asd_sas_port *port, struct asd_sas_phy static void sas_resume_port(struct asd_sas_phy *phy) { - struct domain_device *dev; + struct domain_device *dev, *n; struct asd_sas_port *port = phy->port; struct sas_ha_struct *sas_ha = phy->ha; struct sas_internal *si = to_sas_internal(sas_ha->core.shost->transportt); @@ -44,7 +44,7 @@ static void sas_resume_port(struct asd_sas_phy *phy) * 1/ presume every device came back * 2/ force the next revalidation to check all expander phys */ - list_for_each_entry(dev, &port->dev_list, dev_list_node) { + list_for_each_entry_safe(dev, n, &port->dev_list, dev_list_node) { int i, rc; rc = sas_notify_lldd_dev_found(dev);
If sas_notify_lldd_dev_found() fails then this code calls: sas_unregister_dev(port, dev); which removes "dev", our list iterator, from the list. This could lead to an endless loop. We need to use list_for_each_entry_safe(). Fixes: 303694eeee5e ("[SCSI] libsas: suspend / resume support") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/scsi/libsas/sas_port.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)