diff mbox series

[v2] scsi: qla2xxx: scsi: qla2xxx: check correct variable in qla24xx_async_gffid()

Message ID YrK1A/t3L6HKnswO@kili (mailing list archive)
State Accepted
Headers show
Series [v2] scsi: qla2xxx: scsi: qla2xxx: check correct variable in qla24xx_async_gffid() | expand

Commit Message

Dan Carpenter June 22, 2022, 6:21 a.m. UTC 
There is a copy and paste bug here.  It should check ".rsp" instead of
".req".  The error message is copy and pasted as well so update that too.

Fixes: 9c40c36e75ff ("scsi: qla2xxx: edif: Reduce Initiator-Initiator thrashing")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: Update the error message as well

 drivers/scsi/qla2xxx/qla_gs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Martin K. Petersen July 7, 2022, 8:36 p.m. UTC | #1 
Dan,

> There is a copy and paste bug here.  It should check ".rsp" instead of
> ".req".  The error message is copy and pasted as well so update that
> too.

Applied to 5.20/scsi-staging, thanks!
Martin K. Petersen July 14, 2022, 4:22 a.m. UTC | #2 
On Wed, 22 Jun 2022 09:21:55 +0300, Dan Carpenter wrote:

> There is a copy and paste bug here.  It should check ".rsp" instead of
> ".req".  The error message is copy and pasted as well so update that too.
> 
> 

Applied to 5.20/scsi-queue, thanks!

[1/1] scsi: qla2xxx: scsi: qla2xxx: check correct variable in qla24xx_async_gffid()
      https://git.kernel.org/mkp/scsi/c/7c33e477bd88
diff mbox series

Patch

diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c
index 68fb91ef380a..dff06a3255d6 100644
--- a/drivers/scsi/qla2xxx/qla_gs.c
+++ b/drivers/scsi/qla2xxx/qla_gs.c
@@ -3389,9 +3389,9 @@  int qla24xx_async_gffid(scsi_qla_host_t *vha, fc_port_t *fcport, bool wait)
 				sp->u.iocb_cmd.u.ctarg.rsp_allocated_size,
 				&sp->u.iocb_cmd.u.ctarg.rsp_dma,
 	    GFP_KERNEL);
-	if (!sp->u.iocb_cmd.u.ctarg.req) {
+	if (!sp->u.iocb_cmd.u.ctarg.rsp) {
 		ql_log(ql_log_warn, vha, 0xd041,
-		       "%s: Failed to allocate ct_sns request.\n",
+		       "%s: Failed to allocate ct_sns response.\n",
 		       __func__);
 		goto done_free_sp;
 	}