diff mbox series

[2/2] scsi: mpi3mr: Fix error code in mpi3mr_transport_smp_handler()

Message ID YyMISJzVDARpVwrr@kili (mailing list archive)
State Accepted
Headers show
Series [1/2] scsi: mpi3mr: fix error codes in mpi3mr_report_manufacture() | expand

Commit Message

Dan Carpenter Sept. 15, 2022, 11:11 a.m. UTC
The error code from mpi3mr_post_transport_req() is supposed to be
passed to bsg_job_done(job, rc, reslen), but it isn't.

Fixes: 176d4aa69c6e ("scsi: mpi3mr: Support SAS transport class callbacks")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/scsi/mpi3mr/mpi3mr_transport.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Sathya Prakash Veerichetty Sept. 15, 2022, 5:31 p.m. UTC | #1
ACK. Thanks for fixing it.


On Thu, Sep 15, 2022 at 5:11 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> The error code from mpi3mr_post_transport_req() is supposed to be
> passed to bsg_job_done(job, rc, reslen), but it isn't.
>
> Fixes: 176d4aa69c6e ("scsi: mpi3mr: Support SAS transport class callbacks")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>  drivers/scsi/mpi3mr/mpi3mr_transport.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/mpi3mr/mpi3mr_transport.c b/drivers/scsi/mpi3mr/mpi3mr_transport.c
> index 74313cf68ad3..3fc897336b5e 100644
> --- a/drivers/scsi/mpi3mr/mpi3mr_transport.c
> +++ b/drivers/scsi/mpi3mr/mpi3mr_transport.c
> @@ -3245,8 +3245,10 @@ mpi3mr_transport_smp_handler(struct bsg_job *job, struct Scsi_Host *shost,
>
>         dprint_transport_info(mrioc, "sending SMP request\n");
>
> -       if (mpi3mr_post_transport_req(mrioc, &mpi_request, request_sz,
> -           &mpi_reply, reply_sz, MPI3MR_INTADMCMD_TIMEOUT, &ioc_status))
> +       rc = mpi3mr_post_transport_req(mrioc, &mpi_request, request_sz,
> +                                      &mpi_reply, reply_sz,
> +                                      MPI3MR_INTADMCMD_TIMEOUT, &ioc_status);
> +       if (rc)
>                 goto unmap_in;
>
>         dprint_transport_info(mrioc,
> --
> 2.35.1
>
diff mbox series

Patch

diff --git a/drivers/scsi/mpi3mr/mpi3mr_transport.c b/drivers/scsi/mpi3mr/mpi3mr_transport.c
index 74313cf68ad3..3fc897336b5e 100644
--- a/drivers/scsi/mpi3mr/mpi3mr_transport.c
+++ b/drivers/scsi/mpi3mr/mpi3mr_transport.c
@@ -3245,8 +3245,10 @@  mpi3mr_transport_smp_handler(struct bsg_job *job, struct Scsi_Host *shost,
 
 	dprint_transport_info(mrioc, "sending SMP request\n");
 
-	if (mpi3mr_post_transport_req(mrioc, &mpi_request, request_sz,
-	    &mpi_reply, reply_sz, MPI3MR_INTADMCMD_TIMEOUT, &ioc_status))
+	rc = mpi3mr_post_transport_req(mrioc, &mpi_request, request_sz,
+				       &mpi_reply, reply_sz,
+				       MPI3MR_INTADMCMD_TIMEOUT, &ioc_status);
+	if (rc)
 		goto unmap_in;
 
 	dprint_transport_info(mrioc,