| Message ID | ZGmGZxYmN0En7wAB@slm.duckdns.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [RESEND,01/13] scsi: ncr53c8xx: Use default @max_active for hostdata->work_q | expand |
On Sat, 20 May 2023, Tejun Heo wrote: > From: Tejun Heo <tj@kernel.org> > Subject: scsi: ncr53c8xx: Use default @max_active for hostdata->work_q > This driver is normally referred to as ncr5380 or NCR5380. (It doesn't support any other member of the 538x family.) > hostdata->work_q only hosts a single work item, hostdata->main_task, and > thus doesn't need explicit concurrency limit. Let's use the default > @max_active. This doesn't cost anything and clearly expresses that > @max_active doesn't matter. > > Signed-off-by: Tejun Heo <tj@kernel.org> Acked-by: Finn Thain <fthain@linux-m68k.org> > Cc: Finn Thain <fthain@linux-m68k.org> > Cc: Michael Schmitz <schmitzmic@gmail.com> > Cc: "James E.J. Bottomley" <jejb@linux.ibm.com> > Cc: "Martin K. Petersen" <martin.petersen@oracle.com> > Cc: linux-scsi@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > Hello, > > Resending because I screwed up the cc list in the original posting. The > whole series can be viewed at: > > http://lkml.kernel.org/r/20230509015032.3768622-1-tj@kernel.org > > It's not a must but it'd be great if I can route this through the > workqueue tree so that it can go together with other related and > followup cleanups. > > Thanks. > No objection from me. I guess it's Martin's call?
Hi Tejun! > Subject: scsi: ncr53c8xx: Use default @max_active for hostdata->work_q > > hostdata->work_q only hosts a single work item, hostdata->main_task, and > thus doesn't need explicit concurrency limit. Let's use the default > @max_active. This doesn't cost anything and clearly expresses that > @max_active doesn't matter. > It's not a must but it'd be great if I can route this through the workqueue > tree so that it can go together with other related and followup cleanups. As Finn pointed out, please make sure it's tagged NCR5380: instead of ncr53c8xx:. Otherwise OK. Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
On Mon, May 22, 2023 at 06:06:56PM -0400, Martin K. Petersen wrote: > > Hi Tejun! > > > Subject: scsi: ncr53c8xx: Use default @max_active for hostdata->work_q > > > > hostdata->work_q only hosts a single work item, hostdata->main_task, and > > thus doesn't need explicit concurrency limit. Let's use the default > > @max_active. This doesn't cost anything and clearly expresses that > > @max_active doesn't matter. > > > It's not a must but it'd be great if I can route this through the workqueue > > tree so that it can go together with other related and followup cleanups. > > As Finn pointed out, please make sure it's tagged NCR5380: instead of > ncr53c8xx:. Otherwise OK. > > Acked-by: Martin K. Petersen <martin.petersen@oracle.com> Will update and apply to wq/for-6.5-cleanup-ordered. Thank you.
--- a/drivers/scsi/NCR5380.c +++ b/drivers/scsi/NCR5380.c @@ -417,7 +417,7 @@ static int NCR5380_init(struct Scsi_Host INIT_WORK(&hostdata->main_task, NCR5380_main); hostdata->work_q = alloc_workqueue("ncr5380_%d", WQ_UNBOUND | WQ_MEM_RECLAIM, - 1, instance->host_no); + 0, instance->host_no); if (!hostdata->work_q) return -ENOMEM;