From patchwork Fri May 13 09:35:45 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaitra P B X-Patchwork-Id: 9089751 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 9C2D89F441 for ; Fri, 13 May 2016 09:35:54 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9626B20219 for ; Fri, 13 May 2016 09:35:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B36232021F for ; Fri, 13 May 2016 09:35:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751813AbcEMJft (ORCPT ); Fri, 13 May 2016 05:35:49 -0400 Received: from mail-qk0-f169.google.com ([209.85.220.169]:33556 "EHLO mail-qk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751242AbcEMJfr (ORCPT ); Fri, 13 May 2016 05:35:47 -0400 Received: by mail-qk0-f169.google.com with SMTP id n63so57393223qkf.0 for ; Fri, 13 May 2016 02:35:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:references:in-reply-to:mime-version:thread-index:date :message-id:subject:to:cc; bh=kvgkVrXBfiyOGFpSNwC41ded+cbyD2BggpL4YPlkbrU=; b=VK8EjD1BRR/VBnYmO60DeBymDQ4LLRRbS1nPImE6ow6DdDhdoURKq5DXeIPRuY3iBJ VdG5iQ10+X3ZJF5IduzA5G7jfd5ehfBtk5t1ilh71dtSU/RZWaNn9V/Kyyz+ycIt/Dsd bWFgCTqfcIfbn+W6TIik3JLdP/Sy1E5VmDKPw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:references:in-reply-to:mime-version :thread-index:date:message-id:subject:to:cc; bh=kvgkVrXBfiyOGFpSNwC41ded+cbyD2BggpL4YPlkbrU=; b=Qi/yWyj9VY9UTcf1/Wa1sjKAurToOUgV+NGWx72Sd9PdR26sbygo1xf2c+MxBK0eEk s71ZNZdu6SewYl++20z02A2Rhk39wyzZOtGN/d4DPEZmOE9NpTsEUE+nmHZ7Ab7Km6VV NBQ8Y8tqFf0hDKs+L5b4t9YBbYy6DHUzjRwOA9wjG/w/QXvp9gTknsHZUJEtvtf43iuy Px1AfB/ayy9stYr7nJXe07hioX07ptuBjfQ2rTwpF4lzP0d3PzrYDTxhNn7hE2hJc4MV CRIHHAV9qab340SUUop1wfXvOT/tW7MVMgeXi05tp7l2V+fm8P1nljubjeFwQmVGERgD z1wA== X-Gm-Message-State: AOPr4FVt/eFxeekPPZXhEgucvGmHdzIQ4XcrINUsfZxJNP6CIdk+tYIcWli57Pvvje2TmCxqEno4iyeL+9/B6Lmy X-Received: by 10.55.129.65 with SMTP id c62mr14703237qkd.171.1463132146616; Fri, 13 May 2016 02:35:46 -0700 (PDT) From: Chaitra Basappa References: <20160512203738.GB26894@mwanda> In-Reply-To: <20160512203738.GB26894@mwanda> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQIKbzudu56EKQb/S9UC9GJQc7yYsp9FFqbg Date: Fri, 13 May 2016 15:05:45 +0530 Message-ID: Subject: RE: [patch 1/2] mpt3sas: add missing curly braces To: Dan Carpenter , Sathya Prakash Veerichetty Cc: Suganath Prabu Subramani , "James E.J. Bottomley" , "Martin K. Petersen" , PDL-MPT-FUSIONLINUX , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, Please consider this patch as Ack-by: Chaitra P B Thanks, Chaitra -----Original Message----- From: Dan Carpenter [mailto:dan.carpenter@oracle.com] Sent: Friday, May 13, 2016 2:08 AM To: Sathya Prakash; Chaitra P B Cc: Suganath Prabu Subramani; James E.J. Bottomley; Martin K. Petersen; MPT-FusionLinux.pdl@broadcom.com; linux-scsi@vger.kernel.org; kernel-janitors@vger.kernel.org Subject: [patch 1/2] mpt3sas: add missing curly braces There are some missing curly braces on this if statement, so we end up printing when we shouldn't. Fixes: a470a51cd648 ('mpt3sas: Handle active cable exception event') Signed-off-by: Dan Carpenter pr_info("will not be seen. This active cable"); pr_info("requires %d mW of power", ActiveCableEventData->ActiveCablePowerRequirement); + } break; default: /* ignore the rest */ --- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c index 6a4df5a..6bff13e 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c @@ -7975,13 +7975,14 @@ mpt3sas_scsih_event_callback(struct MPT3SAS_ADAPTER *ioc, u8 msix_index, ActiveCableEventData = (Mpi26EventDataActiveCableExcept_t *) mpi_reply->EventData; if (ActiveCableEventData->ReasonCode == - MPI26_EVENT_ACTIVE_CABLE_INSUFFICIENT_POWER) + MPI26_EVENT_ACTIVE_CABLE_INSUFFICIENT_POWER) { pr_info(MPT3SAS_FMT "Currently an active cable with ReceptacleID %d", ioc->name, ActiveCableEventData->ReceptacleID); pr_info("cannot be powered and devices connected to this active cable");