| Message ID | ae9327e821e82a9c9e6a41c1fa12ec02496189f2.1528031458.git.rvarsha016@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Sun, 2018-06-03 at 18:52 +0530, Varsha Rao wrote: > Line over 80 characters is split to fix the following checkpatch issue: > > WARNING: line over 80 characters [] > diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c [] > @@ -5690,7 +5690,8 @@ mpt_inactive_raid_volumes(MPT_ADAPTER *ioc, u8 channel, u8 id) > buffer->PhysDisk[i].PhysDiskNum, &phys_disk) != 0) > continue; > > - if (!(component_info = kmalloc(sizeof(*component_info), GFP_KERNEL))) > + if (!(component_info = kmalloc(sizeof(*component_info), > + GFP_KERNEL))) > continue; It's much more common to split this into multiple statements like component_info = kmalloc(sizeof(*component_info), GFP_KERNEL); if (!component_info) continue; but the continue in a loop with a known alloc failure seems silly as the next alloc is also extremely likely to fail as well. btw: Are you actually using this code? If not, perhaps it's better to send cleanup only patches for files in drivers/staging as practice instead.
diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c index 2e5e5487f193..49e5d1ae9ea9 100644 --- a/drivers/message/fusion/mptbase.c +++ b/drivers/message/fusion/mptbase.c @@ -5690,7 +5690,8 @@ mpt_inactive_raid_volumes(MPT_ADAPTER *ioc, u8 channel, u8 id) buffer->PhysDisk[i].PhysDiskNum, &phys_disk) != 0) continue; - if (!(component_info = kmalloc(sizeof(*component_info), GFP_KERNEL))) + if (!(component_info = kmalloc(sizeof(*component_info), + GFP_KERNEL))) continue; component_info->volumeID = id;
Line over 80 characters is split to fix the following checkpatch issue: WARNING: line over 80 characters Signed-off-by: Varsha Rao <rvarsha016@gmail.com> --- drivers/message/fusion/mptbase.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)