diff mbox series

elx: efct: fix zalloc-simple.cocci warnings

Message ID alpine.DEB.2.21.2004121738150.2419@hadrien (mailing list archive)
State Superseded
Headers show
Series elx: efct: fix zalloc-simple.cocci warnings | expand

Commit Message

Julia Lawall April 12, 2020, 3:39 p.m. UTC 
Use zeroing allocator rather than allocator followed by memset with 0

Generated by: scripts/coccinelle/api/alloc/zalloc-simple.cocci

CC: James Smart <jsmart2021@gmail.com>
Signed-off-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

url:    https://github.com/0day-ci/linux/commits/James-Smart/efct-Broadcom-Emulex-FC-Target-driver/20200412-114125
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
:::::: branch date: 4 hours ago
:::::: commit date: 4 hours ago

 efct_lio.c |    9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
diff mbox series

Patch

--- a/drivers/scsi/elx/efct/efct_lio.c
+++ b/drivers/scsi/elx/efct/efct_lio.c
@@ -262,11 +262,10 @@  static int efct_debugfs_session_open(str
 		return EFC_SUCCESS;
 	}

-	filp->private_data = kmalloc(size, GFP_KERNEL);
+	filp->private_data = kzalloc(size, GFP_KERNEL);
 	if (!filp->private_data)
 		return -ENOMEM;

-	memset(filp->private_data, 0, size);
 	efct_lio_tgt_session_data(sport->efct, sport->wwpn, filp->private_data,
 				  size);
 	return EFC_SUCCESS;
@@ -300,11 +299,10 @@  static int efct_npiv_debugfs_session_ope
 		return EFC_SUCCESS;
 	}

-	filp->private_data = kmalloc(size, GFP_KERNEL);
+	filp->private_data = kzalloc(size, GFP_KERNEL);
 	if (!filp->private_data)
 		return -ENOMEM;

-	memset(filp->private_data, 0, size);
 	efct_lio_tgt_session_data(sport->efct, sport->npiv_wwpn,
 				  filp->private_data, size);
 	return EFC_SUCCESS;
@@ -1459,11 +1457,10 @@  int efct_scsi_del_initiator(struct efc *
 	if (reason == EFCT_SCSI_INITIATOR_MISSING)
 		return EFCT_SCSI_CALL_COMPLETE;

-	wq_data = kmalloc(sizeof(*wq_data), GFP_ATOMIC);
+	wq_data = kzalloc(sizeof(*wq_data), GFP_ATOMIC);
 	if (!wq_data)
 		return EFCT_SCSI_CALL_COMPLETE;

-	memset(wq_data, 0, sizeof(*wq_data));
 	wq_data->ptr = node;
 	wq_data->efct = efct;
 	INIT_WORK(&wq_data->work, efct_lio_remove_session);