From patchwork Wed Jul 20 11:36:38 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 9239471 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 30B8460574 for ; Wed, 20 Jul 2016 11:38:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 202D22026B for ; Wed, 20 Jul 2016 11:38:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 14B8D27BE5; Wed, 20 Jul 2016 11:38:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A972A2026B for ; Wed, 20 Jul 2016 11:38:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752845AbcGTLiC (ORCPT ); Wed, 20 Jul 2016 07:38:02 -0400 Received: from mout.web.de ([212.227.15.3]:57363 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752178AbcGTLh7 (ORCPT ); Wed, 20 Jul 2016 07:37:59 -0400 Received: from [192.168.1.2] ([77.181.180.179]) by smtp.web.de (mrweb001) with ESMTPSA (Nemesis) id 0MTxxp-1bpr7F1m6r-00Qh3O; Wed, 20 Jul 2016 13:36:44 +0200 Subject: [PATCH v2 3/3] xen-scsiback: Pass a failure indication as a constant To: xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org, =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , David Vrabel , Boris Ostrovsky References: <5307CAA2.8060406@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <59e51c7d-f7bb-c55f-d2fe-06dccfef6a99@users.sourceforge.net> <87e55a72-71ad-d0a1-b936-12565bbc6508@users.sourceforge.net> <8806e9cb-4200-8154-7914-6735805dfbe0@users.sourceforge.net> <83b0b1e2-900b-eefc-160b-7d837730571c@suse.com> <18256bfc-c6f9-8802-8d7d-55766f0b3624@users.sourceforge.net> <85b948e0-bf37-dff0-6792-77b5dacef9a0@suse.com> <6863b12b-9095-aaf3-6140-80968e0071e2@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: Date: Wed, 20 Jul 2016 13:36:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <6863b12b-9095-aaf3-6140-80968e0071e2@users.sourceforge.net> X-Provags-ID: V03:K0:tAusRi12CL5zEAGZsTr9Oy+GylF7F78k7N9L6SUoHUzjv8JUYOX 6X63qokaee/lLjrU/9oKL1fuH24QzsZ5bnZ08Gw4kForkbZIPc7jbhE7tPJ/+6cJ8JNm1fQ FPEMxPGsvFlXX7TNNs8+75cA8ByHSjvb/9m/v2LU1jbY60S3+43ZOxXHbqC38bCe0B3bfSA LzieAAwjNTgWp7EcY1GMg== X-UI-Out-Filterresults: notjunk:1; V01:K0:KYA5NrfTCqc=:NLJQolY3/VtGidLtaLOzp/ MZtmjodiH59HE/k5L615Jj6UoVssptzeAJKClLUZbJYRd1vJH3WO1DKxT7rHTC40lKmYBB2PT rCK8EjX9bI8dUyE1hBEeGTpsqvRmp+kxBfyGVokcwcWi44qgKtAeOgPyaHf6R6Z+GnaXMZhzs 34qelfBYQcsvoJZY6X6rbB4mL1eNXWMFm7+k0qiqMExVCqm8S78wCzZGWc30Ct7Mp2JqrkGmj gT/jX4kVSP2jfjV6Qu1w35TLNkYyLfy9FHCKlVxACG2OXtF8hVtwW+v76TC4oagIfi5ilGnX6 ZGWDRlGFSOQ4Z83a0aN5UmgJQS7wxJXCAVGS1jiF43hah3D896vvEvFBwewlgeRh9i/nL5tIA rbDMpLP5huWLkganzC2hhgUAhfX6djNpPK1Rmr492+9l9LQ15dG9k8AMoNU5FX23nW4IQGtlZ kuWQso+GArRFYISqXTLL2o4XEMRm0GaQ0SWqhsE2XmzgBdJi+yhbr5LEZX0kopr7hFjxwaVxh rt/fMHeyDFdrCmDZDUMJezm8Uf1UMNnCGbOoAGpu6eTYRfUZtoVye4CYsdhB6f6+D+4smiKQs DfaI2OcI8QCPcz89DPtfYpUeDFIAg8mVCUDxUOCwB/D2GvDJ53pUVD4tL8qF2IX0C88Frexfr JEcD4v0o0tTadimiltZJHRgp95IEjyai19P5ekiVu6vPld3fONL8AkR6tEGPMCVK+B7b7uKzi kmpo2LH6rtlqWqUs5CLTu0ouVxXj9X11Ma08KIF5bw8M5/awbtSt/tVgiZAFRAlE88lDr1tT1 wMOQGB2 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Wed, 20 Jul 2016 13:12:33 +0200 Pass the constant "FAILED" in a function call directly instead of using an intialisation for a local variable. Signed-off-by: Markus Elfring Reviewed-by: Juergen Gross --- v2: Rebased on source files from "Linux next-20160719" drivers/xen/xen-scsiback.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/xen/xen-scsiback.c b/drivers/xen/xen-scsiback.c index eb274df..fa08ec6 100644 --- a/drivers/xen/xen-scsiback.c +++ b/drivers/xen/xen-scsiback.c @@ -601,7 +601,7 @@ static void scsiback_device_action(struct vscsibk_pend *pending_req, struct se_cmd *se_cmd = &pending_req->se_cmd; struct scsiback_tmr *tmr; u64 unpacked_lun = pending_req->v2p->lun; - int rc, err = FAILED; + int rc, err; tmr = kzalloc(sizeof(struct scsiback_tmr), GFP_KERNEL); if (!tmr) @@ -628,7 +628,7 @@ put_cmd: target_put_sess_cmd(se_cmd); free_tmr: kfree(tmr); - scsiback_do_resp_with_sense(NULL, err, 0, pending_req); + scsiback_do_resp_with_sense(NULL, FAILED, 0, pending_req); } /*