From patchwork Wed Feb 28 09:34:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sreekanth Reddy X-Patchwork-Id: 10247055 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7A32860212 for ; Wed, 28 Feb 2018 09:35:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 641F828C87 for ; Wed, 28 Feb 2018 09:35:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5403F28C95; Wed, 28 Feb 2018 09:35:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C631B28C87 for ; Wed, 28 Feb 2018 09:35:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751836AbeB1JfA (ORCPT ); Wed, 28 Feb 2018 04:35:00 -0500 Received: from mail-pl0-f47.google.com ([209.85.160.47]:39487 "EHLO mail-pl0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751126AbeB1Je7 (ORCPT ); Wed, 28 Feb 2018 04:34:59 -0500 Received: by mail-pl0-f47.google.com with SMTP id s13-v6so1179521plq.6 for ; Wed, 28 Feb 2018 01:34:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:references:in-reply-to:mime-version:thread-index:date :message-id:subject:to:cc; bh=E7hrm/cxN1HzTI/9+BmwApUN+aA9NAMhZ7HOeoSCSi0=; b=U0vBdPLsIihY+HmDsxFMh3v0FX2/QOtXLZSsYmdoibg1LB43UFKphMNUw8IYk5vOA5 JqqgUMa/J4GeoPudsAC9hRXhOn+d++/q9ZaP7Vau2VI/5XyP1OE0ZV81I72rzsYJg9X+ Fv7WnKPZ5vK4OwuKPMibhBg3xdV4OY2awESvk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:references:in-reply-to:mime-version :thread-index:date:message-id:subject:to:cc; bh=E7hrm/cxN1HzTI/9+BmwApUN+aA9NAMhZ7HOeoSCSi0=; b=WMGGNyXPrmnpxqV1dKYJC7hQqEBAzlQ9DWqoAfdHqf9Gw62ojvaMyUMgrmhZgnh4FJ Ano4ki4Wzj47GwIo+zTYqAEI+P+f0i5ArHU+ku83IwcK+SkfPEba/wNneg2Iz062tLZP VrYB64usVJNAy6zQOlCw52pv2F+QB29wo+JQBm+m0PKOByiIDOokbJgMM6StMb7dKdYp IzbhSjHSIGMHzs5ABUheNT1q3wzdmEPZSJdY/KSfSpxh87EsnZKciT/SWcFhcVA8RCPF WRLbc0UmPRT751iFqluRO3tOPViOFpkyF8Z4lwhY/flXv/V27g4sBvKV3FTF7cpIBNyN Y3TQ== X-Gm-Message-State: APf1xPAcKTB1MQhk4+vIszputF4CDtyglVAFRj9m9yC61OYCNv7x6Bt1 1Q53oGeW3YEmleJj0ZMHx5u3jLpf6QfumFdtK++vjA== X-Google-Smtp-Source: AH8x226NtxuTQkOhrboz5SQzx/prHTUV9vptY6DGnBKEg96lVpricd3iDtT5sBx0BTDrdIcJwd2CcdpawbuELswiYjw= X-Received: by 2002:a17:902:33a5:: with SMTP id b34-v6mr17111031plc.263.1519810498269; Wed, 28 Feb 2018 01:34:58 -0800 (PST) From: Sreekanth Reddy References: <20180226142601.110639-1-hare@suse.de> In-Reply-To: <20180226142601.110639-1-hare@suse.de> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQHj4fO+UoI8TlI9W4A26kzr/XqSSqOZKojQ Date: Wed, 28 Feb 2018 15:04:57 +0530 Message-ID: Subject: RE: [PATCH] mpt3sas: Do not mark fw_event workqueue as WQ_MEM_RECLAIM To: Hannes Reinecke , "Martin K. Petersen" Cc: Christoph Hellwig , James Bottomley , linux-scsi@vger.kernel.org, Suganath Prabu Subramani , Hannes Reinecke Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP -----Original Message----- From: Hannes Reinecke [mailto:hare@suse.de] Sent: Monday, February 26, 2018 7:56 PM To: Martin K. Petersen Cc: Christoph Hellwig; James Bottomley; linux-scsi@vger.kernel.org; Hannes Reinecke; Sreekanth Reddy; Suganath Prabu Subramani; Hannes Reinecke Subject: [PATCH] mpt3sas: Do not mark fw_event workqueue as WQ_MEM_RECLAIM The firmware event workqueue should not be marked as WQ_MEM_RECLAIM as it's doesn't need to make forward progress under memory pressure. In the current state it will result in a deadlock if the device had been forcefully removed. Cc: Sreekanth Reddy Cc: Suganath Prabu Subramani Signed-off-by: Hannes Reinecke --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) pr_err(MPT3SAS_FMT "failure at %s:%d/%s()!\n", ioc->name, __FILE__, __LINE__, __func__); -- 2.12.3 Acked-by: Sreekanth Reddy Thanks, Sreekanth diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c index 74fca184dba9..b1d3218a7ad7 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c @@ -10547,7 +10547,7 @@ _scsih_probe(struct pci_dev *pdev, const struct pci_device_id *id) snprintf(ioc->firmware_event_name, sizeof(ioc->firmware_event_name), "fw_event_%s%d", ioc->driver_name, ioc->id); ioc->firmware_event_thread = alloc_ordered_workqueue( - ioc->firmware_event_name, WQ_MEM_RECLAIM); + ioc->firmware_event_name, 0); if (!ioc->firmware_event_thread) {