From patchwork Thu Jan 26 18:44:15 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Axboe X-Patchwork-Id: 9539947 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5DBBD601D7 for ; Thu, 26 Jan 2017 18:46:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 40C332823D for ; Thu, 26 Jan 2017 18:46:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 339B82824F; Thu, 26 Jan 2017 18:46:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9CB582823D for ; Thu, 26 Jan 2017 18:46:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752130AbdAZSqs (ORCPT ); Thu, 26 Jan 2017 13:46:48 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:60436 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752168AbdAZSq3 (ORCPT ); Thu, 26 Jan 2017 13:46:29 -0500 Received: from pps.filterd (m0109331.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v0QIhk87029768; Thu, 26 Jan 2017 10:44:21 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=subject : to : references : cc : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=facebook; bh=VH1ZRsndjS9SwcJWlVCQlkCiDsQZvdhPZ/nvGlVkVqE=; b=MvX+2fiwzkO+vn192LRuN8BENR5yX49n/THGl0zVSsrk4FacWhym4Nn2mSdM4f50XmjW 6LE4YIXQns7CnIE2B+2pUVyhleNCTnn3SsCICHuv2TFs3IlvPBGs/L/vG++dgLc0jG0Z /+M/vpCRs77nV0Ta3xGP1iSeOI+CNZykLCA= Received: from maileast.thefacebook.com ([199.201.65.23]) by mx0a-00082601.pphosted.com with ESMTP id 287d2uhnqs-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 26 Jan 2017 10:44:21 -0800 Received: from NAM03-DM3-obe.outbound.protection.outlook.com (192.168.183.28) by o365-in.thefacebook.com (192.168.177.28) with Microsoft SMTP Server (TLS) id 14.3.294.0; Thu, 26 Jan 2017 13:44:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.onmicrosoft.com; s=selector1-fb-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=VH1ZRsndjS9SwcJWlVCQlkCiDsQZvdhPZ/nvGlVkVqE=; b=bNB7LghWl+osFsuqnrZi0VNpWApND3i/CFH1c01oYXBoNiMac2jmcfzptsl0YbwwHY1O+KIzVomATqnnZDMhOg/3q8N59s9Z8CWODWscosKiggkxaXbtUgMROaCY9Yn2f4ftkAzJoSJJkvNhYIdHXsz5pn7A7llGtJC4bSDcqQU= Received: from [192.168.1.154] (216.160.245.98) by CY4PR15MB1192.namprd15.prod.outlook.com (10.172.177.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.860.13; Thu, 26 Jan 2017 18:44:17 +0000 Subject: Re: split scsi passthrough fields out of struct request V2 To: Bart Van Assche , "hch@lst.de" References: <1485365126-23210-1-git-send-email-hch@lst.de> <1485455329.2540.7.camel@sandisk.com> CC: "linux-scsi@vger.kernel.org" , "linux-raid@vger.kernel.org" , "dm-devel@redhat.com" , "linux-block@vger.kernel.org" , "snitzer@redhat.com" , "j-nomura@ce.jp.nec.com" From: Jens Axboe Message-ID: Date: Thu, 26 Jan 2017 11:44:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1485455329.2540.7.camel@sandisk.com> X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: DM3PR12CA0009.namprd12.prod.outlook.com (10.164.12.147) To CY4PR15MB1192.namprd15.prod.outlook.com (10.172.177.14) X-MS-Office365-Filtering-Correlation-Id: f9614761-3983-4f3e-e6b1-08d4461b55a1 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:CY4PR15MB1192; X-Microsoft-Exchange-Diagnostics: 1; CY4PR15MB1192; 3:/ymKoce6AE1x/LBrJ8pz+GESuHMY+nqlT1sJ940EoIRHqV85jDWCecDCP4ZxjgA6aawqnKaPSa8v9r830Gr6FNB6dvUDcDIrkrEA4RrRO6kXLqLa07JZHklGnHmK20ADUPM9cHWkAvETzain+D2TX/oYZtzdVdBctV9OhOVdqTHrJF8urhFAbI3Je4qA9Bw3q1e1pgwFeytW6Vd94y7Zk+IJL5N6vd1P+eLnqYvpmBOT1YxHky6Y2Rr0QgfKpcB1iGcw09619ue18HcUZfC9BA== X-Microsoft-Exchange-Diagnostics: 1; CY4PR15MB1192; 25:zybGw/XkGewLKc5sFFaEGg6DLslbF82E5PO6hcLl/rJ8se512toa+/PLyJp8aqXneYMaErZVs1lB2pXYqWIwcKYJLWQ8Di66PKo8nB2+h1IzQcUCcnX0YOoYjEWz5wTfHhpRvBoTmt9ijr6WxTSoHJK7fVAJwHK14fEyXQcJl2KYpXbSyt3SIRA+2Jqw4MepSa6iTx+XSZEPXmWjBBzE+5628wZnBfCKcDbkBi8xcGV0Jv5ZJwJf6CWOoySCA20M1d8rHVoKIH0vvtv7iUfLfhKxCL1p8/97eYIrENa4877jNfpAWPiSEDX3imeFF7kQmtLNZkDnEGe6wu775KNCOt6jkyRyVFq7g1fx7o0dNn+cQCY+Q/lsp71MU5xj+B/HM2AxxhA5XoJ2L0z4ra5KTvoW4PhEIOdofTbIutahk4MT+RRW7JBWkHHyfehu+axte/T3bajxmUGU/w5/p5cO+vUB+VGynEwnJ0oF+dx91mM3c/3VFf2zAcoYvsPqRgKPacKPzifsQox76cXRCbSuoRVYbPR7LDE8MZvb0EviizYRrhduf+JQi74HuON1riXAUhOHntTtlMA5VnN8y9Cp3E9j8jCFXou/BxfaH1RE3w3lpL1Wyxzk9L0d7IhTLlPa56Uqok4l1kj3kjiEb9Qn71RqcISx9traj9aWhTRpIIJl+IZHcHgn6URZR2nJsraZ X-Microsoft-Exchange-Diagnostics: 1; CY4PR15MB1192; 31:Cam5WtKuKa8pXoJXxPCBLQSXsyY5GkoVhOqQgLez2n3NfdMdRC8kB6ePpUvHn/0G+5pzhKpjO93FKhGpjOMBw6jfcZnL+vt4VYEWoTAwoXGGasfWqWK20+wbcAcuKkD9AnoXts6+shaaToEHB5htff7fl3GNiYLQulI1Wb3qqTtQd7/xTMzeSANwQkvft/ADcNLfcKE8H0+X/06XNfrhUXrBDmJlgRW2cziF0lN5eDyhKcXslTiXwCZIVB9YRJQlUY111PRAcl0MIuCGLBg/zA==; 20:/gN8SJFYZOPaxHsZyN7JLj8oS02NqxuUTA0iDu0+NK3QOczVLY4BitNzmkcI6SGDRcIX0C2Bu0MWn1R35rTQl4DhBA5SFReghvOwK60f2r3L0xXLQe38wzX1iuGhE9t/xiZYqVkQjuFQlcBUlQGL/kIDikNI+hj4gSMP4RJllUI/DApN72tV7jDO9R5V1tYe1YP/62pdtzzJiTDyVQ2Ezq3QAkEb/o25BEt6zHWfee4J/KhoVtdRZLARuWLF2mZ3pjueUtM/Pxe5y9Q5GRaAq60ve7NRTOsqVtQ9yirDtvYxj6DusGIr+iBUWFMWWBm18bhK0O4xGsqmr+Ux9jcxfGPUUC9FqtMAbYau/l1RvpnsBA6f1F80jcGQmBKUl3bfPqZXpCjqj2FvJqE2p/NN/f9xgTRyrY0JCveWErQM18kv7I9NwOuugfEdL6xx+GFAOu7sjWJscSvlxtqfWLKg2l0adalMldyYHiHUdBBQ9MuuXCw20dB/hZll8Ei3I0ZO X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123560025)(20161123562025)(20161123564025)(20161123555025)(6072148); SRVR:CY4PR15MB1192; BCL:0; PCL:0; RULEID:; SRVR:CY4PR15MB1192; X-Microsoft-Exchange-Diagnostics: 1; CY4PR15MB1192; 4:kfZTRHLF9ZnaXrk9Es7jWPwVrYTVVWzvQl5gnfmM8IRVvhxmQrLZh0JdInlh3VgcRDeYHQAwiFTEtZwtoYCakT6GLfp1TH/jufBF45O4V5b4wYQw2TKn+iZu4WYYom46qC2lOJgY8ss2ky4ygUCd3jzPLQOb2G0CdIj/YGamu5SVC5/Q2un86QW1qJ4NON6EerhGfMNlPB21dSiU7nr6HTFgFX6l1DePX1V0rSDEZQYl1PvtsoXjxiSLABbb2hjXgbK7A/wjlYPJ3QNsdSZ2N0VRPJhO4a56Qbzq/Uaru3xSOXf7p+dXpEbrMVb8LomZjstW9z7dqfWxfh2bgFgReGAXygXuPtZaCEsKaAAsqAt1WxIu2zAgHVGHt+C4y5cFdnt1nE+KTQ8yYoqZ9Vjf//jtvcY5rOY90pgds+VZQsxt1ARwTqjZjiiYmx7CbSJk/37jKKLPcx1iNnjQFq1WfzyrGwObQHEC1oZ+GnF4K2vmqAyUUqAY9dRHlXF70L6IdJelCaI9zDY99yd/92FImio/Xxl9oukPcqXXa4AZ/NsE1w99LH84U49X4fQUzKh+ X-Forefront-PRVS: 019919A9E4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(39450400003)(24454002)(199003)(189002)(377424004)(377454003)(53754006)(106356001)(54356999)(90366009)(81156014)(81166006)(25786008)(23746002)(38730400001)(54906002)(8656002)(76176999)(229853002)(50986999)(65826007)(33646002)(5660300001)(8676002)(31686004)(7736002)(4326007)(77096006)(64126003)(6486002)(42186005)(50466002)(305945005)(105586002)(53936002)(86362001)(2906002)(101416001)(2950100002)(65806001)(65956001)(230700001)(66066001)(117156001)(68736007)(2501003)(83506001)(3846002)(36756003)(6116002)(5001770100001)(31696002)(4001350100001)(47776003)(1691005)(97736004)(189998001)(92566002); DIR:OUT; SFP:1102; SCL:1; SRVR:CY4PR15MB1192; H:[192.168.1.154]; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: fb.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; CY4PR15MB1192; 23:DAhFD+wrucsfPaUauSt5fNy1Vi0Iu0TU6mLKx?= =?Windows-1252?Q?EsOBwf3w3DHI4NWYjdfROAiPT64eEAZs/oGxt4xf46nVr4bC40K3KVsG?= =?Windows-1252?Q?uAEikeLvkQo9hWx4HYAsgIhFmEKRzZ+hVe7jMyD5sWM/X/QrJDWYt2qv?= =?Windows-1252?Q?XX8zBNv4TIcqcmVRESpdIvkEBuC3owVTd+S3shNcj7S2uZreXDzK8xjL?= =?Windows-1252?Q?MqiUfPaNK06uYYRpMUV57y9z8b1JRY/p8DRw4bv6JQ5ohK395ADX5JPo?= =?Windows-1252?Q?z3IbPMhx1dWjU7e+MWmUeT2dlTtzYQDKYepoFySAMvxcswh8B6zFZzRW?= =?Windows-1252?Q?NQWiVLaQ6Vvvr+4giYTaRkdwzLPpqnywD1BVedbRxV4vK7BqUJBTXhyG?= =?Windows-1252?Q?34xAW3ArkWSdrZ+2S6O2UpHlEdDpFmrCcqKciR/+UY+Zrry7Pr6miBtW?= =?Windows-1252?Q?ZnsXAucsmVTb1YjzYIhficw7/l9e+zliVA0B8Gv1WM6JE+RzvKu+7/Tv?= =?Windows-1252?Q?nkd+srE28aCw9JZAx2a8Sd8iuXyr2z+1KsOTQfDsCRtByEQad9LDWSEd?= =?Windows-1252?Q?DTB4MHSgfiTM8RH1YMc8guDqf4YwYr6KDc3HDyDNYzkdDpdrO3n/EQq0?= =?Windows-1252?Q?AsBB6uU0O6mHw1bvyijsyqb/miWxvLN9Zhoz+ivdBIpJko8k5z29DFTO?= =?Windows-1252?Q?U3SS5PBK09KrIpgBL+948DQqCaDTrS0gbg8BV5yO3qar4XySxzJ8QeBb?= =?Windows-1252?Q?0Ol65tQ7IAI+QWmRV5yhP2qyBjFXWHaloV23Hn1lFT1H+d9q0cbjUN6D?= =?Windows-1252?Q?pew2ajaUMBu9ZDnS1CmKDZBLE82yRMWtpCPyYBCzkAmLOUoR4TJPG0b5?= =?Windows-1252?Q?/XiyXNq/25jVxP1+FFpQRjeGQykYckF677pNBJM0l2Rmkf+C/t3xwZBv?= =?Windows-1252?Q?12ujKjb4FRNMmTaOT5/JZeimc7jzUI6n9HlJcYzUHVqkEg+/uo3ugjQC?= =?Windows-1252?Q?aM0fIJJATTIie8TiPCWwIlEYg7g+7N/DBMiQWQz0MlEj6HkqiHWoAk96?= =?Windows-1252?Q?MkcuhzfMAq5TOObkc+tderBI/qCoX75MRlbTiYU+qXpGi4OI2ZmEH6lc?= =?Windows-1252?Q?lHFvbYzo3m02hQxDhuZ+5hH8e8c4wZswMRxv7G310tqEMl1AIAP45bzC?= =?Windows-1252?Q?tw/Uu++DjHBAgQCbTpYANesnZOxFUfRtSSNkGOoqofM2J8paw30kOyma?= =?Windows-1252?Q?cU2hovJdbiJI/cuU4NTtGd2SaNT6BGk6+KUAiPWNNGdaCgt832z1+zOl?= =?Windows-1252?Q?bwA14goFSB5TGruzSlslQOCbtpXL4bE7L4bP4uEatfyHx0xz2jHMTUco?= =?Windows-1252?Q?HEjdX72Dd99wUTgY8T7lbNXcT0CYc/C8NZ/ZSsqrOeJ+m0iOD3ZV7GR9?= =?Windows-1252?Q?SY+2GIsjLfZCwxGJfavXwjkN6Vf2QmH7I6uR0lo+N2eFqv7brRkOTZgw?= =?Windows-1252?Q?f5l1xRcxKN3G6HVk7HreRD+DHXX6haxTVt5uH5ZDctsQ+h+njqINxeKp?= =?Windows-1252?Q?oE4uslGLsN2Bt5pLMHkLj/jgRWmcRpE6XifKi9MCi6lSRcIHE370VWdT?= =?Windows-1252?B?UT09?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR15MB1192; 6:Ahq9ERmUkgAFpbqK8qVB4rMhdiRjMgH9SWTyE9fI2hShMGpyMVaqEOMSqPHfgwJuOGm6cmeOOXSm86zdn79+GSQQR9oAoJg6wCM9fNCBe4nFbMCGUHuDzfP1VS7/+ydLZpiWIvhOsJvnrLbUiMKnTiCIhqfn8cqoLy8IGIZEiBllWbSnant++uAIzoiqKQQBDSvSzMcPleDq+G7x2nvd3tJ6is9tcngljJfuEFjfesJtFTfuIk5D+gtbpjyaJfliN6bc8DeWd3Wx9xmtAMCY/ZkOfz1fXdPOOTPKw4ue4Rr1pqdzfiXdowjdyWPwZ0/qBeXws06zH75Tv281Ri1SXDFsHYneBRonx9OppvF3CFC3La3v5z3WYhfj4Dkm7vRyV55g6r/3uLPeZy1qfTmDN5HT90gHuApMqGTGQ4M2HgY=; 5:p5ucnliTDoU5ebGGnqEiVywC7qJScqA1sIVOg9zLzjRovGuMFaIKHhDM5y5YToV2KZAaV9YxIF7ZtvprfXvxCiRWjrWbiDs9Q2uKSRSscE3GXhrjvf47/s2GH+sAdEs+D7QYoD4KRDGXb0kE+4Syuw==; 24:fvoSPQmZLeQlYa+WPt0gXGZZcdxZdyVQE6QfkdPmA3gGraXFSU45HvIiKVMHhMT5kUnagJEPiyyDahnbAS+5If1vEtlWWwsn9f6zKBAMVxY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR15MB1192; 7:5B3pZOR1OaizWyuEEUrs84AfZYiVyEWRp0v58FU2xuLn7+vrrAAP81Vm1EKKbxPvbMDzzc66F7CoLWZXcvR8YVgNefo48mZl98cSvtp9aFpgX6z9zw2kRvtpiB2VInLGieIgiBzi1GhtBxv85nTkCOlKRhCo55ynK3tu5UJfH+JoRpPY9mChAhEbYuzgalK1h41NdW3P/Ox8wrnBn6JOl7Fk2ApRT/OzNGXT5RLHSPgE2/IVE+Dvefm0/VwGAHkTHLyBE2XakLuYP6m/tNyfl/2tEEDP9YUHjp7NkAzKvUIotutUQvzwGBAwA+L39Pihjycgjsum0AwOdwUKVIofTO7E2b0A2JpiU+w1o8feNGtX4mRhVxBjsXLPdo94CF33EnPio0WxWId1BkSGiEQ6uhNXdAlgmEPlFSFF+qsqGXX/G9j89AuARAzHqHQyJSzFxCVjJ4USvpV+IkOB+1hBKg==; 20:luOhzyjrXCPE8/cxe7OKc4dvzdcTh0EcU59dxO3Vq7bWi7IBJTLaueSOYFzU3Qzmh/rhqBhdXrHsogAG65Vn71HMy2oz6X8FyTqxMU2chzaB9Ac3fgeOcspiLAmB0fZ+/4CNUvC7uj7DaeWkAK/fAo5ah+PH1TjYo6SmzSHmSCo= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2017 18:44:17.4692 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1192 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-01-26_13:, , signatures=0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 01/26/2017 11:29 AM, Bart Van Assche wrote: > On Wed, 2017-01-25 at 18:25 +0100, Christoph Hellwig wrote: >> Hi all, >> >> this series splits the support for SCSI passthrough commands from the >> main struct request used all over the block layer into a separate >> scsi_request structure that drivers that want to support SCSI passthough >> need to embedded as the first thing into their request-private data, >> similar to how we handle NVMe passthrough commands. >> >> To support this I've added support for that the private data after >> request structure to the legacy request path instead, so that it can >> be treated the same way as the blk-mq path. Compare to the current >> scsi_cmnd allocator that actually is a major simplification. >> >> Changes since V1: >> - fix handling of a NULL sense pointer in __scsi_execute >> - clean up handling of the flush flags in the block layer and MD >> - additional small cleanup in dm-rq > > Hello Christoph, > > Thanks for having fixed the NULL pointer issue I had reported for v1. > However, if I try to run my srp-test testsuite on top of your > hch-block/block-pc-refactor branch (commit ID a07dc3521034) merged > with v4.10-rc5 the following appears on the console: I think this may be my bug - does the below help? diff --git a/block/blk-mq-sched.c b/block/blk-mq-sched.c index d05061f27bb1..56b92db944ae 100644 --- a/block/blk-mq-sched.c +++ b/block/blk-mq-sched.c @@ -117,7 +117,7 @@ struct request *blk_mq_sched_get_request(struct request_queue *q, ctx = blk_mq_get_ctx(q); hctx = blk_mq_map_queue(q, ctx->cpu); - blk_mq_set_alloc_data(data, q, 0, ctx, hctx); + blk_mq_set_alloc_data(data, q, data->flags, ctx, hctx); if (e) { data->flags |= BLK_MQ_REQ_INTERNAL; diff --git a/block/blk-mq.c b/block/blk-mq.c index dcb567642db7..9e4ed04f398c 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -253,7 +253,7 @@ EXPORT_SYMBOL_GPL(__blk_mq_alloc_request); struct request *blk_mq_alloc_request(struct request_queue *q, int rw, unsigned int flags) { - struct blk_mq_alloc_data alloc_data; + struct blk_mq_alloc_data alloc_data = { .flags = flags }; struct request *rq; int ret; @@ -1382,7 +1382,7 @@ static blk_qc_t blk_mq_make_request(struct request_queue *q, struct bio *bio) { const int is_sync = op_is_sync(bio->bi_opf); const int is_flush_fua = bio->bi_opf & (REQ_PREFLUSH | REQ_FUA); - struct blk_mq_alloc_data data; + struct blk_mq_alloc_data data = { 0, }; struct request *rq; unsigned int request_count = 0, srcu_idx; struct blk_plug *plug; @@ -1504,7 +1504,7 @@ static blk_qc_t blk_sq_make_request(struct request_queue *q, struct bio *bio) const int is_flush_fua = bio->bi_opf & (REQ_PREFLUSH | REQ_FUA); struct blk_plug *plug; unsigned int request_count = 0; - struct blk_mq_alloc_data data; + struct blk_mq_alloc_data data = { 0, }; struct request *rq; blk_qc_t cookie; unsigned int wb_acct;