diff mbox series

[v2,2/2] scsi: arcmsr: Confirm getting a free ccb is in spin_lock circle

Message ID f3ec374cada762149911ff35e92a68a15a7d0327.camel@areca.com.tw (mailing list archive)
State Accepted
Headers show
Series scsi: arcmsr: configure the default SCSI device command timeout value | expand

Commit Message

ching Huang Oct. 27, 2020, 3:39 a.m. UTC 
From: ching Huang <ching2048@areca.com.tw>

Confirm getting a free ccb is in spin_lock circle.

Signed-off-by: ching Huang <ching2048@areca.com.tw>
---
diff mbox series

Patch

diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
index 7cfae1d..127fe50 100644
--- a/drivers/scsi/arcmsr/arcmsr_hba.c
+++ b/drivers/scsi/arcmsr/arcmsr_hba.c
@@ -3162,10 +3162,12 @@  message_out:
 
 static struct CommandControlBlock *arcmsr_get_freeccb(struct AdapterControlBlock *acb)
 {
-	struct list_head *head = &acb->ccb_free_list;
+	struct list_head *head;
 	struct CommandControlBlock *ccb = NULL;
 	unsigned long flags;
+
 	spin_lock_irqsave(&acb->ccblist_lock, flags);
+	head = &acb->ccb_free_list;
 	if (!list_empty(head)) {
 		ccb = list_entry(head->next, struct CommandControlBlock, list);
 		list_del_init(&ccb->list);