mbox series

[0/4] keys: Miscellaneous fixes

Message ID 155016118572.8115.3243711127043478822.stgit@warthog.procyon.org.uk (mailing list archive)
Headers show
Series keys: Miscellaneous fixes | expand

Message

David Howells Feb. 14, 2019, 4:19 p.m. UTC
Hi James,

Here are some keyrings fixes.

 (1) Handle quotas better, allowing full quota to be reached.

 (2) Fix the creation of shortcuts in the assoc_array internal
     representation when the index key needs to be an exact multiple of the
     machine word size.

 (3) Fix a dependency loop between the request_key contruction record and
     the request_key authentication key.  The construction record isn't
     really necessary and can be dispensed with.

 (4) Set the timestamp on a new key rather than leaving it as 0.  This
     would ordinarily be fine - provided the system clock is never set to a
     time before 1970.

The patches can be found here tagged thusly:

	https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
	keys-fixes-20190214

and also on the following branch:

	https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=keys-fixes

David
---
David Howells (3):
      assoc_array: Fix shortcut creation
      keys: Fix dependency loop between construction record and auth key
      keys: Timestamp new keys

Eric Biggers (1):
      KEYS: allow reaching the keys quotas exactly


 fs/nfs/nfs4idmap.c                   |   31 ++++++++-------
 include/keys/request_key_auth-type.h |   36 +++++++++++++++++
 include/linux/key-type.h             |   22 +++-------
 lib/assoc_array.c                    |    8 ++--
 security/keys/internal.h             |   13 ------
 security/keys/key.c                  |    5 +-
 security/keys/keyctl.c               |    1 
 security/keys/process_keys.c         |    1 
 security/keys/request_key.c          |   72 ++++++++++++++--------------------
 security/keys/request_key_auth.c     |   16 ++++----
 10 files changed, 108 insertions(+), 97 deletions(-)
 create mode 100644 include/keys/request_key_auth-type.h

Comments

James Morris Feb. 14, 2019, 7:01 p.m. UTC | #1
On Thu, 14 Feb 2019, David Howells wrote:

> 
> Hi James,
> 
> Here are some keyrings fixes.

For which kernel, -rc or 5.1?
David Howells Feb. 15, 2019, 4:54 p.m. UTC | #2
James Morris <jmorris@namei.org> wrote:

> For which kernel, -rc or 5.1?

-rc, preferably, but I don't think any of them are particularly urgent, so if
you'd rather wait...

David