[v2,-next,00/15] sysctl: move sysctls from vm_table into its own files

Message

yukaixiong Sept. 3, 2024, 3:29 a.m. UTC

This patch series moves sysctls of vm_table in kernel/sysctl.c to
places where they actually belong, and do some related code clean-ups.
After this patch series, all sysctls in vm_table have been moved into its
own files, meanwhile, delete vm_table.

All the modifications of this patch series base on
linux-next(tags/next-20240902). To test this patch series, the code was
compiled with both the CONFIG_SYSCTL enabled and disabled on arm64 and
x86_64 architectures. After this patch series is applied, all files
under /proc/sys/vm can be read or written normally.

Changes in v2:
 - fix sysctl_max_map_count undeclared issue in mm/nommu.c for patch6
 - update changelog for patch7/12, suggested by Kees/Paul
 - fix patch8, sorry for wrong changes and forget to built with NOMMU
 - add reviewed-by from Kees except patch8 since patch8 is wrong in v1
 - add reviewed-by from Jan Kara, Christian Brauner in patch12

Kaixiong Yu (15):
  mm: vmstat: move sysctls to its own files
  mm: filemap: move sysctl to its own file
  mm: swap: move sysctl to its own file
  mm: vmscan: move vmscan sysctls to its own file
  mm: util: move sysctls into it own files
  mm: mmap: move sysctl into its own file
  security: min_addr: move sysctl into its own file
  mm: nommu: move sysctl to its own file
  fs: fs-writeback: move sysctl to its own file
  fs: drop_caches: move sysctl to its own file
  sunrpc: use vfs_pressure_ratio() helper
  fs: dcache: move the sysctl into its own file
  x86: vdso: move the sysctl into its own file
  sh: vdso: move the sysctl into its own file
  sysctl: remove unneeded include

 arch/sh/kernel/vsyscall/vsyscall.c |  14 ++
 arch/x86/entry/vdso/vdso32-setup.c |  16 ++-
 fs/dcache.c                        |  21 ++-
 fs/drop_caches.c                   |  23 ++-
 fs/fs-writeback.c                  |  28 ++--
 include/linux/dcache.h             |   7 +-
 include/linux/mm.h                 |  23 ---
 include/linux/mman.h               |   2 -
 include/linux/swap.h               |   9 --
 include/linux/vmstat.h             |  11 --
 include/linux/writeback.h          |   4 -
 kernel/sysctl.c                    | 221 -----------------------------
 mm/filemap.c                       |  18 ++-
 mm/internal.h                      |  10 ++
 mm/mmap.c                          |  54 +++++++
 mm/nommu.c                         |  15 +-
 mm/swap.c                          |  16 ++-
 mm/swap.h                          |   1 +
 mm/util.c                          |  67 +++++++--
 mm/vmscan.c                        |  23 +++
 mm/vmstat.c                        |  42 +++++-
 net/sunrpc/auth.c                  |   2 +-
 security/min_addr.c                |  11 ++
 23 files changed, 328 insertions(+), 310 deletions(-)

Comments

Joel Granados Sept. 3, 2024, 8:38 p.m. UTC | #1

On Tue, Sep 03, 2024 at 11:29:56AM +0800, Kaixiong Yu wrote:
> This patch series moves sysctls of vm_table in kernel/sysctl.c to
> places where they actually belong, and do some related code clean-ups.
> After this patch series, all sysctls in vm_table have been moved into its
> own files, meanwhile, delete vm_table.
> 
> All the modifications of this patch series base on
> linux-next(tags/next-20240902). To test this patch series, the code was
> compiled with both the CONFIG_SYSCTL enabled and disabled on arm64 and
> x86_64 architectures. After this patch series is applied, all files
> under /proc/sys/vm can be read or written normally.

This move make a lot of sense. The question with these multi-subsystem
patchsets is how do they go into mainline. For now I have added this to
sysctl-testing to see if it needs more work. I can push this through the
sysctl subsystem, but you need to get reviewed-by for all of the commits
in different subsystems. I'm also fine with this going in through some
other subsys if anyone wants to take it?

Best

yukaixiong Sept. 6, 2024, 2:35 a.m. UTC | #2

On 2024/9/4 4:38, Joel Granados wrote:
> On Tue, Sep 03, 2024 at 11:29:56AM +0800, Kaixiong Yu wrote:
>> This patch series moves sysctls of vm_table in kernel/sysctl.c to
>> places where they actually belong, and do some related code clean-ups.
>> After this patch series, all sysctls in vm_table have been moved into its
>> own files, meanwhile, delete vm_table.
>>
>> All the modifications of this patch series base on
>> linux-next(tags/next-20240902). To test this patch series, the code was
>> compiled with both the CONFIG_SYSCTL enabled and disabled on arm64 and
>> x86_64 architectures. After this patch series is applied, all files
>> under /proc/sys/vm can be read or written normally.
> This move make a lot of sense. The question with these multi-subsystem
> patchsets is how do they go into mainline. For now I have added this to
> sysctl-testing to see if it needs more work. I can push this through the
> sysctl subsystem, but you need to get reviewed-by for all of the commits
> in different subsystems. I'm also fine with this going in through some
> other subsys if anyone wants to take it?
>
> Best
>

Thx，Joel!:-)

Hello，everyone!

This patch series has been reviewed by Kees, Jan Kara, Christian 
Brauner, and acked
by Anna Schumaker, Paul Moore. As Joel said, this patch series need to 
get reviewed-by
for all of the commits in different subsystems. I would appreciate it if 
you could review
this patch series as soon as possible !:-)