mbox series

[0/2] security: Constify sysctl tables

Message ID 20250123-sysctl-kees-v1-0-533359e74d66@suse.com (mailing list archive)
Headers show
Series security: Constify sysctl tables | expand

Message

Ricardo B. Marliere Jan. 23, 2025, 7:33 p.m. UTC
Hello,

Please consider pulling these small cleanup patches. They simply add
"const" to a couple of ctl_table structs within your subsystem.

Thank you,
-	Ricardo.

Signed-off-by: Ricardo B. Marliere <rbm@suse.com>
---
Ricardo B. Marliere (2):
      yama: Make sysctl table const
      LoadPin: Make sysctl table const

 security/loadpin/loadpin.c | 2 +-
 security/yama/yama_lsm.c   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
---
base-commit: a9a5e0bdc5a77a7c662ad4be0ad661f0b0d5e99d
change-id: 20250123-sysctl-kees-d7c805ee39cf

Best regards,

Comments

Kees Cook Jan. 23, 2025, 11:21 p.m. UTC | #1
On Thu, Jan 23, 2025 at 04:33:33PM -0300, Ricardo B. Marliere wrote:
> Please consider pulling these small cleanup patches. They simply add
> "const" to a couple of ctl_table structs within your subsystem.

Paul, do you want to take these, or should I put them in my tree?

-Kees
Paul Moore Jan. 24, 2025, 1:02 a.m. UTC | #2
On Thu, Jan 23, 2025 at 6:21 PM Kees Cook <kees@kernel.org> wrote:
> On Thu, Jan 23, 2025 at 04:33:33PM -0300, Ricardo B. Marliere wrote:
> > Please consider pulling these small cleanup patches. They simply add
> > "const" to a couple of ctl_table structs within your subsystem.
>
> Paul, do you want to take these, or should I put them in my tree?

Since you maintain both Yama and LoadPin and these patches are fully
contained within those LSMs I kinda figured you would grab them for
their respective trees.  However, if you would prefer for me to take
them via the LSM tree I can do that, just let me know.

You can also feel free to add my review tag to both patches if you want.

Reviewed-by: Paul Moore <paul@paul-moore.com>