From patchwork Sat Jun 11 01:55:07 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ed Swierk X-Patchwork-Id: 9170919 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3C5C9607D9 for ; Sat, 11 Jun 2016 01:55:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2E93C27D07 for ; Sat, 11 Jun 2016 01:55:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 236DF28325; Sat, 11 Jun 2016 01:55:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8733C281FE for ; Sat, 11 Jun 2016 01:55:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752407AbcFKBzj (ORCPT ); Fri, 10 Jun 2016 21:55:39 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:34785 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751943AbcFKBzX (ORCPT ); Fri, 10 Jun 2016 21:55:23 -0400 Received: by mail-pa0-f42.google.com with SMTP id bz2so28501430pad.1 for ; Fri, 10 Jun 2016 18:55:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skyportsystems.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=j6fJxDqHMjQDD8YU0fyFIvKgICQ+9MS5K1AeLNpaAe0=; b=FCHuLbVfzKl3YSuYLEgZveoZXJ7ii6uS0qg1toQia6O0iXP0jhWJgKRwZLLQFFBBBA LT6QvNiW/RaXkepWH7YjsNV2nlpYE/zZVK2J+vNPEvbPvLvusCAhRvATrTYRGbswhxky iO+H2NInOieKSnpedwr8No1PniFlmxfhKbD9c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=j6fJxDqHMjQDD8YU0fyFIvKgICQ+9MS5K1AeLNpaAe0=; b=K48pjl0iUWDRLJpQDeDvG+8nt/Ee0ol86NlMpBt/JNebNtK9gMXaFf4DSYTjmJ8irN e967wxyJlsc6AQUIK1kkkx+8niIcRgGE93VgKsWsW3JTJ9R7Ex4HRJy1pOAwM6YVKH8Y /wa1uQF40eup2t+n+3QdSU5NKYu/L5nDRnG+IJIzjEtxNCMEDj1eaNrJS+Xzw5ogK8xl 186TqHDIeUaAHLxZFr3UJDhGJn6razdS9cavKi/ZaKzzZ2gzUTMMKrrLwpRUt8HYcC2O DYcmUEyrTLDEEORjZEPsT7YVu5Ji/9exq6C3INRaKaS6G7jfF0cC+RW+n5usgRz8PhKP 5U/Q== X-Gm-Message-State: ALyK8tJQnB7l2MYO7jtrnxAZDOvSJab2DpZRyct2tx/GNtEAbyaokc/vbpiKCr0cwPfw9w1n X-Received: by 10.66.167.6 with SMTP id zk6mr5661537pab.146.1465610122194; Fri, 10 Jun 2016 18:55:22 -0700 (PDT) Received: from eswierk-sc.localdomain (67-207-112-138.static.wiline.com. [67.207.112.138]) by smtp.gmail.com with ESMTPSA id i89sm335594pfi.22.2016.06.10.18.55.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 10 Jun 2016 18:55:21 -0700 (PDT) From: Ed Swierk To: tpmdd-devel@lists.sourceforge.net Cc: eswierk@skyportsystems.com, stefanb@us.ibm.com, jarkko.sakkinen@linux.intel.com, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, jgunthorpe@obsidianresearch.com Subject: [PATCH v6 5/5] tpm_tis: Increase ST19NP18 TPM command duration to avoid chip lockup Date: Fri, 10 Jun 2016 18:55:07 -0700 Message-Id: <1465610107-87762-6-git-send-email-eswierk@skyportsystems.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1465610107-87762-1-git-send-email-eswierk@skyportsystems.com> References: <1465426818-89356-1-git-send-email-eswierk@skyportsystems.com> <1465610107-87762-1-git-send-email-eswierk@skyportsystems.com> Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: X-Virus-Scanned: ClamAV using ClamSMTP The STMicro ST19NP18-TPM sometimes takes much longer to execute commands than it reports in its capabilities. For example, command 186 (TPM_FlushSpecific) has been observed to take 14560 msec to complete, far longer than the 3000 msec limit for "short" commands reported by the chip. The behavior has also been seen with command 101 (TPM_GetCapability). Worse, when the tpm_tis driver attempts to cancel the current command (by writing commandReady = 1 to TPM_STS_x), the chip locks up completely, returning all-1s from all memory-mapped register reads. The lockup can be cleared only by resetting the system. The occurrence of this excessive command duration depends on the sequence of commands preceding it. One sequence is creating at least 2 new keys via TPM_CreateWrapKey, then letting the TPM idle for at least 30 seconds, then loading a key via TPM_LoadKey2. The next TPM_FlushSpecific occasionally takes tens of seconds to complete. Another sequence is creating many keys in a row without pause. The TPM_CreateWrapKey operation gets much slower after the first few iterations, as one would expect when the pool of precomputed keys is exhausted. Then after a 35-second pause, the same TPM_LoadKey2 followed by TPM_FlushSpecific sequence triggers the behavior. Our working theory is that this older TPM sometimes pauses to precompute keys, which modern chips implement as a background process. Without access to the chip's implementation details it's impossible to know whether any commands are immune to being blocked by this process. So it seems safest to ignore the chip's reported command durations, and use a value much higher than any observed duration, like 180 sec (which is the duration this chip reports for "long" commands). Signed-off-by: Ed Swierk --- drivers/char/tpm/tpm_tis.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c index caf7278..862c502 100644 --- a/drivers/char/tpm/tpm_tis.c +++ b/drivers/char/tpm/tpm_tis.c @@ -485,6 +485,11 @@ static void tpm_tis_update_timeouts(struct tpm_chip *chip) chip->vendor.timeout_d = msecs_to_jiffies(TIS_SHORT_TIMEOUT); chip->vendor.timeout_adjusted = true; break; + case 0x0000104a: /* STMicro ST19NP18-TPM */ + chip->vendor.duration[TPM_SHORT] = 180 * HZ; + chip->vendor.duration[TPM_MEDIUM] = 180 * HZ; + chip->vendor.duration[TPM_LONG] = 180 * HZ; + chip->vendor.duration_adjusted = true; } }