| Message ID | 1512157876-24665-15-git-send-email-paulmck@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, 1 Dec 2017, Paul E. McKenney wrote: > Now that the associative-array library properly heads dependency chains, > the various smp_read_barrier_depends() calls in security/keys/keyring.c > are no longer needed. This commit therefore removes them. > > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> > Cc: David Howells <dhowells@redhat.com> > Cc: James Morris <james.l.morris@oracle.com> > Cc: "Serge E. Hallyn" <serge@hallyn.com> > Cc: <keyrings@vger.kernel.org> > Cc: <linux-security-module@vger.kernel.org> Reviewed-by: James Morris <james.l.morris@oracle.com>
On Mon, Dec 04, 2017 at 11:59:22AM +1100, James Morris wrote: > On Fri, 1 Dec 2017, Paul E. McKenney wrote: > > > Now that the associative-array library properly heads dependency chains, > > the various smp_read_barrier_depends() calls in security/keys/keyring.c > > are no longer needed. This commit therefore removes them. > > > > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> > > Cc: David Howells <dhowells@redhat.com> > > Cc: James Morris <james.l.morris@oracle.com> > > Cc: "Serge E. Hallyn" <serge@hallyn.com> > > Cc: <keyrings@vger.kernel.org> > > Cc: <linux-security-module@vger.kernel.org> > > Reviewed-by: James Morris <james.l.morris@oracle.com> Applied, thank you for the review! Thanx, Paul -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/security/keys/keyring.c b/security/keys/keyring.c index d0bccebbd3b5..41bcf57e96f2 100644 --- a/security/keys/keyring.c +++ b/security/keys/keyring.c @@ -713,7 +713,6 @@ static bool search_nested_keyrings(struct key *keyring, * doesn't contain any keyring pointers. */ shortcut = assoc_array_ptr_to_shortcut(ptr); - smp_read_barrier_depends(); if ((shortcut->index_key[0] & ASSOC_ARRAY_FAN_MASK) != 0) goto not_this_keyring; @@ -723,8 +722,6 @@ static bool search_nested_keyrings(struct key *keyring, } node = assoc_array_ptr_to_node(ptr); - smp_read_barrier_depends(); - ptr = node->slots[0]; if (!assoc_array_ptr_is_meta(ptr)) goto begin_node; @@ -736,7 +733,6 @@ static bool search_nested_keyrings(struct key *keyring, kdebug("descend"); if (assoc_array_ptr_is_shortcut(ptr)) { shortcut = assoc_array_ptr_to_shortcut(ptr); - smp_read_barrier_depends(); ptr = READ_ONCE(shortcut->next_node); BUG_ON(!assoc_array_ptr_is_node(ptr)); } @@ -744,7 +740,6 @@ static bool search_nested_keyrings(struct key *keyring, begin_node: kdebug("begin_node"); - smp_read_barrier_depends(); slot = 0; ascend_to_node: /* Go through the slots in a node */ @@ -792,14 +787,12 @@ static bool search_nested_keyrings(struct key *keyring, if (ptr && assoc_array_ptr_is_shortcut(ptr)) { shortcut = assoc_array_ptr_to_shortcut(ptr); - smp_read_barrier_depends(); ptr = READ_ONCE(shortcut->back_pointer); slot = shortcut->parent_slot; } if (!ptr) goto not_this_keyring; node = assoc_array_ptr_to_node(ptr); - smp_read_barrier_depends(); slot++; /* If we've ascended to the root (zero backpointer), we must have just
Now that the associative-array library properly heads dependency chains, the various smp_read_barrier_depends() calls in security/keys/keyring.c are no longer needed. This commit therefore removes them. Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Cc: David Howells <dhowells@redhat.com> Cc: James Morris <james.l.morris@oracle.com> Cc: "Serge E. Hallyn" <serge@hallyn.com> Cc: <keyrings@vger.kernel.org> Cc: <linux-security-module@vger.kernel.org> --- security/keys/keyring.c | 7 ------- 1 file changed, 7 deletions(-)