diff mbox series

[2/2] tomoyo: Fixed typo in documentation

Message ID 1604737451-19082-2-git-send-email-jrdr.linux@gmail.com (mailing list archive)
State New
Headers show
Series [1/2] tomoyo: Convert get_user_pages*() to pin_user_pages*() | expand

Commit Message

Souptick Joarder Nov. 7, 2020, 8:24 a.m. UTC
Fixed typo s/Poiner/Pointer

Fixes: 5b636857fee6 ("TOMOYO: Allow using argv[]/envp[] of execve() as conditions.")
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Cc: John Hubbard <jhubbard@nvidia.com>
---
 security/tomoyo/domain.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

John Hubbard Nov. 7, 2020, 8:57 a.m. UTC | #1
On 11/7/20 12:24 AM, Souptick Joarder wrote:
> Fixed typo s/Poiner/Pointer
> 
> Fixes: 5b636857fee6 ("TOMOYO: Allow using argv[]/envp[] of execve() as conditions.")
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> Cc: John Hubbard <jhubbard@nvidia.com>
> ---
>   security/tomoyo/domain.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/security/tomoyo/domain.c b/security/tomoyo/domain.c
> index bd748be..7b2babe 100644
> --- a/security/tomoyo/domain.c
> +++ b/security/tomoyo/domain.c
> @@ -891,7 +891,7 @@ int tomoyo_find_next_domain(struct linux_binprm *bprm)
>    *
>    * @bprm: Pointer to "struct linux_binprm".
>    * @pos:  Location to dump.
> - * @dump: Poiner to "struct tomoyo_page_dump".
> + * @dump: Pointer to "struct tomoyo_page_dump".

Not worth a separate patch, especially since the original comment is merely
copying the C sources, and as such, does not add any value.

I'd either a) craft a new documentation line that adds some value, or b) just
merge this patch into the previous one, and make a note in the commit
description to the effect that you've included a trivial typo fix as long
as you're there.


thanks,
Souptick Joarder Nov. 9, 2020, 3:41 a.m. UTC | #2
On Sat, Nov 7, 2020 at 2:27 PM John Hubbard <jhubbard@nvidia.com> wrote:
>
> On 11/7/20 12:24 AM, Souptick Joarder wrote:
> > Fixed typo s/Poiner/Pointer
> >
> > Fixes: 5b636857fee6 ("TOMOYO: Allow using argv[]/envp[] of execve() as conditions.")
> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> > Cc: John Hubbard <jhubbard@nvidia.com>
> > ---
> >   security/tomoyo/domain.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/security/tomoyo/domain.c b/security/tomoyo/domain.c
> > index bd748be..7b2babe 100644
> > --- a/security/tomoyo/domain.c
> > +++ b/security/tomoyo/domain.c
> > @@ -891,7 +891,7 @@ int tomoyo_find_next_domain(struct linux_binprm *bprm)
> >    *
> >    * @bprm: Pointer to "struct linux_binprm".
> >    * @pos:  Location to dump.
> > - * @dump: Poiner to "struct tomoyo_page_dump".
> > + * @dump: Pointer to "struct tomoyo_page_dump".
>
> Not worth a separate patch, especially since the original comment is merely
> copying the C sources, and as such, does not add any value.
>
> I'd either a) craft a new documentation line that adds some value, or b) just
> merge this patch into the previous one, and make a note in the commit
> description to the effect that you've included a trivial typo fix as long
> as you're there.
>

John, as patch[1/2] is dropped, can we take this patch forward with some more
updates in documentations ?
John Hubbard Nov. 9, 2020, 4:17 a.m. UTC | #3
On 11/8/20 7:41 PM, Souptick Joarder wrote:
> On Sat, Nov 7, 2020 at 2:27 PM John Hubbard <jhubbard@nvidia.com> wrote:
>>
>> On 11/7/20 12:24 AM, Souptick Joarder wrote:
>>> Fixed typo s/Poiner/Pointer
>>>
>>> Fixes: 5b636857fee6 ("TOMOYO: Allow using argv[]/envp[] of execve() as conditions.")
>>> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>>> Cc: John Hubbard <jhubbard@nvidia.com>
>>> ---
>>>    security/tomoyo/domain.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/security/tomoyo/domain.c b/security/tomoyo/domain.c
>>> index bd748be..7b2babe 100644
>>> --- a/security/tomoyo/domain.c
>>> +++ b/security/tomoyo/domain.c
>>> @@ -891,7 +891,7 @@ int tomoyo_find_next_domain(struct linux_binprm *bprm)
>>>     *
>>>     * @bprm: Pointer to "struct linux_binprm".
>>>     * @pos:  Location to dump.
>>> - * @dump: Poiner to "struct tomoyo_page_dump".
>>> + * @dump: Pointer to "struct tomoyo_page_dump".
>>
>> Not worth a separate patch, especially since the original comment is merely
>> copying the C sources, and as such, does not add any value.
>>
>> I'd either a) craft a new documentation line that adds some value, or b) just
>> merge this patch into the previous one, and make a note in the commit
>> description to the effect that you've included a trivial typo fix as long
>> as you're there.
>>
> 
> John, as patch[1/2] is dropped, can we take this patch forward with some more
> updates in documentations ?
> 

That's really up to the folks who work on this code. Personally I would rarely
post a patch *just* for this, but on the other hand it is a correction. Either
way is fine with me of course.


thanks,
Tetsuo Handa Nov. 9, 2020, 4:45 a.m. UTC | #4
On 2020/11/09 13:17, John Hubbard wrote:
> On 11/8/20 7:41 PM, Souptick Joarder wrote:
>> John, as patch[1/2] is dropped, can we take this patch forward with some more
>> updates in documentations ?
>>
> 
> That's really up to the folks who work on this code. Personally I would rarely
> post a patch *just* for this, but on the other hand it is a correction. Either
> way is fine with me of course.

Xiaoming Ni has posted a patch for fixing spelling errors in security/ directory
at https://lkml.kernel.org/r/20200822030534.2577-1-nixiaoming@huawei.com .

James, can we apply that patch? Or, should we split that patch into each subsystem?
James Morris Nov. 10, 2020, 3:08 a.m. UTC | #5
On Mon, 9 Nov 2020, Tetsuo Handa wrote:

> On 2020/11/09 13:17, John Hubbard wrote:
> > On 11/8/20 7:41 PM, Souptick Joarder wrote:
> >> John, as patch[1/2] is dropped, can we take this patch forward with some more
> >> updates in documentations ?
> >>
> > 
> > That's really up to the folks who work on this code. Personally I would rarely
> > post a patch *just* for this, but on the other hand it is a correction. Either
> > way is fine with me of course.
> 
> Xiaoming Ni has posted a patch for fixing spelling errors in security/ directory
> at https://lkml.kernel.org/r/20200822030534.2577-1-nixiaoming@huawei.com .
> 
> James, can we apply that patch? Or, should we split that patch into each subsystem?
> 

Probably easiest to go via my tree, the author should resend and include 
me on the To: line.
diff mbox series

Patch

diff --git a/security/tomoyo/domain.c b/security/tomoyo/domain.c
index bd748be..7b2babe 100644
--- a/security/tomoyo/domain.c
+++ b/security/tomoyo/domain.c
@@ -891,7 +891,7 @@  int tomoyo_find_next_domain(struct linux_binprm *bprm)
  *
  * @bprm: Pointer to "struct linux_binprm".
  * @pos:  Location to dump.
- * @dump: Poiner to "struct tomoyo_page_dump".
+ * @dump: Pointer to "struct tomoyo_page_dump".
  *
  * Returns true on success, false otherwise.
  */