From patchwork Tue Aug 23 15:34:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thiago Jung Bauermann X-Patchwork-Id: 9295875 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 41D54607D0 for ; Tue, 23 Aug 2016 15:35:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 31C1D28CAC for ; Tue, 23 Aug 2016 15:35:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2641028CBD; Tue, 23 Aug 2016 15:35:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A80E328CAC for ; Tue, 23 Aug 2016 15:35:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752212AbcHWPfM (ORCPT ); Tue, 23 Aug 2016 11:35:12 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:53213 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751284AbcHWPfK (ORCPT ); Tue, 23 Aug 2016 11:35:10 -0400 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u7NFSlCK103564 for ; Tue, 23 Aug 2016 11:35:09 -0400 Received: from e24smtp05.br.ibm.com (e24smtp05.br.ibm.com [32.104.18.26]) by mx0b-001b2d01.pphosted.com with ESMTP id 250efh8rdu-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 23 Aug 2016 11:35:09 -0400 Received: from localhost by e24smtp05.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 23 Aug 2016 12:35:07 -0300 Received: from d24dlp02.br.ibm.com (9.18.248.206) by e24smtp05.br.ibm.com (10.172.0.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 23 Aug 2016 12:35:05 -0300 X-IBM-Helo: d24dlp02.br.ibm.com X-IBM-MailFrom: bauerman@linux.vnet.ibm.com X-IBM-RcptTo: linux-security-module@vger.kernel.org Received: from d24relay01.br.ibm.com (d24relay01.br.ibm.com [9.8.31.16]) by d24dlp02.br.ibm.com (Postfix) with ESMTP id 153991DC0051 for ; Tue, 23 Aug 2016 11:34:55 -0400 (EDT) Received: from d24av05.br.ibm.com (d24av05.br.ibm.com [9.18.232.44]) by d24relay01.br.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u7NFZ4oo4759708 for ; Tue, 23 Aug 2016 12:35:04 -0300 Received: from d24av05.br.ibm.com (localhost [127.0.0.1]) by d24av05.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u7NFZ33g007230 for ; Tue, 23 Aug 2016 12:35:04 -0300 Received: from hactar.localnet ([9.78.145.52]) by d24av05.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u7NFZ1i7007147; Tue, 23 Aug 2016 12:35:03 -0300 From: Thiago Jung Bauermann To: kbuild test robot Cc: kbuild-all@01.org, linux-ima-devel@lists.sourceforge.net, linux-security-module@vger.kernel.org, kexec@lists.infradead.org Subject: Re: [integrity:next-restore-kexec 18/31] include/linux/kexec.h:400:52: warning: 'struct kexec_buf' declared inside parameter list will not be visible outside of this definition or declaration Date: Tue, 23 Aug 2016 12:34:59 -0300 User-Agent: KMail/4.14.3 (Linux/3.13.0-93-generic; KDE/4.14.13; x86_64; ; ) In-Reply-To: <201608232256.6ONII0WZ%fengguang.wu@intel.com> References: <201608232256.6ONII0WZ%fengguang.wu@intel.com> MIME-Version: 1.0 X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16082315-0032-0000-0000-00000278F7F2 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16082315-0033-0000-0000-00000EC1CEAC Message-Id: <1617934.na55SdnaSp@hactar> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-08-23_09:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608230155 Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Am Dienstag, 23 August 2016, 22:17:59 schrieb kbuild test robot: > tree: > https://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git > next-restore-kexec head: 62bc4b565254de4796a0835f6f67569eb4835f9f > commit: f9f57350e53441210120931fc4e0163cf833e648 [18/31] kexec_file: Add > buffer hand-over support for the next kernel config: i386-defconfig > (attached as .config) > compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705 > reproduce: > git checkout f9f57350e53441210120931fc4e0163cf833e648 > # save the attached .config to linux build tree > make ARCH=i386 > > All warnings (new ones prefixed by >>): > > In file included from drivers/pci/pci-driver.c:22:0: > >> include/linux/kexec.h:400:52: warning: 'struct kexec_buf' declared > >> inside parameter list will not be visible outside of this definition > >> or declaration > static inline int kexec_add_handover_buffer(struct kexec_buf *kbuf) This happens when CONFIG_KEXEC=y but CONFIG_KEXEC_FILE=n, and is fixed by the following change, which will be in my next revision of the kexec buffer hand-over series: Fix for "kexec_file: Add buffer hand-over support for the next kernel" Declare stub struct kexec_buf when CONFIG_KEXEC_FILE=n. diff --git a/include/linux/kexec.h b/include/linux/kexec.h index 6ec09e85efd9..29f98f816e92 100644 --- a/include/linux/kexec.h +++ b/include/linux/kexec.h @@ -404,6 +404,8 @@ int kexec_add_handover_buffer(struct kexec_buf *kbuf); int __weak kexec_get_handover_buffer(void **addr, unsigned long *size); int __weak kexec_free_handover_buffer(void); #else +struct kexec_buf; + static inline bool kexec_can_hand_over_buffer(void) { return false;