| Message ID | 1722665314-21156-21-git-send-email-wufan@linux.microsoft.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Paul Moore |
| Headers | show |
| Series | Integrity Policy Enforcement LSM (IPE) | expand |
Dear Fan, Thank you very much for your patch. Two nits, should you sent another interation: A more specific summary would avoid people having to look at the message body or diff, and `git log --oneline` would be enough. MAINTAINERS: Add IPE entry with M: Fan Wu MAINTAINERS: Add IPE entry with Fan Wu as maintainer Am 03.08.24 um 08:08 schrieb Fan Wu: > Update MAINTAINERS to include ipe maintainer information. I’d at least mention Integrity Policy Enforcement. As you not only include the maintainer information but add a new entry, I’d leave the body out, or mention that a new entry is added. > Signed-off-by: Fan Wu <wufan@linux.microsoft.com> > > -- > v1-v16: > + Not present > > v17: > + Introduced > > v18: > + No changes > > v19: > + No changes > > v20: > + No changes > --- > MAINTAINERS | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 8766f3e5e87e..4cdf2d5a2058 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -11118,6 +11118,16 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git > F: security/integrity/ > F: security/integrity/ima/ > > +INTEGRITY POLICY ENFORCEMENT (IPE) > +M: Fan Wu <wufan@linux.microsoft.com> > +L: linux-security-module@vger.kernel.org > +S: Supported > +T: git https://github.com/microsoft/ipe.git > +F: Documentation/admin-guide/LSM/ipe.rst > +F: Documentation/security/ipe.rst > +F: scripts/ipe/ > +F: security/ipe/ > + > INTEL 810/815 FRAMEBUFFER DRIVER > M: Antonino Daplas <adaplas@gmail.com> > L: linux-fbdev@vger.kernel.org Kind regards, Paul
On Sat, Aug 3, 2024 at 4:15 AM Paul Menzel <pmenzel@molgen.mpg.de> wrote: > > Dear Fan, > > > Thank you very much for your patch. Two nits, should you sent another > interation: A more specific summary would avoid people having to look at > the message body or diff, and `git log --oneline` would be enough. > > MAINTAINERS: Add IPE entry with M: Fan Wu > > MAINTAINERS: Add IPE entry with Fan Wu as maintainer > > Am 03.08.24 um 08:08 schrieb Fan Wu: > > Update MAINTAINERS to include ipe maintainer information. > > I’d at least mention Integrity Policy Enforcement. As you not only > include the maintainer information but add a new entry, I’d leave the > body out, or mention that a new entry is added. > > > Signed-off-by: Fan Wu <wufan@linux.microsoft.com> Working under the current assumption that a new revision is not needed, I can fix this up during the merge. Fan, other-Paul, are you both okay with the following: "MAINTAINERS: add IPE entry with Fan Wu as maintainer Add a MAINTAINERS entry for the Integrity Policy Enforcement (IPE) LSM." > > -- > > v1-v16: > > + Not present > > > > v17: > > + Introduced > > > > v18: > > + No changes > > > > v19: > > + No changes > > > > v20: > > + No changes > > --- > > MAINTAINERS | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 8766f3e5e87e..4cdf2d5a2058 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -11118,6 +11118,16 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git > > F: security/integrity/ > > F: security/integrity/ima/ > > > > +INTEGRITY POLICY ENFORCEMENT (IPE) > > +M: Fan Wu <wufan@linux.microsoft.com> > > +L: linux-security-module@vger.kernel.org > > +S: Supported > > +T: git https://github.com/microsoft/ipe.git > > +F: Documentation/admin-guide/LSM/ipe.rst > > +F: Documentation/security/ipe.rst > > +F: scripts/ipe/ > > +F: security/ipe/ > > + > > INTEL 810/815 FRAMEBUFFER DRIVER > > M: Antonino Daplas <adaplas@gmail.com> > > L: linux-fbdev@vger.kernel.org > > Kind regards, > > Paul
Dear Paul, Am 06.08.24 um 22:54 schrieb Paul Moore: > On Sat, Aug 3, 2024 at 4:15 AM Paul Menzel wrote: >> Thank you very much for your patch. Two nits, should you sent another >> interation: A more specific summary would avoid people having to look at >> the message body or diff, and `git log --oneline` would be enough. >> >> MAINTAINERS: Add IPE entry with M: Fan Wu >> >> MAINTAINERS: Add IPE entry with Fan Wu as maintainer >> >> Am 03.08.24 um 08:08 schrieb Fan Wu: >>> Update MAINTAINERS to include ipe maintainer information. >> >> I’d at least mention Integrity Policy Enforcement. As you not only >> include the maintainer information but add a new entry, I’d leave the >> body out, or mention that a new entry is added. >> >>> Signed-off-by: Fan Wu <wufan@linux.microsoft.com> > > Working under the current assumption that a new revision is not > needed, I can fix this up during the merge. Fan, other-Paul, are you > both okay with the following: > > "MAINTAINERS: add IPE entry with Fan Wu as maintainer > > Add a MAINTAINERS entry for the Integrity Policy Enforcement (IPE) LSM." Thank you. That is fine by me. Kind regards, Paul >>> -- >>> v1-v16: >>> + Not present >>> >>> v17: >>> + Introduced >>> >>> v18: >>> + No changes >>> >>> v19: >>> + No changes >>> >>> v20: >>> + No changes >>> --- >>> MAINTAINERS | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> >>> diff --git a/MAINTAINERS b/MAINTAINERS >>> index 8766f3e5e87e..4cdf2d5a2058 100644 >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -11118,6 +11118,16 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git >>> F: security/integrity/ >>> F: security/integrity/ima/ >>> >>> +INTEGRITY POLICY ENFORCEMENT (IPE) >>> +M: Fan Wu <wufan@linux.microsoft.com> >>> +L: linux-security-module@vger.kernel.org >>> +S: Supported >>> +T: git https://github.com/microsoft/ipe.git >>> +F: Documentation/admin-guide/LSM/ipe.rst >>> +F: Documentation/security/ipe.rst >>> +F: scripts/ipe/ >>> +F: security/ipe/ >>> + >>> INTEL 810/815 FRAMEBUFFER DRIVER >>> M: Antonino Daplas <adaplas@gmail.com> >>> L: linux-fbdev@vger.kernel.org
On 8/6/2024 9:48 PM, Paul Menzel wrote: > Dear Paul, > > > Am 06.08.24 um 22:54 schrieb Paul Moore: >> On Sat, Aug 3, 2024 at 4:15 AM Paul Menzel wrote: > >>> Thank you very much for your patch. Two nits, should you sent another >>> interation: A more specific summary would avoid people having to look at >>> the message body or diff, and `git log --oneline` would be enough. >>> >>> MAINTAINERS: Add IPE entry with M: Fan Wu >>> >>> MAINTAINERS: Add IPE entry with Fan Wu as maintainer >>> >>> Am 03.08.24 um 08:08 schrieb Fan Wu: >>>> Update MAINTAINERS to include ipe maintainer information. >>> >>> I’d at least mention Integrity Policy Enforcement. As you not only >>> include the maintainer information but add a new entry, I’d leave the >>> body out, or mention that a new entry is added. >>> >>>> Signed-off-by: Fan Wu <wufan@linux.microsoft.com> >> >> Working under the current assumption that a new revision is not >> needed, I can fix this up during the merge. Fan, other-Paul, are you >> both okay with the following: >> >> "MAINTAINERS: add IPE entry with Fan Wu as maintainer >> >> Add a MAINTAINERS entry for the Integrity Policy Enforcement (IPE) >> LSM." > > Thank you. That is fine by me. > > > Kind regards, > > Paul > > Hi Paul and Paul, Thank you both for your feedback and coordination on this. I'm good with the proposed changes and appreciate your efforts. -Fan
On Wed, Aug 7, 2024 at 2:01 PM Fan Wu <wufan@linux.microsoft.com> wrote: > On 8/6/2024 9:48 PM, Paul Menzel wrote: > > Dear Paul, > > > > Am 06.08.24 um 22:54 schrieb Paul Moore: > >> On Sat, Aug 3, 2024 at 4:15 AM Paul Menzel wrote: > > > >>> Thank you very much for your patch. Two nits, should you sent another > >>> interation: A more specific summary would avoid people having to look at > >>> the message body or diff, and `git log --oneline` would be enough. > >>> > >>> MAINTAINERS: Add IPE entry with M: Fan Wu > >>> > >>> MAINTAINERS: Add IPE entry with Fan Wu as maintainer > >>> > >>> Am 03.08.24 um 08:08 schrieb Fan Wu: > >>>> Update MAINTAINERS to include ipe maintainer information. > >>> > >>> I’d at least mention Integrity Policy Enforcement. As you not only > >>> include the maintainer information but add a new entry, I’d leave the > >>> body out, or mention that a new entry is added. > >>> > >>>> Signed-off-by: Fan Wu <wufan@linux.microsoft.com> > >> > >> Working under the current assumption that a new revision is not > >> needed, I can fix this up during the merge. Fan, other-Paul, are you > >> both okay with the following: > >> > >> "MAINTAINERS: add IPE entry with Fan Wu as maintainer > >> > >> Add a MAINTAINERS entry for the Integrity Policy Enforcement (IPE) > >> LSM." > > > > Thank you. That is fine by me. > > > > Kind regards, > > Paul > > Hi Paul and Paul, > > Thank you both for your feedback and coordination on this. I'm good with > the proposed changes and appreciate your efforts. Updated as shown above, thanks all.
diff --git a/MAINTAINERS b/MAINTAINERS index 8766f3e5e87e..4cdf2d5a2058 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11118,6 +11118,16 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git F: security/integrity/ F: security/integrity/ima/ +INTEGRITY POLICY ENFORCEMENT (IPE) +M: Fan Wu <wufan@linux.microsoft.com> +L: linux-security-module@vger.kernel.org +S: Supported +T: git https://github.com/microsoft/ipe.git +F: Documentation/admin-guide/LSM/ipe.rst +F: Documentation/security/ipe.rst +F: scripts/ipe/ +F: security/ipe/ + INTEL 810/815 FRAMEBUFFER DRIVER M: Antonino Daplas <adaplas@gmail.com> L: linux-fbdev@vger.kernel.org
Update MAINTAINERS to include ipe maintainer information. Signed-off-by: Fan Wu <wufan@linux.microsoft.com> -- v1-v16: + Not present v17: + Introduced v18: + No changes v19: + No changes v20: + No changes --- MAINTAINERS | 10 ++++++++++ 1 file changed, 10 insertions(+)