From patchwork Tue Jul 19 20:40:27 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Gunthorpe X-Patchwork-Id: 9238329 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 11B7B60574 for ; Tue, 19 Jul 2016 20:40:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 035512624D for ; Tue, 19 Jul 2016 20:40:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EC502275A2; Tue, 19 Jul 2016 20:40:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7F4A12624D for ; Tue, 19 Jul 2016 20:40:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752177AbcGSUke (ORCPT ); Tue, 19 Jul 2016 16:40:34 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:60468 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752168AbcGSUkd (ORCPT ); Tue, 19 Jul 2016 16:40:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=obsidianresearch.com; s=rsa1; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=ziGQLhVtjFAb771U6ZKDhSVzbp2msgZDpMvoTTBZDgc=; b=T24Uns3yiw3ppQ/9Q4HkmI+bWgCotZFC0ldyEDQBpFvw7yID83Nlhi1hYR26r+6oY4Z3n8aU33J/hpf97vh+kwyWG2PZfQTYSGCOP0IrHIqQanQtsUP0/ll1FZL3P8rI7+a5RZuXTm5fHNXS5uxNzeYm4+2oMk+qQOv9n2ZrudA=; Received: from [10.0.0.151] (helo=jggl.edm.orcorp.ca) by quartz.orcorp.ca with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1bPboZ-0004V2-B5; Tue, 19 Jul 2016 14:40:27 -0600 Received: from jgg by jggl.edm.orcorp.ca with local (Exim 4.84) (envelope-from ) id 1bPboZ-0004TL-6S; Tue, 19 Jul 2016 14:40:27 -0600 Date: Tue, 19 Jul 2016 14:40:27 -0600 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: Peter Huewe , linux-security-module@vger.kernel.org, Stefan Berger , Marcel Selhorst , "moderated list:TPM DEVICE DRIVER" , open list Subject: Re: [PATCH v3 3/5] tpm: return error code from tpm_gen_interrupt() Message-ID: <20160719204027.GE16042@obsidianresearch.com> References: <1468935171-7815-1-git-send-email-jarkko.sakkinen@linux.intel.com> <1468935171-7815-4-git-send-email-jarkko.sakkinen@linux.intel.com> <20160719202741.GB16042@obsidianresearch.com> <20160719203147.GA26228@intel.com> <20160719203634.GB26228@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160719203634.GB26228@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.151 Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Jul 19, 2016 at 11:36:34PM +0300, Jarkko Sakkinen wrote: > If Christophe could submit a fix for st33, I could include it to this > series and make one more revision. Thank you for reviewing this! Here is a commit: From 5e178858dcdc2bff9ac31f9851db52370cc282cb Mon Sep 17 00:00:00 2001 From: Jason Gunthorpe Date: Tue, 19 Jul 2016 14:38:55 -0600 Subject: [PATCH] tpm/st33zp24: Remove useless tpm_gen_interrupt This function should only be called as part of an IRQ probing protocol and st33 does not have any code to detect that the IRQ it tries to generate was not generated and disable the IRQ. Since st33 is primarily a DT binding driver it should not be doing IRQ probing anyhow, so let us just delete this useless call. Signed-off-by: Jason Gunthorpe --- drivers/char/tpm/st33zp24/st33zp24.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/char/tpm/st33zp24/st33zp24.c b/drivers/char/tpm/st33zp24/st33zp24.c index c2ee30451e41..6f060c76217b 100644 --- a/drivers/char/tpm/st33zp24/st33zp24.c +++ b/drivers/char/tpm/st33zp24/st33zp24.c @@ -589,8 +589,6 @@ int st33zp24_probe(void *phy_id, const struct st33zp24_phy_ops *ops, chip->flags |= TPM_CHIP_FLAG_IRQ; disable_irq_nosync(tpm_dev->irq); - - tpm_gen_interrupt(chip); } return tpm_chip_register(chip);