diff mbox

xattr: fix kstrdup.cocci warnings

Message ID 20170624210224.GA140192@lkp-ib03.lkp.intel.com
State New
Headers show

Commit Message

kernel test robot June 24, 2017, 9:02 p.m. UTC
fs/xattr.c:516:10-17: WARNING opportunity for kstrdep (strcpy on line 519)

 Use kstrdup rather than duplicating its implementation

Generated by: scripts/coccinelle/api/kstrdup.cocci

CC: Stefan Berger <stefanb@linux.vnet.ibm.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

 xattr.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox


--- a/fs/xattr.c
+++ b/fs/xattr.c
@@ -513,10 +513,9 @@  xattr_userns_name(const char *fullname,
 	return buffer;
-	buffer = kmalloc(strlen(suffix) + 1, GFP_KERNEL);
+	buffer = kstrdup(suffix, GFP_KERNEL);
 	if (!buffer)
 		return ERR_PTR(-ENOMEM);
-	strcpy(buffer, suffix);
 	return buffer;