diff mbox

apparmor: Fix an error code in verify_table_headers()

Message ID 20180319091231.GA7409@mwanda (mailing list archive)
State New, archived
Headers show

Commit Message

Dan Carpenter March 19, 2018, 9:12 a.m. UTC 
We accidentally return a positive EPROTO instead of a negative -EPROTO.
Since 71 is not an error pointer, that means it eventually results in an
Oops in the caller.

Fixes: d901d6a298dc ("apparmor: dfa split verification of table headers")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

John Johansen March 24, 2018, 12:27 a.m. UTC | #1 
On 03/19/2018 02:12 AM, Dan Carpenter wrote:
> We accidentally return a positive EPROTO instead of a negative -EPROTO.
> Since 71 is not an error pointer, that means it eventually results in an
> Oops in the caller.
> 
> Fixes: d901d6a298dc ("apparmor: dfa split verification of table headers")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
ouch, and pulled into apparmor-next

Acked-by: John Johansen <john.johansen@canonical.com>

> diff --git a/security/apparmor/match.c b/security/apparmor/match.c
> index dd4c995c5e25..280eba082c7b 100644
> --- a/security/apparmor/match.c
> +++ b/security/apparmor/match.c
> @@ -198,7 +198,7 @@ static int verify_table_headers(struct table_header **tables, int flags)
>  static int verify_dfa(struct aa_dfa *dfa)
>  {
>  	size_t i, state_count, trans_count;
> -	int error = EPROTO;
> +	int error = -EPROTO;
>  
>  	state_count = dfa->tables[YYTD_ID_BASE]->td_lolen;
>  	trans_count = dfa->tables[YYTD_ID_NXT]->td_lolen;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/security/apparmor/match.c b/security/apparmor/match.c
index dd4c995c5e25..280eba082c7b 100644
--- a/security/apparmor/match.c
+++ b/security/apparmor/match.c
@@ -198,7 +198,7 @@  static int verify_table_headers(struct table_header **tables, int flags)
 static int verify_dfa(struct aa_dfa *dfa)
 {
 	size_t i, state_count, trans_count;
-	int error = EPROTO;
+	int error = -EPROTO;
 
 	state_count = dfa->tables[YYTD_ID_BASE]->td_lolen;
 	trans_count = dfa->tables[YYTD_ID_NXT]->td_lolen;