diff mbox series

Smack: Mark expected switch fall-through

Message ID 20180801223854.GA14499@embeddedor.com (mailing list archive)
State New, archived
Headers show
Series Smack: Mark expected switch fall-through | expand

Commit Message

Gustavo A. R. Silva Aug. 1, 2018, 10:38 p.m. UTC
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Notice that in this particular case, I replaced "No break" with a
proper "Fall through" annotation, which is what GCC is expecting
to find.

Warning level 2 was used: -Wimplicit-fallthrough=2

Addresses-Coverity-ID: 115051 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
 security/smack/smack_lsm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series


diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
index ad45761..a307b00 100644
--- a/security/smack/smack_lsm.c
+++ b/security/smack/smack_lsm.c
@@ -3739,7 +3739,7 @@  static void smack_d_instantiate(struct dentry *opt_dentry, struct inode *inode)
 		final = &smack_known_star;
-		 * No break.
+		 * Fall through.
 		 * If a smack value has been set we want to use it,
 		 * but since tmpfs isn't giving us the opportunity