From patchwork Mon Jan 14 20:28:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Malaterre X-Patchwork-Id: 10763393 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BDA8E13BF for ; Mon, 14 Jan 2019 20:28:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B02AA2A03B for ; Mon, 14 Jan 2019 20:28:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AE6F32A052; Mon, 14 Jan 2019 20:28:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 491212A03B for ; Mon, 14 Jan 2019 20:28:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726924AbfANU2p (ORCPT ); Mon, 14 Jan 2019 15:28:45 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:50878 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726755AbfANU2p (ORCPT ); Mon, 14 Jan 2019 15:28:45 -0500 Received: by mail-wm1-f67.google.com with SMTP id n190so1036058wmd.0; Mon, 14 Jan 2019 12:28:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YUpeuBEePI61woIFDLau8xwrTZMnkUOa1PKwQJXoxUk=; b=pPN6TSnmvHqU6ff5J/UBBIV/mT7hFNQ1OvWEDIHKRNjdfN7x7WNgVUsdUIEqnKizvI 1akoKqYsGPQJxE/hRrtlxO/DEMnl9n1SBkp+36tq56AsO13phgE55pjkQ27b3VCof1DV 9x2iANu5iYuu4d6GlUtXZmtiOOMbEYcT8iuPTjk9lh0rxZEaAeYbq1LioZFPGH9Y8OYp rLS4SABr4A8AkJOJGJYG2U3sJDNvJkaNme9g2dWJ2XkD0YleMXVKpiBXvJ6bfBT8WEUG psMJ55S7XESS3xUdjDOPBTQ61RWsQRJwZ5Qa1xsMWFiQesuCQ7QUHWj+JmZSOzjyRjiT u7Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=YUpeuBEePI61woIFDLau8xwrTZMnkUOa1PKwQJXoxUk=; b=OK/4ksv29SaO7gVCwrVjvcQtxS0dZzomSx6fpBLR2zBFxQlnA1kUZR46aqm9tTjx3f +xG0QTOWXouo65FiOomdKd4ToD5YHdgWKZEn/v5AWxhzzI6EbgLfhG7TIrx64svdvMak XtpCQtsJidKbKfuFrSUI6zeM7Nq5/9DoF560OpMPFRO5JlIRZDogkp1oEaQsIr850e0G HUUtTbh+oZKeKrpRv66rh5/GP6lHkoLJVKmGVbAw87DKXZ69EbJ9Jym891JG06IJ3bsi g81Uq6nqqjM/TrMs165nJqE+3Fsr2OpIaXZOixkr90UI0pkaJUwuzZ1yZW7K9x1hXmkX Xx7w== X-Gm-Message-State: AJcUukdabXL3cy17U0JaurBvO+MFUsMSJVKos9FmQhujJkNpN/cEFoUl UncJJElSI3KxTdjYzYVOqmxrmIkj X-Google-Smtp-Source: ALg8bN7z1wNl7vRY+k90xQLvkaYOdcGqnNC8b64qoKhtK7q5XbRWi+pAh/tFmA0sDJ67vAPfKCaP5w== X-Received: by 2002:a1c:e715:: with SMTP id e21mr633378wmh.101.1547497723207; Mon, 14 Jan 2019 12:28:43 -0800 (PST) Received: from macbookpro.malat.net ([2a01:e34:ee1e:860:6f23:82e6:aa2d:bbd1]) by smtp.gmail.com with ESMTPSA id x20sm42001681wme.6.2019.01.14.12.28.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Jan 2019 12:28:42 -0800 (PST) Received: by macbookpro.malat.net (Postfix, from userid 1000) id 9A23E11422AD; Mon, 14 Jan 2019 21:28:41 +0100 (CET) From: Mathieu Malaterre To: Serge Hallyn Cc: Mathieu Malaterre , linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] capabilities:: annotate implicit fall through Date: Mon, 14 Jan 2019 21:28:35 +0100 Message-Id: <20190114202835.15878-1-malat@debian.org> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: X-Virus-Scanned: ClamAV using ClamSMTP There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warning (W=1). In this particular case change put the fall through comment on a single line so as to match the regular expression expected by GCC. This commit remove the following warning: kernel/capability.c:95:3: warning: this statement may fall through [-Wimplicit-fallthrough=] Signed-off-by: Mathieu Malaterre Acked-by: Gustavo A. R. Silva --- kernel/capability.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/kernel/capability.c b/kernel/capability.c index 1e1c0236f55b..e60be18b98e2 100644 --- a/kernel/capability.c +++ b/kernel/capability.c @@ -93,9 +93,7 @@ static int cap_validate_magic(cap_user_header_t header, unsigned *tocopy) break; case _LINUX_CAPABILITY_VERSION_2: warn_deprecated_v2(); - /* - * fall through - v3 is otherwise equivalent to v2. - */ + /* fall through - v3 is otherwise equivalent to v2. */ case _LINUX_CAPABILITY_VERSION_3: *tocopy = _LINUX_CAPABILITY_U32S_3; break;