| Message ID | 20190703025518.6379-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] integrity: Remove set but not used variable 'acl' | expand |
YueHaibing <yuehaibing@huawei.com> wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > security/integrity/digsig.c: In function 'integrity_init_keyring': > security/integrity/digsig.c:99:18: warning: > variable 'acl' set but not used [-Wunused-but-set-variable] > > It seems 'acl' is needed in __integrity_init_keyring I've folded this fix in, thanks. David
On 2019/7/3 21:57, David Howells wrote: > YueHaibing <yuehaibing@huawei.com> wrote: > >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> security/integrity/digsig.c: In function 'integrity_init_keyring': >> security/integrity/digsig.c:99:18: warning: >> variable 'acl' set but not used [-Wunused-but-set-variable] >> >> It seems 'acl' is needed in __integrity_init_keyring > > I've folded this fix in, thanks. Thanks, also I write a wrong patch title. > > David > > . >
diff --git a/security/integrity/digsig.c b/security/integrity/digsig.c index 1f2c43f62047..f9f3c8ffe786 100644 --- a/security/integrity/digsig.c +++ b/security/integrity/digsig.c @@ -114,7 +114,7 @@ int __init integrity_init_keyring(const unsigned int id) acl = &internal_writable_keyring_acl; out: - return __integrity_init_keyring(id, &internal_keyring_acl, restriction); + return __integrity_init_keyring(id, acl, restriction); } static int __init integrity_add_key(const unsigned int id, const void *data,
Fixes gcc '-Wunused-but-set-variable' warning: security/integrity/digsig.c: In function 'integrity_init_keyring': security/integrity/digsig.c:99:18: warning: variable 'acl' set but not used [-Wunused-but-set-variable] It seems 'acl' is needed in __integrity_init_keyring Fixes: 6100ac53909d ("keys: Replace uid/gid/perm permissions checking with an ACL") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- security/integrity/digsig.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)