From patchwork Mon Mar 23 16:44:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: KP Singh X-Patchwork-Id: 11453493 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 314BD6CA for ; Mon, 23 Mar 2020 16:44:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E8AD620753 for ; Mon, 23 Mar 2020 16:44:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="TW+/rwyx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727829AbgCWQot (ORCPT ); Mon, 23 Mar 2020 12:44:49 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:36703 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727598AbgCWQok (ORCPT ); Mon, 23 Mar 2020 12:44:40 -0400 Received: by mail-wr1-f67.google.com with SMTP id 31so11936626wrs.3 for ; Mon, 23 Mar 2020 09:44:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hNnT69pxg2eYE6uGhioN4FH2+4XbGURiqaggzHNPFW0=; b=TW+/rwyxb8wdk7e/NGL0yVvkx4tXi6cAmmRl0/yEwpBBBq+bbV4rkI36+r0Mov7Amw g1LUMcZTU0hMBn2Ix2tVc/vKoBadNYSEtgjtkj8fTO4e0h78t5qZPUg9R13ESQ1/7hxZ TkWEPcLTqmTnI7yd9cCDQJGXqnsafNw5J6S+s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hNnT69pxg2eYE6uGhioN4FH2+4XbGURiqaggzHNPFW0=; b=Plt8KopczvY4SzBJRLviZdmOcB4Gtof1iw14XbwKDa8Va2r4KTKaQzcIqsYXbr/zWT c8BWhOryfaz8s+42nRyD9Pp43aL+BMMujgLwFH7MRAFIJ6LbonnKH4Vao6R5EyAQDLVE d/QEmGQEFWdZHPu5B6EZ7CFFtJGZNdmczhk40bKDvqIy8inDTkDD0AwCvKJhUJwD92ka m/fiaiZ/HO60ie6fITIdUb2MhAsZKaZuMMftSYOsgKZ4XA0QcoEXAWN3KN8Imrf2AgNy aLu9ZLkyVScwC1oO8E3vqdu7+jId1rYHxJ/JBJhyP4ijwm/nq+BTZNd8EechSa4CHQxu NS4A== X-Gm-Message-State: ANhLgQ2a5+Cl0lzZwAGalgCYhzyl2MnMhrn8i5NGnDQBkWzbWMaB8ye1 ug5lFrwg/2fo3GvJA8LtekeqoQ== X-Google-Smtp-Source: ADFU+vuF+58XxqQmQZl7BKSQ4GLqqwbXHdHNZVG8TRwqbPl4Eyu1AdM1G+EQZgCaAtuYHyASfYczkw== X-Received: by 2002:a5d:6187:: with SMTP id j7mr7202750wru.419.1584981878319; Mon, 23 Mar 2020 09:44:38 -0700 (PDT) Received: from kpsingh-kernel.localdomain (77-56-209-237.dclient.hispeed.ch. [77.56.209.237]) by smtp.gmail.com with ESMTPSA id l8sm199874wmj.2.2020.03.23.09.44.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2020 09:44:37 -0700 (PDT) From: KP Singh To: linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-security-module@vger.kernel.org Cc: Brendan Jackman , Florent Revest , Thomas Garnier , Alexei Starovoitov , Daniel Borkmann , James Morris , Kees Cook , Paul Turner , Jann Horn , Florent Revest , Brendan Jackman , Greg Kroah-Hartman Subject: [PATCH bpf-next v5 7/7] bpf: lsm: Add selftests for BPF_PROG_TYPE_LSM Date: Mon, 23 Mar 2020 17:44:15 +0100 Message-Id: <20200323164415.12943-8-kpsingh@chromium.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200323164415.12943-1-kpsingh@chromium.org> References: <20200323164415.12943-1-kpsingh@chromium.org> MIME-Version: 1.0 Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: From: KP Singh * Load/attach a BPF program to the file_mprotect (int) and bprm_committed_creds (void) LSM hooks. * Perform an action that triggers the hook. * Verify if the audit event was received using a shared global result variable. Signed-off-by: KP Singh Reviewed-by: Brendan Jackman Reviewed-by: Florent Revest Reviewed-by: Thomas Garnier --- tools/testing/selftests/bpf/lsm_helpers.h | 19 +++ .../selftests/bpf/prog_tests/lsm_test.c | 112 ++++++++++++++++++ .../selftests/bpf/progs/lsm_int_hook.c | 54 +++++++++ .../selftests/bpf/progs/lsm_void_hook.c | 41 +++++++ 4 files changed, 226 insertions(+) create mode 100644 tools/testing/selftests/bpf/lsm_helpers.h create mode 100644 tools/testing/selftests/bpf/prog_tests/lsm_test.c create mode 100644 tools/testing/selftests/bpf/progs/lsm_int_hook.c create mode 100644 tools/testing/selftests/bpf/progs/lsm_void_hook.c diff --git a/tools/testing/selftests/bpf/lsm_helpers.h b/tools/testing/selftests/bpf/lsm_helpers.h new file mode 100644 index 000000000000..3de230df93db --- /dev/null +++ b/tools/testing/selftests/bpf/lsm_helpers.h @@ -0,0 +1,19 @@ +/* SPDX-License-Identifier: GPL-2.0 */ + +/* + * Copyright (C) 2020 Google LLC. + */ +#ifndef _LSM_HELPERS_H +#define _LSM_HELPERS_H + +struct lsm_prog_result { + /* This ensures that the LSM Hook only monitors the PID requested + * by the loader + */ + __u32 monitored_pid; + /* The number of calls to the prog for the monitored PID. + */ + __u32 count; +}; + +#endif /* _LSM_HELPERS_H */ diff --git a/tools/testing/selftests/bpf/prog_tests/lsm_test.c b/tools/testing/selftests/bpf/prog_tests/lsm_test.c new file mode 100644 index 000000000000..5fd6b8f569f7 --- /dev/null +++ b/tools/testing/selftests/bpf/prog_tests/lsm_test.c @@ -0,0 +1,112 @@ +// SPDX-License-Identifier: GPL-2.0 + +/* + * Copyright (C) 2020 Google LLC. + */ + +#include +#include +#include +#include +#include +#include + +#include "lsm_helpers.h" +#include "lsm_void_hook.skel.h" +#include "lsm_int_hook.skel.h" + +char *LS_ARGS[] = {"true", NULL}; + +int heap_mprotect(void) +{ + void *buf; + long sz; + + sz = sysconf(_SC_PAGESIZE); + if (sz < 0) + return sz; + + buf = memalign(sz, 2 * sz); + if (buf == NULL) + return -ENOMEM; + + return mprotect(buf, sz, PROT_READ | PROT_EXEC); +} + +int exec_ls(struct lsm_prog_result *result) +{ + int child_pid; + + child_pid = fork(); + if (child_pid == 0) { + result->monitored_pid = getpid(); + execvp(LS_ARGS[0], LS_ARGS); + return -EINVAL; + } else if (child_pid > 0) + return wait(NULL); + + return -EINVAL; +} + +void test_lsm_void_hook(void) +{ + struct lsm_prog_result *result; + struct lsm_void_hook *skel = NULL; + int err, duration = 0; + + skel = lsm_void_hook__open_and_load(); + if (CHECK(!skel, "skel_load", "lsm_void_hook skeleton failed\n")) + goto close_prog; + + err = lsm_void_hook__attach(skel); + if (CHECK(err, "attach", "lsm_void_hook attach failed: %d\n", err)) + goto close_prog; + + result = &skel->bss->result; + + err = exec_ls(result); + if (CHECK(err < 0, "exec_ls", "err %d errno %d\n", err, errno)) + goto close_prog; + + if (CHECK(result->count != 1, "count", "count = %d", result->count)) + goto close_prog; + + CHECK_FAIL(result->count != 1); + +close_prog: + lsm_void_hook__destroy(skel); +} + +void test_lsm_int_hook(void) +{ + struct lsm_prog_result *result; + struct lsm_int_hook *skel = NULL; + int err, duration = 0; + + skel = lsm_int_hook__open_and_load(); + if (CHECK(!skel, "skel_load", "lsm_int_hook skeleton failed\n")) + goto close_prog; + + err = lsm_int_hook__attach(skel); + if (CHECK(err, "attach", "lsm_int_hook attach failed: %d\n", err)) + goto close_prog; + + result = &skel->bss->result; + result->monitored_pid = getpid(); + + err = heap_mprotect(); + if (CHECK(errno != EPERM, "heap_mprotect", "want errno=EPERM, got %d\n", + errno)) + goto close_prog; + + CHECK_FAIL(result->count != 1); + +close_prog: + lsm_int_hook__destroy(skel); +} + +void test_lsm_test(void) +{ + test_lsm_void_hook(); + test_lsm_int_hook(); +} diff --git a/tools/testing/selftests/bpf/progs/lsm_int_hook.c b/tools/testing/selftests/bpf/progs/lsm_int_hook.c new file mode 100644 index 000000000000..1c5028ddca61 --- /dev/null +++ b/tools/testing/selftests/bpf/progs/lsm_int_hook.c @@ -0,0 +1,54 @@ +// SPDX-License-Identifier: GPL-2.0 + +/* + * Copyright 2020 Google LLC. + */ + +#include +#include +#include +#include +#include +#include "lsm_helpers.h" + +char _license[] SEC("license") = "GPL"; + +struct lsm_prog_result result = { + .monitored_pid = 0, + .count = 0, +}; + +/* + * Define some of the structs used in the BPF program. + * Only the field names and their sizes need to be the + * same as the kernel type, the order is irrelevant. + */ +struct mm_struct { + unsigned long start_brk, brk; +} __attribute__((preserve_access_index)); + +struct vm_area_struct { + unsigned long vm_start, vm_end; + struct mm_struct *vm_mm; +} __attribute__((preserve_access_index)); + +SEC("lsm/file_mprotect") +int BPF_PROG(test_int_hook, struct vm_area_struct *vma, + unsigned long reqprot, unsigned long prot, int ret) +{ + if (ret != 0) + return ret; + + __u32 pid = bpf_get_current_pid_tgid(); + int is_heap = 0; + + is_heap = (vma->vm_start >= vma->vm_mm->start_brk && + vma->vm_end <= vma->vm_mm->brk); + + if (is_heap && result.monitored_pid == pid) { + result.count++; + ret = -EPERM; + } + + return ret; +} diff --git a/tools/testing/selftests/bpf/progs/lsm_void_hook.c b/tools/testing/selftests/bpf/progs/lsm_void_hook.c new file mode 100644 index 000000000000..4d01a8536413 --- /dev/null +++ b/tools/testing/selftests/bpf/progs/lsm_void_hook.c @@ -0,0 +1,41 @@ +// SPDX-License-Identifier: GPL-2.0 + +/* + * Copyright (C) 2020 Google LLC. + */ + +#include +#include +#include +#include +#include +#include "lsm_helpers.h" + +char _license[] SEC("license") = "GPL"; + +struct lsm_prog_result result = { + .monitored_pid = 0, + .count = 0, +}; + +/* + * Define some of the structs used in the BPF program. + * Only the field names and their sizes need to be the + * same as the kernel type, the order is irrelevant. + */ +struct linux_binprm { + const char *filename; +} __attribute__((preserve_access_index)); + +SEC("lsm/bprm_committed_creds") +int BPF_PROG(test_void_hook, struct linux_binprm *bprm) +{ + __u32 pid = bpf_get_current_pid_tgid(); + char fmt[] = "lsm(bprm_committed_creds): process executed %s\n"; + + bpf_trace_printk(fmt, sizeof(fmt), bprm->filename); + if (result.monitored_pid == pid) + result.count++; + + return 0; +}