diff mbox series

[v1] efi: Don't use knowledge about efi_guid_t internals

Message ID 20210209164506.54176-1-andriy.shevchenko@linux.intel.com (mailing list archive)
State New
Headers show
Series [v1] efi: Don't use knowledge about efi_guid_t internals | expand

Commit Message

Andy Shevchenko Feb. 9, 2021, 4:45 p.m. UTC
When print GUIDs supply pointer to the efi_guid_t (guid_t) type rather
its internal members.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 security/integrity/platform_certs/efi_parser.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ard Biesheuvel Feb. 9, 2021, 4:51 p.m. UTC | #1
On Tue, 9 Feb 2021 at 17:45, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> When print GUIDs supply pointer to the efi_guid_t (guid_t) type rather
> its internal members.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> ---
>  security/integrity/platform_certs/efi_parser.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/integrity/platform_certs/efi_parser.c b/security/integrity/platform_certs/efi_parser.c
> index 18f01f36fe6a..d98260f8402a 100644
> --- a/security/integrity/platform_certs/efi_parser.c
> +++ b/security/integrity/platform_certs/efi_parser.c
> @@ -55,7 +55,7 @@ int __init parse_efi_signature_list(
>                 memcpy(&list, data, sizeof(list));
>                 pr_devel("LIST[%04x] guid=%pUl ls=%x hs=%x ss=%x\n",
>                          offs,
> -                        list.signature_type.b, list.signature_list_size,
> +                        &list.signature_type, list.signature_list_size,
>                          list.signature_header_size, list.signature_size);
>
>                 lsize = list.signature_list_size;
> --
> 2.30.0
>
diff mbox series

Patch

diff --git a/security/integrity/platform_certs/efi_parser.c b/security/integrity/platform_certs/efi_parser.c
index 18f01f36fe6a..d98260f8402a 100644
--- a/security/integrity/platform_certs/efi_parser.c
+++ b/security/integrity/platform_certs/efi_parser.c
@@ -55,7 +55,7 @@  int __init parse_efi_signature_list(
 		memcpy(&list, data, sizeof(list));
 		pr_devel("LIST[%04x] guid=%pUl ls=%x hs=%x ss=%x\n",
 			 offs,
-			 list.signature_type.b, list.signature_list_size,
+			 &list.signature_type, list.signature_list_size,
 			 list.signature_header_size, list.signature_size);
 
 		lsize = list.signature_list_size;