diff mbox series

integrity/ima: Add declarations to init_once void arguments.

Message ID 20210323013318.296993-1-unclexiaole@gmail.com (mailing list archive)
State New
Headers show
Series integrity/ima: Add declarations to init_once void arguments. | expand

Commit Message

Jiele Zhao March 23, 2021, 1:33 a.m. UTC
init_once is a callback to kmem_cache_create. The parameter
type of this function is void *, so it's better to give a
explicit cast here.

Signed-off-by: Jiele Zhao <unclexiaole@gmail.com>
---
 security/integrity/iint.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jiele Zhao March 29, 2021, 10:18 a.m. UTC | #1
Ping.

On 2021/3/23 9:33, Jiele Zhao wrote:
> init_once is a callback to kmem_cache_create. The parameter
> type of this function is void *, so it's better to give a
> explicit cast here.
>
> Signed-off-by: Jiele Zhao <unclexiaole@gmail.com>
> ---
>   security/integrity/iint.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/integrity/iint.c b/security/integrity/iint.c
> index 1d20003243c3..5f3f2de997e1 100644
> --- a/security/integrity/iint.c
> +++ b/security/integrity/iint.c
> @@ -152,7 +152,7 @@ void integrity_inode_free(struct inode *inode)
>   
>   static void init_once(void *foo)
>   {
> -	struct integrity_iint_cache *iint = foo;
> +	struct integrity_iint_cache *iint = (struct integrity_iint_cache *)foo;
>   
>   	memset(iint, 0, sizeof(*iint));
>   	iint->ima_file_status = INTEGRITY_UNKNOWN;
Jiele Zhao April 6, 2021, 2:16 a.m. UTC | #2
Ping.

On 2021/3/23 9:33, Jiele Zhao wrote:
> init_once is a callback to kmem_cache_create. The parameter
> type of this function is void *, so it's better to give a
> explicit cast here.
>
> Signed-off-by: Jiele Zhao <unclexiaole@gmail.com>
> ---
>   security/integrity/iint.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/integrity/iint.c b/security/integrity/iint.c
> index 1d20003243c3..5f3f2de997e1 100644
> --- a/security/integrity/iint.c
> +++ b/security/integrity/iint.c
> @@ -152,7 +152,7 @@ void integrity_inode_free(struct inode *inode)
>   
>   static void init_once(void *foo)
>   {
> -	struct integrity_iint_cache *iint = foo;
> +	struct integrity_iint_cache *iint = (struct integrity_iint_cache *)foo;
>   
>   	memset(iint, 0, sizeof(*iint));
>   	iint->ima_file_status = INTEGRITY_UNKNOWN;
James Morris April 6, 2021, 2:38 a.m. UTC | #3
On Tue, 6 Apr 2021, Jiele Zhao wrote:

> Ping.

Mimi Zohar is the maintainer for this code.

> 
> On 2021/3/23 9:33, Jiele Zhao wrote:
> > init_once is a callback to kmem_cache_create. The parameter
> > type of this function is void *, so it's better to give a
> > explicit cast here.
> >
> > Signed-off-by: Jiele Zhao <unclexiaole@gmail.com>
> > ---
> >   security/integrity/iint.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/security/integrity/iint.c b/security/integrity/iint.c
> > index 1d20003243c3..5f3f2de997e1 100644
> > --- a/security/integrity/iint.c
> > +++ b/security/integrity/iint.c
> > @@ -152,7 +152,7 @@ void integrity_inode_free(struct inode *inode)
> >   
> >   static void init_once(void *foo)
> >   {
> > -	struct integrity_iint_cache *iint = foo;
> > +	struct integrity_iint_cache *iint = (struct integrity_iint_cache
> > *)foo;
> >   
> >    memset(iint, 0, sizeof(*iint));
> >    iint->ima_file_status = INTEGRITY_UNKNOWN;
>
Jiele Zhao April 6, 2021, 6:24 a.m. UTC | #4
Hi Mimi,

Please see if this is a useful suggestion.

On 2021/4/6 10:38, James Morris wrote:
> On Tue, 6 Apr 2021, Jiele Zhao wrote:
>
>> Ping.
> Mimi Zohar is the maintainer for this code.
>
>> On 2021/3/23 9:33, Jiele Zhao wrote:
>>> init_once is a callback to kmem_cache_create. The parameter
>>> type of this function is void *, so it's better to give a
>>> explicit cast here.
>>>
>>> Signed-off-by: Jiele Zhao <unclexiaole@gmail.com>
>>> ---
>>>    security/integrity/iint.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/security/integrity/iint.c b/security/integrity/iint.c
>>> index 1d20003243c3..5f3f2de997e1 100644
>>> --- a/security/integrity/iint.c
>>> +++ b/security/integrity/iint.c
>>> @@ -152,7 +152,7 @@ void integrity_inode_free(struct inode *inode)
>>>    
>>>    static void init_once(void *foo)
>>>    {
>>> -	struct integrity_iint_cache *iint = foo;
>>> +	struct integrity_iint_cache *iint = (struct integrity_iint_cache
>>> *)foo;
>>>    
>>>     memset(iint, 0, sizeof(*iint));
>>>     iint->ima_file_status = INTEGRITY_UNKNOWN;
Mimi Zohar April 6, 2021, 12:46 p.m. UTC | #5
Hi Jiele,

On Tue, 2021-03-23 at 01:33 +0000, Jiele Zhao wrote:
> init_once is a callback to kmem_cache_create. The parameter
> type of this function is void *, so it's better to give a
> explicit cast here.
> 
> Signed-off-by: Jiele Zhao <unclexiaole@gmail.com>

Please remove the "ima" in the Subject line and re-post Cc'ing the
linux-integrity mailing list.

> ---
>  security/integrity/iint.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/security/integrity/iint.c b/security/integrity/iint.c
> index 1d20003243c3..5f3f2de997e1 100644
> --- a/security/integrity/iint.c
> +++ b/security/integrity/iint.c
> @@ -152,7 +152,7 @@ void integrity_inode_free(struct inode *inode)
> 
>  static void init_once(void *foo)
>  {
> -	struct integrity_iint_cache *iint = foo;
> +	struct integrity_iint_cache *iint = (struct integrity_iint_cache *)foo;

Like the other init_once() examples, please add a blank before foo.

thanks,

Mimi
> 
>  	memset(iint, 0, sizeof(*iint));
>  	iint->ima_file_status = INTEGRITY_UNKNOWN;
diff mbox series

Patch

diff --git a/security/integrity/iint.c b/security/integrity/iint.c
index 1d20003243c3..5f3f2de997e1 100644
--- a/security/integrity/iint.c
+++ b/security/integrity/iint.c
@@ -152,7 +152,7 @@  void integrity_inode_free(struct inode *inode)
 
 static void init_once(void *foo)
 {
-	struct integrity_iint_cache *iint = foo;
+	struct integrity_iint_cache *iint = (struct integrity_iint_cache *)foo;
 
 	memset(iint, 0, sizeof(*iint));
 	iint->ima_file_status = INTEGRITY_UNKNOWN;