diff mbox series

[v2,7/7] evm: Don't return an error in evm_write_xattrs() if audit is not enabled

Message ID 20210528073812.407936-8-roberto.sassu@huawei.com (mailing list archive)
State New
Headers show
Series ima: Add template fields to verify EVM portable signatures | expand

Commit Message

Roberto Sassu May 28, 2021, 7:38 a.m. UTC
This patch avoids that evm_write_xattrs() returns an error when audit is
not enabled. The ab variable can be NULL and still be passed to the other
audit_log_() functions, as those functions do not include any instruction.

Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
 security/integrity/evm/evm_secfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series


diff --git a/security/integrity/evm/evm_secfs.c b/security/integrity/evm/evm_secfs.c
index ec3ed75a347d..07e263ae13e0 100644
--- a/security/integrity/evm/evm_secfs.c
+++ b/security/integrity/evm/evm_secfs.c
@@ -196,7 +196,7 @@  static ssize_t evm_write_xattrs(struct file *file, const char __user *buf,
 	ab = audit_log_start(audit_context(), GFP_KERNEL,
-	if (!ab)
 		return -ENOMEM;
 	xattr = kmalloc(sizeof(struct xattr_list), GFP_KERNEL);