| Message ID | 20220711072202.2319030-1-niejianglei2021@163.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | ima/evm: Fix potential memory leak in ima_init_crypto() | expand |
On Mon, 2022-07-11 at 15:22 +0800, Jianglei Nie wrote: > This patch adds the missing kfree() for ima_algo_array allocated by > kcalloc() to avoid potential memory leak. Missing is the reason that ima_algo_array is being freed. Perhaps something like, "On failure to allocate the SHA1 tfm, IMA fails to initialize and exits without freeing the ima_algo_array. Add the missing kfree() for ima_algo_array to avoid the potential memory leak." thanks, Mimi
diff --git a/security/integrity/ima/ima_crypto.c b/security/integrity/ima/ima_crypto.c index a7206cc1d7d1..64499056648a 100644 --- a/security/integrity/ima/ima_crypto.c +++ b/security/integrity/ima/ima_crypto.c @@ -205,6 +205,7 @@ int __init ima_init_crypto(void) crypto_free_shash(ima_algo_array[i].tfm); } + kfree(ima_algo_array); out: crypto_free_shash(ima_shash_tfm); return rc;
This patch adds the missing kfree() for ima_algo_array allocated by kcalloc() to avoid potential memory leak. Signed-off-by: Jianglei Nie <niejianglei2021@163.com> --- security/integrity/ima/ima_crypto.c | 1 + 1 file changed, 1 insertion(+)