diff mbox series

apparmor: Mark alloc_unconfined() as static

Message ID 20220719021218.6807-1-jrdr.linux@gmail.com (mailing list archive)
State Handled Elsewhere
Headers show
Series apparmor: Mark alloc_unconfined() as static | expand

Commit Message

Souptick Joarder July 19, 2022, 2:12 a.m. UTC
From: "Souptick Joarder (HPE)" <jrdr.linux@gmail.com>

Kernel test robot throws below warning ->
security/apparmor/policy_ns.c:83:20: warning: no previous prototype
for function 'alloc_unconfined' [-Wmissing-prototypes]

Mark it as static.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com>
---
 security/apparmor/policy_ns.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

John Johansen July 20, 2022, 2:29 a.m. UTC | #1
On 7/18/22 19:12, Souptick Joarder wrote:
> From: "Souptick Joarder (HPE)" <jrdr.linux@gmail.com>
> 
> Kernel test robot throws below warning ->
> security/apparmor/policy_ns.c:83:20: warning: no previous prototype
> for function 'alloc_unconfined' [-Wmissing-prototypes]
> 
> Mark it as static.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com>

Thanks, I have pulled this into apparmor-next

Acked-by: John Johansen <john.johansen@canonical.com>


> ---
>   security/apparmor/policy_ns.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/security/apparmor/policy_ns.c b/security/apparmor/policy_ns.c
> index 300953a02a24..4f6e9b3c24e6 100644
> --- a/security/apparmor/policy_ns.c
> +++ b/security/apparmor/policy_ns.c
> @@ -80,7 +80,7 @@ const char *aa_ns_name(struct aa_ns *curr, struct aa_ns *view, bool subns)
>   	return aa_hidden_ns_name;
>   }
>   
> -struct aa_profile *alloc_unconfined(const char *name)
> +static struct aa_profile *alloc_unconfined(const char *name)
>   {
>   	struct aa_profile *profile;
>
diff mbox series

Patch

diff --git a/security/apparmor/policy_ns.c b/security/apparmor/policy_ns.c
index 300953a02a24..4f6e9b3c24e6 100644
--- a/security/apparmor/policy_ns.c
+++ b/security/apparmor/policy_ns.c
@@ -80,7 +80,7 @@  const char *aa_ns_name(struct aa_ns *curr, struct aa_ns *view, bool subns)
 	return aa_hidden_ns_name;
 }
 
-struct aa_profile *alloc_unconfined(const char *name)
+static struct aa_profile *alloc_unconfined(const char *name)
 {
 	struct aa_profile *profile;