From patchwork Wed May 3 06:43:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aleksandr Mikhalitsyn X-Patchwork-Id: 13229519 X-Patchwork-Delegate: paul@paul-moore.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29A76C77B78 for ; Wed, 3 May 2023 06:44:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229567AbjECGoz (ORCPT ); Wed, 3 May 2023 02:44:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229488AbjECGoy (ORCPT ); Wed, 3 May 2023 02:44:54 -0400 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6BFC2680 for ; Tue, 2 May 2023 23:44:51 -0700 (PDT) Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 0BD2F3F445 for ; Wed, 3 May 2023 06:44:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1683096290; bh=CbwPmz2P7xN6zL203S8qJj89Z+3qclxrXH5+1gyHu6M=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=RP4Hj07Q+h+6qwaOeQjcOHQ9v0gucSGQI4DwhYMtYrYcXieBjmT0ACxu26i5KzM0m XgWdHPCateKotvoDWrIUUrBkWiPfhlwN/cUgBA6YUxK8EPS1wGVe9nmaQH+rRzY9+5 8ZJI3kkB83xTvvW9hwY9grTUY8EMdV6y+3xUviw4/A4LB+BaLiYgRv4lsMn6oo+4fm 50CDcHOb2TpQnY2vjnUZUW57RjYEIqXCW8HzVQ+dDtzbrAIPZk9jb58+Sm2oYL8hVk kR1/O/+AFuiniDJqhY4tSOVscOhSvMgfECud5qJEwrw/4+y64wDrj/JMDVv8wdvDdQ ivFNk3oAWjmdA== Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-94a348facbbso576161066b.1 for ; Tue, 02 May 2023 23:44:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683096289; x=1685688289; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CbwPmz2P7xN6zL203S8qJj89Z+3qclxrXH5+1gyHu6M=; b=Kpl+O9I0ra253UQre2n5xgWK6gv+r1APS09knYYW1myNVA+Q3UgqUCzsDayozxBvBN Jey9TiPikDnZnwCeIsBoHTSrDljDVjnMJs/GtA8+4iMX3m8A2OJjoFO+DsKB9jEoDBNE EFbHgKOnKkXhMzr4nS1K++md3OXAscxMnoKE+b4fFOwGCNbmWoHSt0dpe/ml6lsNVk4f UHs9MmG/IWZkWQrePWYvLzrhcOGtr13SrhYFUeRMvcBvdrOhS5FpDRfZZ/f8o1fpPjB5 2phM88hGETtQN47FuVxkSLYUYOkm5mslOXLwiKWgGZekkQWUDh0yfJP6BCjfKcNHWLxU /QwQ== X-Gm-Message-State: AC+VfDzk3ZYmd06VwO2jQNFYZ2EUPn43IG3/OkTsBj7SmFEo6Z8yJwhb RLkjXiSykx0IhExcj3Qtwces2U81e4vGBjbQBaMd4a+JAfNlTYRjuu/EWmh8mA5oZIvJUu7i4zO M/+5ZGzAyB7/ie92SYach2MM2t9cDUYziF/LEiJ/4HFF65joZvjDstw== X-Received: by 2002:a17:907:6d8a:b0:92b:69cd:34c7 with SMTP id sb10-20020a1709076d8a00b0092b69cd34c7mr2010525ejc.40.1683096289817; Tue, 02 May 2023 23:44:49 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7skTmNTqRCqW6NVDyn9k/KK96LA43+EPzYgWnzw0kkpsf5ycBgKL5hiFmzoK2GwNnHlcUeIA== X-Received: by 2002:a17:907:6d8a:b0:92b:69cd:34c7 with SMTP id sb10-20020a1709076d8a00b0092b69cd34c7mr2010514ejc.40.1683096289565; Tue, 02 May 2023 23:44:49 -0700 (PDT) Received: from amikhalitsyn.. ([62.168.35.11]) by smtp.gmail.com with ESMTPSA id e6-20020a1709062c0600b0094ef2003581sm16831270ejh.153.2023.05.02.23.44.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 23:44:49 -0700 (PDT) From: Alexander Mikhalitsyn To: mortonm@chromium.org Cc: penguin-kernel@i-love.sakura.ne.jp, Alexander Mikhalitsyn , Paul Moore , James Morris , "Serge E. Hallyn" , linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] LSM: SafeSetID: fix UID printed instead of GID Date: Wed, 3 May 2023 08:43:44 +0200 Message-Id: <20230503064344.45825-1-aleksandr.mikhalitsyn@canonical.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: pr_warn message clearly says that GID should be printed, but we have UID there. Let's fix that. Found accidentaly during the work on isolated user namespaces. Signed-off-by: Alexander Mikhalitsyn Reviewed-by: Paul Moore --- v2: __kuid_val -> __kgid_val --- security/safesetid/lsm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/security/safesetid/lsm.c b/security/safesetid/lsm.c index e806739f7868..5be5894aa0ea 100644 --- a/security/safesetid/lsm.c +++ b/security/safesetid/lsm.c @@ -131,7 +131,7 @@ static int safesetid_security_capable(const struct cred *cred, * set*gid() (e.g. setting up userns gid mappings). */ pr_warn("Operation requires CAP_SETGID, which is not available to GID %u for operations besides approved set*gid transitions\n", - __kuid_val(cred->uid)); + __kgid_val(cred->gid)); return -EPERM; default: /* Error, the only capabilities were checking for is CAP_SETUID/GID */