| Message ID | 20230621074623.498647-1-cuigaosheng1@huawei.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Delegated to: | Paul Moore |
| Headers | show |
| Series | [-next] trusted-keys: Fix kernel-doc warnings in trusted-keys | expand |
On Wed, Jun 21, 2023 at 3:46 AM Gaosheng Cui <cuigaosheng1@huawei.com> wrote: > > Fix kernel-doc warnings in trusted-keys: > > security/keys/trusted-keys/trusted_tpm2.c:203: warning: expecting > prototype for tpm_buf_append_auth(). Prototype was for > tpm2_buf_append_auth() instead. > > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> > --- > security/keys/trusted-keys/trusted_tpm2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Paul Moore <paul@paul-moore.com>
On Wed, Jun 21, 2023 at 9:33 AM Paul Moore <paul@paul-moore.com> wrote: > > On Wed, Jun 21, 2023 at 3:46 AM Gaosheng Cui <cuigaosheng1@huawei.com> wrote: > > > > Fix kernel-doc warnings in trusted-keys: > > > > security/keys/trusted-keys/trusted_tpm2.c:203: warning: expecting > > prototype for tpm_buf_append_auth(). Prototype was for > > tpm2_buf_append_auth() instead. > > > > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> > > --- > > security/keys/trusted-keys/trusted_tpm2.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Reviewed-by: Paul Moore <paul@paul-moore.com> Jarkko, David, can one of you pick this up into your tree?
On Tue, Jul 25, 2023 at 4:49 PM Paul Moore <paul@paul-moore.com> wrote: > On Wed, Jun 21, 2023 at 9:33 AM Paul Moore <paul@paul-moore.com> wrote: > > On Wed, Jun 21, 2023 at 3:46 AM Gaosheng Cui <cuigaosheng1@huawei.com> wrote: > > > > > > Fix kernel-doc warnings in trusted-keys: > > > > > > security/keys/trusted-keys/trusted_tpm2.c:203: warning: expecting > > > prototype for tpm_buf_append_auth(). Prototype was for > > > tpm2_buf_append_auth() instead. > > > > > > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> > > > --- > > > security/keys/trusted-keys/trusted_tpm2.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Reviewed-by: Paul Moore <paul@paul-moore.com> > > Jarkko, David, can one of you pick this up into your tree? Guys, this patch is both trivial and obviously correct, please pick it up so it can go up during the next merge window.
On Thu, 2023-08-03 at 18:00 -0400, Paul Moore wrote: > On Tue, Jul 25, 2023 at 4:49 PM Paul Moore <paul@paul-moore.com> wrote: > > On Wed, Jun 21, 2023 at 9:33 AM Paul Moore <paul@paul-moore.com> wrote: > > > On Wed, Jun 21, 2023 at 3:46 AM Gaosheng Cui <cuigaosheng1@huawei.com> wrote: > > > > > > > > Fix kernel-doc warnings in trusted-keys: > > > > > > > > security/keys/trusted-keys/trusted_tpm2.c:203: warning: expecting > > > > prototype for tpm_buf_append_auth(). Prototype was for > > > > tpm2_buf_append_auth() instead. > > > > > > > > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> > > > > --- > > > > security/keys/trusted-keys/trusted_tpm2.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > Reviewed-by: Paul Moore <paul@paul-moore.com> > > > > Jarkko, David, can one of you pick this up into your tree? > > Guys, this patch is both trivial and obviously correct, please pick it > up so it can go up during the next merge window. Paul, either Jarkko or I can queue a trusted-keys patch. As this isn't on the top of Jarkko's radar, I'll queue it. Mimi
On Thu, Aug 3, 2023 at 6:21 PM Mimi Zohar <zohar@linux.ibm.com> wrote: > > On Thu, 2023-08-03 at 18:00 -0400, Paul Moore wrote: > > On Tue, Jul 25, 2023 at 4:49 PM Paul Moore <paul@paul-moore.com> wrote: > > > On Wed, Jun 21, 2023 at 9:33 AM Paul Moore <paul@paul-moore.com> wrote: > > > > On Wed, Jun 21, 2023 at 3:46 AM Gaosheng Cui <cuigaosheng1@huawei.com> wrote: > > > > > > > > > > Fix kernel-doc warnings in trusted-keys: > > > > > > > > > > security/keys/trusted-keys/trusted_tpm2.c:203: warning: expecting > > > > > prototype for tpm_buf_append_auth(). Prototype was for > > > > > tpm2_buf_append_auth() instead. > > > > > > > > > > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> > > > > > --- > > > > > security/keys/trusted-keys/trusted_tpm2.c | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > Reviewed-by: Paul Moore <paul@paul-moore.com> > > > > > > Jarkko, David, can one of you pick this up into your tree? > > > > Guys, this patch is both trivial and obviously correct, please pick it > > up so it can go up during the next merge window. > > Paul, either Jarkko or I can queue a trusted-keys patch. As this isn't > on the top of Jarkko's radar, I'll queue it. Ah ha! I was working under the assumption that everything under security/keys/ was David and Jarko's responsibility, but now that I'm looking at MAINTAINERS I see that isn't the case. In fact it looks like there are five (!) different "subsystems" under security/keys/ ... I don't currently know enough about the different divisions there, but it seems like we might want to see if we can do some consolidation ... Anyway, thanks for picking this up Mimi.
On Thu, 2023-08-03 at 19:20 -0400, Paul Moore wrote: > On Thu, Aug 3, 2023 at 6:21 PM Mimi Zohar <zohar@linux.ibm.com> wrote: > > > > On Thu, 2023-08-03 at 18:00 -0400, Paul Moore wrote: > > > On Tue, Jul 25, 2023 at 4:49 PM Paul Moore <paul@paul-moore.com> wrote: > > > > On Wed, Jun 21, 2023 at 9:33 AM Paul Moore <paul@paul-moore.com> wrote: > > > > > On Wed, Jun 21, 2023 at 3:46 AM Gaosheng Cui <cuigaosheng1@huawei.com> wrote: > > > > > > > > > > > > Fix kernel-doc warnings in trusted-keys: > > > > > > > > > > > > security/keys/trusted-keys/trusted_tpm2.c:203: warning: expecting > > > > > > prototype for tpm_buf_append_auth(). Prototype was for > > > > > > tpm2_buf_append_auth() instead. > > > > > > > > > > > > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> > > > > > > --- > > > > > > security/keys/trusted-keys/trusted_tpm2.c | 2 +- > > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > Reviewed-by: Paul Moore <paul@paul-moore.com> > > > > > > > > Jarkko, David, can one of you pick this up into your tree? > > > > > > Guys, this patch is both trivial and obviously correct, please pick it > > > up so it can go up during the next merge window. > > > > Paul, either Jarkko or I can queue a trusted-keys patch. As this isn't > > on the top of Jarkko's radar, I'll queue it. > > Ah ha! I was working under the assumption that everything under > security/keys/ was David and Jarko's responsibility, but now that I'm > looking at MAINTAINERS I see that isn't the case. In fact it looks > like there are five (!) different "subsystems" under security/keys/ > ... I don't currently know enough about the different divisions there, > but it seems like we might want to see if we can do some consolidation > ... > > Anyway, thanks for picking this up Mimi. Thanks, Steven. "6c95d71bad61 tracing: Fix kernel-doc warnings in trace_seq.c " is in Linus' tree. Mimi
diff --git a/security/keys/trusted-keys/trusted_tpm2.c b/security/keys/trusted-keys/trusted_tpm2.c index 2b2c8eb258d5..bc700f85f80b 100644 --- a/security/keys/trusted-keys/trusted_tpm2.c +++ b/security/keys/trusted-keys/trusted_tpm2.c @@ -186,7 +186,7 @@ int tpm2_key_priv(void *context, size_t hdrlen, } /** - * tpm_buf_append_auth() - append TPMS_AUTH_COMMAND to the buffer. + * tpm2_buf_append_auth() - append TPMS_AUTH_COMMAND to the buffer. * * @buf: an allocated tpm_buf instance * @session_handle: session handle
Fix kernel-doc warnings in trusted-keys: security/keys/trusted-keys/trusted_tpm2.c:203: warning: expecting prototype for tpm_buf_append_auth(). Prototype was for tpm2_buf_append_auth() instead. Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> --- security/keys/trusted-keys/trusted_tpm2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)