diff mbox series

landlock: fix typo in landlock_append_net_rule() stub function

Message ID 20231017143341.2875980-1-arnd@kernel.org (mailing list archive)
State Handled Elsewhere
Headers show
Series landlock: fix typo in landlock_append_net_rule() stub function | expand

Commit Message

Arnd Bergmann Oct. 17, 2023, 2:33 p.m. UTC
From: Arnd Bergmann <arnd@arndb.de>

There is an extraneous semicolon in the empty stub helper for
this function tha causes randconfig builds to break:

In file included from security/landlock/setup.c:17:
security/landlock/net.h:28:1: error: expected identifier or '(' before '{' token
security/landlock/net.h:26:1: error: 'landlock_append_net_rule' declared 'static' but never defined [-Werror=unused-function]

Fixes: 614d46b333ab9 ("landlock: Add network rules and TCP hooks support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 security/landlock/net.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mickaël Salaün Oct. 17, 2023, 7:48 p.m. UTC | #1
Thanks Arnd, I fixed the issue and squashed it in -next.

There will be a next patch series including other fixes.

On Tue, Oct 17, 2023 at 04:33:35PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> There is an extraneous semicolon in the empty stub helper for
> this function tha causes randconfig builds to break:
> 
> In file included from security/landlock/setup.c:17:
> security/landlock/net.h:28:1: error: expected identifier or '(' before '{' token
> security/landlock/net.h:26:1: error: 'landlock_append_net_rule' declared 'static' but never defined [-Werror=unused-function]
> 
> Fixes: 614d46b333ab9 ("landlock: Add network rules and TCP hooks support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  security/landlock/net.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/security/landlock/net.h b/security/landlock/net.h
> index 588a49fd69076..09960c237a13e 100644
> --- a/security/landlock/net.h
> +++ b/security/landlock/net.h
> @@ -24,7 +24,7 @@ static inline void landlock_add_net_hooks(void)
>  
>  static inline int
>  landlock_append_net_rule(struct landlock_ruleset *const ruleset, const u16 port,
> -			 access_mask_t access_rights);
> +			 access_mask_t access_rights)
>  {
>  	return -EAFNOSUPPORT;
>  }
> -- 
> 2.39.2
>
diff mbox series

Patch

diff --git a/security/landlock/net.h b/security/landlock/net.h
index 588a49fd69076..09960c237a13e 100644
--- a/security/landlock/net.h
+++ b/security/landlock/net.h
@@ -24,7 +24,7 @@  static inline void landlock_add_net_hooks(void)
 
 static inline int
 landlock_append_net_rule(struct landlock_ruleset *const ruleset, const u16 port,
-			 access_mask_t access_rights);
+			 access_mask_t access_rights)
 {
 	return -EAFNOSUPPORT;
 }