| Message ID | 20241212075956.2614894-1-song@kernel.org (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | [bpf-next] bpf: lsm: Remove hook to bpf_task_storage_free | expand |
On Wed, Dec 11, 2024 at 11:59:56PM -0800, Song Liu wrote: > free_task() already calls bpf_task_storage_free(). It is not necessary > to call it again on security_task_free(). Remove the hook. Acked-by: Matt Bobrowski <mattbobrowski@google.com> > Signed-off-by: Song Liu <song@kernel.org> > > --- > > This was initially sent in a patchset [1]. However, this patch is not > closely related to other patches in the set, so sending it alone. > > [1] https://lore.kernel.org/bpf/20241112083700.356299-1-song@kernel.org/ > --- > security/bpf/hooks.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/security/bpf/hooks.c b/security/bpf/hooks.c > index 3663aec7bcbd..db759025abe1 100644 > --- a/security/bpf/hooks.c > +++ b/security/bpf/hooks.c > @@ -13,7 +13,6 @@ static struct security_hook_list bpf_lsm_hooks[] __ro_after_init = { > #include <linux/lsm_hook_defs.h> > #undef LSM_HOOK > LSM_HOOK_INIT(inode_free_security, bpf_inode_storage_free), > - LSM_HOOK_INIT(task_free, bpf_task_storage_free), > }; > > static const struct lsm_id bpf_lsmid = { > -- > 2.43.5 >
Hello: This patch was applied to bpf/bpf-next.git (master) by Martin KaFai Lau <martin.lau@kernel.org>: On Wed, 11 Dec 2024 23:59:56 -0800 you wrote: > free_task() already calls bpf_task_storage_free(). It is not necessary > to call it again on security_task_free(). Remove the hook. > > Signed-off-by: Song Liu <song@kernel.org> > > --- > > [...] Here is the summary with links: - [bpf-next] bpf: lsm: Remove hook to bpf_task_storage_free https://git.kernel.org/bpf/bpf-next/c/58ecb3a789fd You are awesome, thank you!
diff --git a/security/bpf/hooks.c b/security/bpf/hooks.c index 3663aec7bcbd..db759025abe1 100644 --- a/security/bpf/hooks.c +++ b/security/bpf/hooks.c @@ -13,7 +13,6 @@ static struct security_hook_list bpf_lsm_hooks[] __ro_after_init = { #include <linux/lsm_hook_defs.h> #undef LSM_HOOK LSM_HOOK_INIT(inode_free_security, bpf_inode_storage_free), - LSM_HOOK_INIT(task_free, bpf_task_storage_free), }; static const struct lsm_id bpf_lsmid = {
free_task() already calls bpf_task_storage_free(). It is not necessary to call it again on security_task_free(). Remove the hook. Signed-off-by: Song Liu <song@kernel.org> --- This was initially sent in a patchset [1]. However, this patch is not closely related to other patches in the set, so sending it alone. [1] https://lore.kernel.org/bpf/20241112083700.356299-1-song@kernel.org/ --- security/bpf/hooks.c | 1 - 1 file changed, 1 deletion(-)