diff mbox series

ALSA: usb-audio: US16x08: Initialize array before use

Message ID 20241228071920.3252-1-tanyaagarwal25699@gmail.com (mailing list archive)
State New
Headers show
Series ALSA: usb-audio: US16x08: Initialize array before use | expand

Commit Message

Tanya Agarwal Dec. 28, 2024, 7:19 a.m. UTC 
From: Tanya Agarwal <tanyaagarwal25699@gmail.com>

Initialize array before use in mixer_us16x08.c to prevent the
issues related to uninitialized memory access.

CID 1410197: (#1 of 1): Uninitialized scalar variable (UNINIT)
uninit_use_in_call: Using uninitialized value *meter_urb when
calling get_meter_levels_from_urb

Coverity Link:
https://scan7.scan.coverity.com/#/project-view/52849/11354?selectedIssue=1410197

Signed-off-by: Tanya Agarwal <tanyaagarwal25699@gmail.com>
---
 sound/usb/mixer_us16x08.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Markus Elfring Dec. 28, 2024, 5:49 p.m. UTC | #1 
> Initialize array before use in mixer_us16x08.c to prevent the
> issues related to uninitialized memory access.
…

* You may occasionally put more than 61 characters into text lines
  of such a change description.

* How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.13-rc4#n145


Regards,
Markus
diff mbox series

Patch

diff --git a/sound/usb/mixer_us16x08.c b/sound/usb/mixer_us16x08.c
index 6eb7d93b358d..20ac32635f1f 100644
--- a/sound/usb/mixer_us16x08.c
+++ b/sound/usb/mixer_us16x08.c
@@ -687,7 +687,7 @@  static int snd_us16x08_meter_get(struct snd_kcontrol *kcontrol,
 	struct usb_mixer_elem_info *elem = kcontrol->private_data;
 	struct snd_usb_audio *chip = elem->head.mixer->chip;
 	struct snd_us16x08_meter_store *store = elem->private_data;
-	u8 meter_urb[64];
+	u8 meter_urb[64] = {0};
 
 	switch (kcontrol->private_value) {
 	case 0: {