From patchwork Mon May 30 12:56:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sedat Dilek X-Patchwork-Id: 9141327 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B6EEF60777 for ; Mon, 30 May 2016 12:56:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9533F28066 for ; Mon, 30 May 2016 12:56:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 88E5D2821F; Mon, 30 May 2016 12:56:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_TVD_MIME_EPI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B224728066 for ; Mon, 30 May 2016 12:56:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754790AbcE3M42 (ORCPT ); Mon, 30 May 2016 08:56:28 -0400 Received: from mail-vk0-f65.google.com ([209.85.213.65]:35296 "EHLO mail-vk0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754755AbcE3M40 (ORCPT ); Mon, 30 May 2016 08:56:26 -0400 Received: by mail-vk0-f65.google.com with SMTP id f62so1836311vkc.2; Mon, 30 May 2016 05:56:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc; bh=Nlv6kIfHnaY6l1pWraICV6HSKDhEizytPCe8Q+Xn2b0=; b=Ckl36oJv5dNfyrFBxXFYfHA5P3ZzTy8wNRB7Q8ASr7j7K2uA7cNuyBfV9Pfc+OPOJf 3L0IBcrD3jHu+w9d4DQ2F+VzZeLZYL1Ru9Do9GSBUKRTSWj3tjZ+0x5s8gepnz5SgCbe AXxgdLqsztXaP12c5v+hR7GCdKy6Jmc0H7bK9VpC6cuBPE39TTaC4xY1GeE2AfrVBZzX mKbcD6qvd2+jWf5si7hkqDRU6jDjFZQjEyg8gMYPs59vyIzaczhtuFbeBYCXJBmEBLAp NHC3fw8TMWFXTkdDBRnmn3yrzddMKzPATDaQzI9fdgP6BUtukWafiWiu62yLCoRBTUOu e1uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :date:message-id:subject:from:to:cc; bh=Nlv6kIfHnaY6l1pWraICV6HSKDhEizytPCe8Q+Xn2b0=; b=DhFHrN5qkBisCkeY9o7oux5tdM6cvVx62FOHfzHGrLAJ+fFzA7GaqMFKiH8GiqSDhc hyinRC2Sl66qZjaXLS+BVP+RWJkcARYUseYbfzBA3VQOTlKdzLZEvkO9LJtUGF0R/4B+ wI2K24aGXV9L2/TIRI46YoPLdRpxaathT5GbW/Ww3eCqtRQpB5DQldMyd78vEDy/e5nF m3YCCnB4EsjBnlt5AvNvctqx+KTd2097/cJgXBlrucqmxiMh+bZNck5gXBtJ/MS9NWIa 7VDS6o37ry5sO1Ir334bLc6WdakiIo2ESyUVMUNUH96idXnFLMJL7gPryvnvethctXjZ ygVg== X-Gm-Message-State: ALyK8tIgJWEh52oaB4pOG6vuIHGfBl+a22xN1dcyVrC2W5/FDpTPu//M+QEbKH6NyfIsl8mNoxCxEmHX2wbBlw== MIME-Version: 1.0 X-Received: by 10.159.39.133 with SMTP id b5mr14847108uab.58.1464612985431; Mon, 30 May 2016 05:56:25 -0700 (PDT) Received: by 10.103.82.138 with HTTP; Mon, 30 May 2016 05:56:24 -0700 (PDT) Reply-To: sedat.dilek@gmail.com In-Reply-To: References: <1464598653-3656-1-git-send-email-agruenba@redhat.com> Date: Mon, 30 May 2016 14:56:24 +0200 Message-ID: Subject: Re: [PATCH v3 00/17] Xattr inode operation removal From: Sedat Dilek To: Andreas Gruenbacher Cc: Alexander Viro , linux-fsdevel , Tyler Hicks , ecryptfs@vger.kernel.org, Miklos Szeredi , linux-unionfs@vger.kernel.org, Mimi Zohar , linux-ima-devel@lists.sourceforge.net, LSM , David Howells , Serge Hallyn , Dmitry Kasatkin , Paul Moore , Stephen Smalley , Eric Paris , Casey Schaufler , Oleg Drokin , Andreas Dilger Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: X-Virus-Scanned: ClamAV using ClamSMTP On 5/30/16, Andreas Gruenbacher wrote: > On Mon, May 30, 2016 at 11:54 AM, Sedat Dilek > wrote: >> On 5/30/16, Andreas Gruenbacher wrote: >>> This is version 3 of the xattr inode operation removal patch series. The >>> patches are available in git form at: >>> >>> >>> https://git.kernel.org/cgit/linux/kernel/git/agruen/linux.git/log/?h=work.xattr > [...] >>> >> Hi, >> >> I pulled in agruen/linux.git#work.xattr on top of Linux v4.7-rc1 and >> noticed... >> >> 92 files changed, 563 insertions(+), 703 deletions(-) >> >> So this is on top of Linux v4.7-rc1+? > > Well, I've actually rebased the patches on top of commit b02b1fbd > which is the current mainline and one merge after v4.7-rc1, but the > few scsi commits in between -rc1 and b02b1fbd are completely > unrelated. You can easily see that in git. > I have seen the scsi changes when I ran my script which generates a patchset where latest "git-tag in Linus tree" is the base, here v4.7-rc1. >> I am here on Ubuntu/precise AMD64 realized as a WUBI-installation. >> So I use fuse, loop-device and ext4-fs. >> >> Not sure, how to test your patchset. >> Can you give some instructions on a testcase/usecase? > > The patches potentially affect xattrs and anthing that's xattr based, > like POSIX ACLs, SELinux, and Smack. There are some POSX ACL tests in > xfstests. The basic xattr functionality can of course be checked with > getfattr / setfattr. Other than that, I can probably only refer you to > the code itself. > Here I have LTP v20160126 installed. # cat /opt/ltp/Version 20160126 I ran acl_test01 (which I hacked a bit)... # LC_ALL=C ./runltp -s acl_test01 | tee acl_test01.log # cat results/LTP_RUN_ON-2016_05_30-14h_52m_29s.log Test Start Time: Mon May 30 14:52:30 2016 ----------------------------------------- Testcase Result Exit Value -------- ------ ---------- acl_test01 PASS 0 ----------------------------------------------- Total Tests: 1 Total Skipped Tests: 0 Total Failures: 0 Kernel Version: 4.7.0-rc1-2-iniza-small Machine Architecture: x86_64 Hostname: fambox ...and it looks good. >> Booting into a kernel with your patchset looks fine to me - on the 1st >> sight. > > Okay, thanks. > Cannot say if this helps you. - Sedat - P.S.: Hacking acl_test01 # diff -uprN ./testcases/bin/acl_test01.orig ./testcases/bin/acl_test01 - EOT - --- ./testcases/bin/acl_test01.orig 2016-03-27 21:45:00.768007420 +0200 +++ ./testcases/bin/acl_test01 2016-05-30 14:41:50.195986299 +0200 @@ -41,8 +41,6 @@ export TCID=acltest01 export TST_TOTAL=5 export TST_COUNT=1 -. test.sh - TMP=${TMP:=/tmp} TEST_USER1="acltest1" @@ -54,6 +52,8 @@ FILE_ACL="$TMP/tacl/mount-ext3/test_file FILE_ACL_LINK="$TMP/tacl/mount-ext3/test_file_link" TCbin=`pwd` +. $TCbin/test.sh + COMMAND=$(command -v "getenforce" "setenforce" |wc -l) if [ $COMMAND -eq 2 ]; then SELINUX=$(getenforce)