| Message ID | 1352803609-16669-1-git-send-email-hechtb@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Tue, Nov 13, 2012 at 11:46:49AM +0100, Bastian Hecht wrote: > The FLCTL driver now requires the resource of the error IRQ. Hi Bastian, could you provide a little more information on: * Why this is so. Is it related to a change in another commit? * What the implications are of this change not being applied: the driver doesn't work? > Signed-off-by: Bastian Hecht <hechtb@gmail.com> > --- > arch/arm/mach-shmobile/board-mackerel.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c > index 0c27c81..66ec616 100644 > --- a/arch/arm/mach-shmobile/board-mackerel.c > +++ b/arch/arm/mach-shmobile/board-mackerel.c > @@ -1018,7 +1018,11 @@ static struct resource nand_flash_resources[] = { > .start = 0xe6a30000, > .end = 0xe6a3009b, > .flags = IORESOURCE_MEM, > - } > + }, > + [1] = { > + .start = evt2irq(0x0d80), /* flstei: status error irq */ > + .flags = IORESOURCE_IRQ, > + }, > }; > > static struct sh_flctl_platform_data nand_flash_data = { > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Simon, > could you provide a little more information on: > * Why this is so. Is it related to a change in another commit? Oh sure. So, the error IRQ was introduced in commit 3c7ea4eccfd2e mtd: sh_flctl: Add support for error IRQ. It notifies us when the actual communication from our flash controller to the NAND chip fails. > * What the implications are of this change not being applied: > the driver doesn't work? Yes the driver refuses to start up if the error IRQ is missing. Do you think I should include such information into the commit message, or is it just helpful for the upstream process? Cheers, Bastian -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Nov 15, 2012 at 10:13:51AM +0100, Bastian Hecht wrote: > Hello Simon, > > > could you provide a little more information on: > > * Why this is so. Is it related to a change in another commit? > > Oh sure. So, the error IRQ was introduced in commit 3c7ea4eccfd2e mtd: > sh_flctl: Add support for error IRQ. > It notifies us when the actual communication from our flash controller > to the NAND chip fails. > > > * What the implications are of this change not being applied: > > the driver doesn't work? > > Yes the driver refuses to start up if the error IRQ is missing. > > Do you think I should include such information into the commit > message, or is it just helpful for the upstream process? Yes. Please re-post the patch with a revised commit message that includes the information above. -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c index 0c27c81..66ec616 100644 --- a/arch/arm/mach-shmobile/board-mackerel.c +++ b/arch/arm/mach-shmobile/board-mackerel.c @@ -1018,7 +1018,11 @@ static struct resource nand_flash_resources[] = { .start = 0xe6a30000, .end = 0xe6a3009b, .flags = IORESOURCE_MEM, - } + }, + [1] = { + .start = evt2irq(0x0d80), /* flstei: status error irq */ + .flags = IORESOURCE_IRQ, + }, }; static struct sh_flctl_platform_data nand_flash_data = {
The FLCTL driver now requires the resource of the error IRQ. Signed-off-by: Bastian Hecht <hechtb@gmail.com> --- arch/arm/mach-shmobile/board-mackerel.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)